Hi,
Sorry for the delay in replying, I was away for a few weeks :) I have finally reworked the patch according to your feedback.
On Mon, Oct 25, 2010 at 05:47:20PM +0100, Timo Sirainen wrote:
You can simplify the environment preserving with these changes:
http://hg.dovecot.org/dovecot-2.0/rev/e0a97842182f http://hg.dovecot.org/dovecot-2.0/rev/d1fd5b84d410
Ah, that indeed makes things much simpler, thanks!
I don't think this is portable. You could do it instead like:
Ok, I changed it even after reading your other email.
AS_HELP_STRING([--with-systemdsystemunitdir=DIR], [Directory for systemd service files]),[], [with_systemdsystemunitdir=$($PKG_CONFIG --variable=systemdsystemunitdir systemd)])Is this a common name for this option? If not, I'd prefer a shorter name.
I asked upstream about it, and I was told it's the usual way of naming options with the autotools, so they'd prefer if it was kept this way. But I don't mind changing it to something else if you prefer, I have a patch changing it to --with-systemd if needed.
Here is the updated patch, if you want I also have it as a patch series: systemd: Add proper systemd configure.in blob (from daemon(7)) systemd: Preserve LISTEN_FDS and LISTEN_PID during env cleanup when systemd is used systemd: Use sockets provided by systemd if possible systemd: When systemd didn't provide a suitable socket, fallback to the regular socket creation code systemd: Add systemd unit files
Christophe