Timo Sirainen wrote:
On Thu, 2009-03-05 at 14:42 -0800, Daniel L. Miller wrote:
With dbox yes, you can just ignore the error. Maildir probably would give user-visible errors.
Why the difference? I can see a big deal for mbox - but why Maildir?
It's just because of how the code was written. In maildir code if fdatasync_path() returns -1, the code continues returning -1 which eventually causes the entire operation to fail and an error be returned to user.
With dbox the code just didn't bother checking if fdatasync_path() returned -1 or 0. With mbox it never even calls that function.
So if dbox doesn't check - is that a "critical" function (I'm not even sure what it does)? Is there any reason I shouldn't ignore the dbox errors and continue trying it for a new server?
-- Daniel