Timo Sirainen wrote:
On Wed, 2009-09-30 at 17:21 +0100, Chris Wakelin wrote:
I've put in the patched imap-login and turned on per-process setid core dumps with "coreadm -e proc-setid" (I don't think we need the global setid ones). We had a few more imap-login crashes a few minutes before I made the changes :|
Did you also add -D parameter to imap-login? I don't think it otherwise can write core files (but who knows, maybe it can). You could also test it yourself by just kill -SEGV <imap-login pid>
No, according to the coreadm man page the core file gets written as root (and kill -SEGV worked on the test box).
I've only just spotted that we got one a few hours ago:
Sep 30 17:36:53 dovecot: Error: child 24413 (login) killed with signal 11 (core dumped) (latest ip=82.33.xx.xx)
(so not the Prayer server this time; someone via an ISP, for which we only allow IMAPS in the firewall). Here's the backtrace:
#0 client_get_extra_disconnect_reason (client=0x635b8) at client-common.c:206 206 if (ssl_require_client_cert) (gdb) bt #0 client_get_extra_disconnect_reason (client=0x635b8) at client-common.c:206 #1 0x299b4 in io_loop_run (ioloop=0x635b8) at ioloop.c:330 #2 0x1d314 in main (argc=0, argv=0xffbefb24, envp=0xffbefb2c) at main.c:487
so it looks like this one could be an SSL issue, but Prayer isn't using SSL; perhaps it just happens to appear as the "latest ip" as it's the most common one, and the crashes were caused by different connections altogether (we have login_process_per_connection = no)?
imap-login: Error: proxy: Unexpected input, ignoring: C OK CAPABILITY completed.: since the update. Looks pretty harmless to me though?
Harmless yes, but a bug anyway. This should fix it: http://hg.dovecot.org/dovecot-1.2/rev/5053bfd20001
Yep, that fixes it. I've seen one other though, occurring twice in fairly quick succession, but for different users (both staff on Exchange but still using Prayer Webmail instead of Outlook Web Access):
Sep 30 21:56:04 auth(default): Info: passwd-file(xxxxxxx,134.225.1.46): No password Sep 30 21:56:04 imap-login: Error: proxy: Unexpected input: + Ready for additional command text.: user=<xxxxxxx>, method=PLAIN, rip=134.225.1.46, lip=134.225.16.6
Sep 30 21:58:07 auth(default): Info: passwd-file(yyyyyyyy,134.225.1.46): No password Sep 30 21:58:07 imap-login: Error: proxy: Unexpected input: + Ready for additional command text.: user=<yyyyyyyy>, method=PLAIN, rip=134.225.1.46, lip=134.225.16.6
BTW the proxy.imap files read as passdbs look like:
<username>:::::::proxy=y nopassword=y host=134.225.1.104
Best Wishes, Chris
-- --+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+---+- Christopher Wakelin, c.d.wakelin@reading.ac.uk IT Services Centre, The University of Reading, Tel: +44 (0)118 378 8439 Whiteknights, Reading, RG6 2AF, UK Fax: +44 (0)118 975 3094