Re: Plugin charset_alias compile error: void function cannot return value

On 02 March 2018 at 00:59 John Woods john.woods@greatplainsmfg.com wrote:

Hey Everyone,

 We are getting a compile error for Dovecot 2.2.34 on Solaris 11.3 

x86, using Solaris Studio 12.6 compiler, and it doesn't occur with Dovecot 2.2.33.

Making all in charset-alias
source='charset-alias-plugin.c' object='charset-alias-plugin.lo'
libtool=yes \
DEPDIR=.deps depmode=none /bin/sh ../../../depcomp \
/bin/sh ../../../libtool  --tag=CC    --mode=compile cc
-DHAVE_CONFIG_H -I. -I../../..  -I../../../src/lib 
-I../../../src/lib-master -I../../../src/lib-mail 
-I../../../src/lib-charset -I../../../src/lib-index 
-I../../../src/lib-storage -m64 -I/usr/local/include
-I/usr/mysql/5.7/include -I/usr/local/include/sasl -I/usr/include
-L/usr/local/lib -L/usr/local/lib/sasl2 -L/usr/mysql/5.7/lib/64
-L/usr/lib/64 -L/usr/lib -R/usr/local/lib -R/usr/local/lib/sasl2
-R/usr/mysql/5.7/lib/64 -R/usr/lib/64 -R/usr/lib   -m64
-I/usr/local/include -I/usr/mysql/5.7/include
-I/usr/local/include/sasl -I/usr/include -L/usr/local/lib
-L/usr/local/lib/sasl2 -L/usr/mysql/5.7/lib/64 -L/usr/lib/64
-L/usr/lib -R/usr/local/lib -R/usr/local/lib/sasl2
-R/usr/mysql/5.7/lib/64 -R/usr/lib/64 -R/usr/lib -c -o
charset-alias-plugin.lo charset-alias-plugin.c
libtool: compile:  cc -DHAVE_CONFIG_H -I. -I../../..
-I../../../src/lib -I../../../src/lib-master -I../../../src/lib-mail
-I../../../src/lib-charset -I../../../src/lib-index
-I../../../src/lib-storage -m64 -I/usr/local/include
-I/usr/mysql/5.7/include -I/usr/local/include/sasl -I/usr/include
-L/usr/local/lib -L/usr/local/lib/sasl2 -L/usr/mysql/5.7/lib/64
-L/usr/lib/64 -L/usr/lib -R/usr/local/lib -R/usr/local/lib/sasl2
-R/usr/mysql/5.7/lib/64 -R/usr/lib/64 -R/usr/lib -m64
-I/usr/local/include -I/usr/mysql/5.7/include
-I/usr/local/include/sasl -I/usr/include -L/usr/local/lib
-L/usr/local/lib/sasl2 -L/usr/mysql/5.7/lib/64 -L/usr/lib/64
-L/usr/lib -R/usr/local/lib -R/usr/local/lib/sasl2
-R/usr/mysql/5.7/lib/64 -R/usr/lib/64 -R/usr/lib -c
charset-alias-plugin.c  -KPIC -DPIC -o .libs/charset-alias-plugin.o
*"charset-alias-plugin.c", line 86: void function cannot return value**
**"charset-alias-plugin.c", line 92: void function cannot return value*
cc: acomp failed for charset-alias-plugin.c

 In charset-alias-plugin.c, the functions 

charset_alias_to_utf8_end() and charset_alias_to_utf8_reset() are declared to return void, but they also attempt to return something. I suspect other compilers, such as GCC, might generate a warning about the "return" statement, but Solaris Studio compiler is being more strict about it...

 I suspect that the "return" keyword should be dropped from both 

functions. Thoughts?

Thanks, John

*John Woods | System Integration Administrator* *Great Plains Manufacturing* | 1030 E North St | Salina, KS 67401 P: 785-823-3276 ext. 2663 | F: 785-822-5676 | E: john.woods@greatplainsmfg.com mailto:john.woods@greatplainsmfg.com

http://www.greatplainsmfg.com/

http://www.facebook.com/greatplainsag http://www.twitter.com/greatplains_ag http://www.youtube.com/greatplainsmfg

Hi!

Thank you for your report, we'll take a look!

Aki