On Sat, 2006-11-04 at 10:07 -0700, Stephen Warren wrote:
Timo Sirainen wrote:
I did quite large changes related to this and other auth_bind related things. All of it is untested unfortunately, because I haven't bothered to figure out why my OpenLDAP server installation is broken (and I really don't want to spend time figuring it out either).
Surely the code-base should be pretty much frozen except for bug-fixes, since we're already *way* into an extremely protracted RC series.
I understand this change was to fix an existing bug, but it sounds like the change was far more than a simple bug fix. Major code rewrites, especially without any testing, don't seem right at this stage in the game.
In general I agree, but there wasn't any simple fix for this bug, except to just tell people that auth_bind sort of works but not really. And since so many people have wanted auth binds for a long time, I think it's better to fix it now than to hear complains about it for a long time.