Re: [Dovecot] Converting mbox files with dots in names to Maildir

The option parsing in convert-tool.c won't work, as the strcmp compares are wrong. The result should be compared equal to zero, not not-equal. Here's corrected code:

    for (i = 5; i < argc; i++) {
            if (strcmp(argv[i], "skip_broken_mailboxes") == 0)
                    set.skip_broken_mailboxes = TRUE;
            else if (strcmp(argv[i], "skip_dotdirs") == 0)
                    set.skip_dotdirs = TRUE;
            else if (strncmp(argv[i], "alt_hierarchy_char=", 19) == 0)
                    set.alt_hierarchy_char = argv[i][19];
    }

Even with this fix, and report of a successful conversion, glibc is reporting a double-free:

Info: Successfully converted *** glibc detected *** /tmp/convert-tool: double free or corruption (fasttop): 0x08ae9cc8 ***