(05.05.24 kl.01:46) Timo Sirainen skrev följande till Jens Laas:
On 19.5.2005, at 11:48, Jens Laas wrote:
- pop3 hang fix
pop3 still hangs for me.
Looks like my previous "fix" didn't actually do anything. Hmm. I looked at it quite a long time but couldn't really think of anything.. Or would the patch below help? If not I'll send you a patch that adds some debugging lines..
diff -u -r1.48 ostream-file.c --- src/lib/ostream-file.c 26 Apr 2005 11:08:16 -0000 1.48 +++ src/lib/ostream-file.c 23 May 2005 22:37:21 -0000 @@ -220,8 +220,10 @@
if (fstream->corked != set && !stream->ostream.closed) { if (set && fstream->io != NULL) { - io_remove(fstream->io); - fstream->io = NULL; + if (!fstream->flush_pending) { + io_remove(fstream->io); + fstream->io = NULL; + } } else if (!set) { ret = buffer_flush(fstream); if (fstream->io == NULL &&
No luck :( Debug patch please :)
Would it be possible to have some code that detected this condition and kickstarted the output (until all the bugs are found) ?
I guess that could be done, but I'd rather spend the time finding the problem than writing a horrible hack :)
OK. Sometimes horrible hacks can find horrible bugs too.. Jens ----------------------------------------------------------------------- 'This mail automatically becomes portable when carried.' ----------------------------------------------------------------------- Jens Låås Email: jens.laas@data.slu.se Department of Computer Services, SLU Phone: +46 18 67 35 15 Vindbrovägen 1 P.O. Box 7079 S-750 07 Uppsala SWEDEN -----------------------------------------------------------------------