Re: [Dovecot] Regression in settings-parser.c (dovecot 2.0.11)

On Fri, 2011-03-25 at 09:57 +0100, Michal Hlavinka wrote:

Hi,

one Fedora user sees regression in dovecot 2.0.11 (compared to prev. 2.0.9). There was change recently: http://hg.dovecot.org/dovecot-2.0/diff/bc77e80947c0/src/lib-settings/setting... which adds call to settings_find_key_nth(...., &parent_def,...). This function can set parent_def to NULL, but there is no check for this situation in the code. So on next line if (parent_def->type !=... dovecot crashes. We've tested simple fix: if (parent_def==NULL) return FALSE; and everything was working again.

I fixed it with: http://hg.dovecot.org/dovecot-2.0/rev/746b4e9e7015

I'm not really sure what the handling should be when parent_def=NULL. I think it might make a difference in future..