Re: Release 2.3.1

29 Mar 2018

      On 29.03.2018 10:36, Odhiambo Washington wrote:
...
On 29 March 2018 at 09:43, Aki Tuomi mailto:aki.tuomi@dovecot.fi> wrote:
On 28.03.2018 22:14, Odhiambo Washington wrote:
...
On 27 March 2018 at 20:06, <aki.tuomi@dovecot.fi
<mailto:aki.tuomi@dovecot.fi>> wrote:

    Hi!

    We are releasing v2.3.1, which mostly consists of bug fixes
    for 2.3.0, and few improvements. This is also available via
    https://repo.dovecot.org if you want packages. libsodium
    support didn't get into this build, due to build environment
    issues, but 2.3.2 will contain it.

    * Submission server support improvements and bug fixes
      - Lots of bug fixes to submission server
    * API CHANGE: array_idx_modifiable will no longer allocate space
     - Particularly affects how you should check MODULE_CONTEXT
    result, or use REQUIRE_MODULE_CONTEXT.

    + mail_attachment_detection_options setting controls when
      $HasAttachment and $HasNoAttachment keywords are set for mails.
    + imap: Support fetching body snippets using FETCH (SNIPPET) or
      (SNIPPET (LAZY=FUZZY))
    + fs-compress: Automatically detect whether input is
    compressed or not.
      Prefix the compression algorithm with "maybe-" to enable the
      detection, for example: "compress:maybe-gz:6:..."
    + Added settings to change dovecot.index* files' optimization
    behavior.
      See https://wiki2.dovecot.org/IndexFiles#Settings
    <https://wiki2.dovecot.org/IndexFiles#Settings>
    + Auth cache can now utilize auth workers to do password hash
      verification by setting
    auth_cache_verify_password_with_worker=yes.
    + Added charset_alias plugin. See
      https://wiki2.dovecot.org/Plugins/CharsetAlias
    <https://wiki2.dovecot.org/Plugins/CharsetAlias>
    + imap_logout_format and pop3_logout_format settings now
    support all of the generic variables (e.g. %{rip},
    %{session}, etc.)

    --
    Aki Tuomi
    Dovecot oy

Making all in lib-charset
/bin/sh ../../libtool  --tag=CC    --mode=link cc  -std=gnu99 -g
-O2 -fstack-protector-strong -U_FORTIFY_SOURCE
-D_FORTIFY_SOURCE=2 -Wall -W -Wmissing-prototypes
-Wmissing-declarations -Wpointer-arith -Wchar-subscripts
-Wformat=2 -Wbad-function-cast -Wno-duplicate-decl-specifier
-Wstrict-aliasing=2 -I/usr/local/include   -no-undefined
-Wl,--as-needed -o test-charset test-charset.o libcharset.la
<http://libcharset.la> ../lib-test/libtest.la
<http://libtest.la>  ../lib/liblib.la <http://liblib.la>
libtool: link: cc -std=gnu99 -g -O2 -fstack-protector-strong
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -W
-Wmissing-prototypes -Wmissing-declarations -Wpointer-arith
-Wchar-subscripts -Wformat=2 -Wbad-function-cast
-Wno-duplicate-decl-specifier -Wstrict-aliasing=2
-I/usr/local/include -Wl,--as-needed -o test-charset
test-charset.o  ./.libs/libcharset.a ../lib-test/.libs/libtest.a
../lib/.libs/liblib.a
./.libs/libcharset.a(charset-iconv.o): In function
`iconv_charset_to_utf8_begin':
/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:29:
undefined reference to `libiconv_open'
./.libs/libcharset.a(charset-iconv.o): In function
`iconv_charset_to_utf8_end':
/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:44:
undefined reference to `libiconv_close'
./.libs/libcharset.a(charset-iconv.o): In function
`iconv_charset_to_utf8_reset':
/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:51:
undefined reference to `libiconv'
./.libs/libcharset.a(charset-iconv.o): In function
`charset_to_utf8_try':
/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:74:
undefined reference to `libiconv'
cc: error: linker command failed with exit code 1 (use -v to see
invocation)
*** Error code 1

Stop.
make[3]: stopped in
/usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset
*** Error code 1

Stop.
make[2]: stopped in
/usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src
*** Error code 1

Stop.
make[1]: stopped in /usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1
*** Error code 1

Stop.
make: stopped in /usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1

root@waridi:/usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1
<mailto:root@waridi:/usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1>
# uname -mrs
*FreeBSD 11.1-STABLE amd64* 

-- 
Best regards,
Odhiambo WASHINGTON,
Nairobi,KE
+254 7 3200 0004/+254 7 2274 3223
"Oh, the cruft."
Can you try the attached patch?

Aki
I have applied the patch using -p1. It did not all apply cleanly.
Unless I missed something obvious. The failure is still there..
libtool: link: cc -std=gnu99 -g -O2 -fstack-protector-strong
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -W -Wmissing-prototypes
-Wmissing-declarations -Wpointer-arith -Wchar-subscripts -Wformat=2
-Wbad-function-cast -Wno-duplicate-decl-specifier -Wstrict-aliasing=2
-I/usr/local/include -Wl,--as-needed -o test-charset test-charset.o 
./.libs/libcharset.a ../lib-test/.libs/libtest.a ../lib/.libs/liblib.a
./.libs/libcharset.a(charset-iconv.o): In function
iconv_charset_to_utf8_begin': /home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:29: undefined reference to libiconv_open'
./.libs/libcharset.a(charset-iconv.o): In function
iconv_charset_to_utf8_end': /home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:44: undefined reference to libiconv_close'
./.libs/libcharset.a(charset-iconv.o): In function
iconv_charset_to_utf8_reset': /home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:51: undefined reference to libiconv'
./.libs/libcharset.a(charset-iconv.o): In function charset_to_utf8_try': /home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset/charset-iconv.c:74: undefined reference to libiconv'
cc: error: linker command failed with exit code 1 (use -v to see
invocation)
gmake[3]: *** [Makefile:540: test-charset] Error 1
gmake[3]: Leaving directory
'/usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src/lib-charset'
gmake[2]: *** [Makefile:550: all-recursive] Error 1
gmake[2]: Leaving directory
'/usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1/src'
gmake[1]: *** [Makefile:668: all-recursive] Error 1
gmake[1]: Leaving directory
'/usr/home/wash/Tools/Dovecot/2.3/dovecot-2.3.1'
gmake: *** [Makefile:511: all] Error 2
--
Best regards,
Odhiambo WASHINGTON,
Nairobi,KE
+254 7 3200 0004/+254 7 2274 3223
"Oh, the cruft."
Did you run ./autogen.sh after this?
Aki