Re: [Dovecot] UW-IMAP style mbox snarfing from /var/mail/ to ~/mbox

Timo Sirainen wrote:

...

Jun 4 15:28:27 bach dovecot: IMAP(kuhls): Timeout leak: 0x808ad10

Fixed and uploaded new version.

Hi,

thanks, the log message disappeared.

In your original posting you said:

if all the messages couldn't be copied, for example because of out of quota, then none of the messages are copied. I suppose that could be a problem. It might be possible to fix that by changing:

  if (mailbox_copy(dest_trans, mail, 0, NULL, NULL) < 0) {
  	if (!mail->expunged) {
  		ret = -1;
  		break;
  	}
  }

to just:

  if (mailbox_copy(dest_trans, mail, 0, NULL, NULL) < 0) {
  	if (!mail->expunged)
  		break;
  }

But I'm not sure about that. Try and tell me. :)

In your new patch you changed exactly this code, did you have a reason to do so? I have yet to test your patch in an over-quota scenario, so I can´t tell you my experience with the patch.

Greetings, Bernd Kuhls