grant beattie wrote:

On Thu, May 18, 2006 at 01:14:50PM +0200, Matthieu Herrb wrote:

...

The following patch is needed on Solaris, because <sys/stat.h> has a specific macro definition for struct stat. Without this patch the prototype for nfs_safe_stat() changes between the inclusion of nfs-workarounds.h and the definition of the function.

just curious, what version of Solaris? and what compiler/version?

Solaris 9 (sparc) with gcc 2.95:

gcc -DHAVE_CONFIG_H -I. -I. -I../.. -g -O2 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast -I/usr/local/include -c nfs-workarounds.c nfs-workarounds.c:84: conflicting types for nfs_safe_stat' nfs-workarounds.h:13: previous declaration of nfs_safe_stat' gnumake[3]: *** [nfs-workarounds.o] Error 1

And here is gcc -E output for nfs_safe_stat's implementation:

int nfs_safe_stat(const char *path, struct stat64 *buf) { return nfs_safe_do(path, nfs_safe_stat_callback, buf); }

-- Matthieu Herrb