[Dovecot] ioloop-select bug in alpha 4
Howdy, Forgive me if this issue has been more recently addressed in CVS, but a quick scan of the archives didn't turn up any other reports. There appears to be a small typo in src/lib/ioloop-select.c: --- dovecot-1.0.alpha4/src/lib/ioloop-select.c.orig 2005-11-06 22:06:53.000000000 -0800 +++ dovecot-1.0.alpha4/src/lib/ioloop-select.c 2005-11-06 22:07:13.000000000 -0 800 @@ -113,7 +113,7 @@ sizeof(fd_set)); memcpy(&tmp_write_fds, &ioloop->handler_context->write_fds, sizeof(fd_set)); - memcpy(&tmp_except_fds, &ioloop->handler_data->except_fds, + memcpy(&tmp_except_fds, &ioloop->handler_context->except_fds, sizeof(fd_set)); ret = select(ioloop->handler_context->highest_fd + 1, Thanks, Kevin
The bug/patch reported below by Kevin doesn't seem to have gotten fixed for alpha5... Recent mention of the need for a bug-tracking system seems reasonable...Any chance of getting this patch applied to cvs so it'll get into the next release? Thanks, Timo, for the great work on dovecot! James On Nov 6, 2005, at 10:19 PM, Kevin Van Vechten wrote:
Howdy,
Forgive me if this issue has been more recently addressed in CVS, but a quick scan of the archives didn't turn up any other reports.
There appears to be a small typo in src/lib/ioloop-select.c:
--- dovecot-1.0.alpha4/src/lib/ioloop-select.c.orig 2005-11-06 22:06:53.000000000 -0800 +++ dovecot-1.0.alpha4/src/lib/ioloop-select.c 2005-11-06 22:07:13.000000000 -0 800 @@ -113,7 +113,7 @@ sizeof(fd_set)); memcpy(&tmp_write_fds, &ioloop->handler_context->write_fds, sizeof(fd_set)); - memcpy(&tmp_except_fds, &ioloop->handler_data->except_fds, + memcpy(&tmp_except_fds, &ioloop->handler_context->except_fds, sizeof(fd_set)); ret = select(ioloop->handler_context->highest_fd + 1,
Thanks,
Kevin
On Mon, 2005-12-12 at 09:39 -0800, James Berry wrote:
Recent mention of the need for a bug-tracking system seems
reasonable...Any chance of getting this patch applied to cvs so it'll
get into the next release?
Committed to CVS now.
participants (3)
-
James Berry
-
Kevin Van Vechten
-
Timo Sirainen