[Dovecot] [PATCH] POP3: Fix RFC1939 non-compliance in STAT, LIST and UIDL commands
Hi all, attached is a patch against 0.99.10.4 that fixes the STAT, LIST and UIDL POP3 command output in the case that they're issued after one or more messages have been deleted.
Examples of incorrect behavior (bad spots marked with '***')
C: STAT
S: +OK 2 806
C: LIST
S: +OK 2 messages:
S: 1 403
S: 2 403
S: .
C: UIDL
S: +OK
S: 1 1076749908.12
S: 2 1076749908.13
S: .
C: DELE 1
S: +OK Marked to be deleted.
C: STAT
*** S: +OK 2 806
C: LIST
*** S: +OK 2 messages:
*** S: 1 403
S: 2 403
S: .
C: UIDL
S: +OK
*** S: 1 1076749908.12
S: 2 1076749908.13
S: .
What it should have been is:
[snip]
C: DELE 1
S: +OK Marked to be deleted.
C: STAT
S: +OK 1 403
C: LIST
S: +OK 1 messages:
S: 2 403
S: .
C: UIDL
S: +OK
S: 2 1076749908.13
S: .
It's unlikely the above issue has been causing much in the way of problems, as it's very rare for mail clients to use any of the faulty commands after they've deleted messages (they tend to do it once at the beginning of the POP3 session and cache the results).
Regards, Nic.
-- Nic Bellamy nic@bellamy.co.nz Bellamy Consulting -- Software & Security -- http://www.bellamy.co.nz/
Phone: +64-6-377-4957 Fax: +64-6-377-0505 Mobile: +64-21-251-8954
On Sat, 2004-02-14 at 12:38, Nic Bellamy wrote:
Hi all, attached is a patch against 0.99.10.4 that fixes the STAT, LIST and UIDL POP3 command output in the case that they're issued after one or more messages have been deleted.
Thanks, I'll apply it after I'm done with index file changes. Until then it can be also found in http://dovecot.org/patches/
participants (2)
-
Nic Bellamy
-
Timo Sirainen