Pigeonhole 0.4.20 source archive based on v. 0.4.20-rc1?
Hi,
looking at the source archive of pigeonhole 0.4.20 <https://pigeonhole.dovecot.org/releases/2.2/dovecot-2.2-pigeonhole-0.4.20.tar.gz> I noticed that the contained ChangeLog mentions v0.4.20.rc1 as first entry and pigeonhole-version.h defines git revision 7cd71ba as version where I'd expect 4a55e6c. This is probably no big deal. But since Makefile.in and install-sh also differ (see attached diff) from the patch contained in <http://xi.rename-it.nl/debian.new/pool/jessie-rc-auto/dovecot-2.2/dovecot_2.2.32-1~auto+1.debian.tar.xz> I thought I'd ask whether this is something without importance or something which should be changed.
-- Regards mks
Op 8/31/2017 om 1:25 PM schreef Markus Schönhaber:
Hi,
looking at the source archive of pigeonhole 0.4.20 <https://pigeonhole.dovecot.org/releases/2.2/dovecot-2.2-pigeonhole-0.4.20.tar.gz> I noticed that the contained ChangeLog mentions v0.4.20.rc1 as first entry and pigeonhole-version.h defines git revision 7cd71ba as version where I'd expect 4a55e6c.
I created the tarball before committing the change. I do that in most cases I think. The ChangeLog is created automatically. I see nothing quite wrong here, although you could argue I should commit before making the definitive release tarball.
Regards,
Stephan.
Stephan Bosch, Fri, 1 Sep 2017 22:12:56 +0200:
I created the tarball before committing the change. I do that in most cases I think. The ChangeLog is created automatically. I see nothing quite wrong here, although you could argue I should commit before making the definitive release tarball.
OK, I didn't expect there to be a real problem. But since my insight into the dovecot/pigeonhole source code is much too shallow for me to be sure, I thought I'd better ask. Thanks for your answer!
-- Regards mks
participants (2)
-
Markus Schönhaber
-
Stephan Bosch