On pop3 logout, we're seeing log lines where the deleted count is blank (using default pop3_logout_format), so "del=%d/%m" is displaying in the logs as:
"del=/1186"
for example.
In src/pop3/pop3-client.c:552:
tab[4].value = client->delete_success ?
dec2str(client->deleted_count) : 0;Shouldn't this be:
tab[4].value = client->delete_success ?
dec2str(client->deleted_count) : "0";(very minor bug)
-- Dave
On 16/09/2016 11:39, Dave wrote:
On pop3 logout, we're seeing log lines where the deleted count is blank (using default pop3_logout_format), so "del=%d/%m" is displaying in the logs as:
"del=/1186"
...
Shouldn't this be:
tab[4].value = client->delete_success ? dec2str(client->deleted_count) : "0";
Sorry, or even:
tab[4].value = dec2str(client->delete_success ?
client->deleted_count : 0);depending on cleanup?
-- Dave
-- Dave
On 16.09.2016 13:42, Dave wrote:
On 16/09/2016 11:39, Dave wrote:
On pop3 logout, we're seeing log lines where the deleted count is blank (using default pop3_logout_format), so "del=%d/%m" is displaying in the logs as:
"del=/1186"
...
Shouldn't this be:
tab[4].value = client->delete_success ? dec2str(client->deleted_count) : "0";Sorry, or even:
tab[4].value = dec2str(client->delete_success ? client->deleted_count : 0);depending on cleanup?
Hi!
This has been fixed in unreleased version. Sorry about this. See https://github.com/dovecot/core/commit/7424d35ff1b7d17c0caf7b426c0ef3c2b8229...
Aki Tuomi Dovecot oy
participants (2)
-
Aki Tuomi
-
Dave