[Dovecot] Dovecot-sieve vacation proposal, use address in addresses as recipient
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi Dovecot list,
In my setup I have several email addresses that uses same account. When I set a vacation the answer is not necessarily send from the destination address.
I propose to use the addresses found in addresses (if one match) as From address in vacation reply.
I've made a little patch who do that [1].
Best regards.
[1] http://polymorf.fr/files/nfrance/cmd-vacation.patch
David BERARD
contact(at)davidberard.fr GPG|PGP KeyId 0xC8533354 GPG|PGP Key http://davidberard.fr/C8533354.gpgkey
No electrons were harmed in *the transmission of this email *
-----BEGIN PGP SIGNATURE-----
iEYEARECAAYFAku+fUoACgkQOL7fhchTM1TJmACfdQcfgrSqNbjvWTEXrTc7Twly M70An2Nzb2MFby9ARHM1Ys93wGzuRYHy =yaLh -----END PGP SIGNATURE-----
On Fri, 2010-04-09 at 03:05 +0200, David Berard wrote:
I propose to use the addresses found in addresses (if one match) as From address in vacation reply.
I've made a little patch who do that [1].
Stephan will probably do something about this, but until then: Your patch uses memory in a way that could cause a buffer overflow and break things. This really isn't safe to do:
- sprintf(recipient, "%s", my_address);
I'm not sure if there's an easy way to fix it. Don't go writing to const pointers anyway. :) Probably should be something like:
_contains_my_address(.., const char **recipient_r) { .. *recipient_r = my_address; // instead of sprintf .. }
Timo Sirainen wrote:
On Fri, 2010-04-09 at 03:05 +0200, David Berard wrote:
I propose to use the addresses found in addresses (if one match) as From address in vacation reply.
I've made a little patch who do that [1].
Ok, I've implemented the desired functionality:
http://hg.rename-it.nl/dovecot-1.2-sieve/rev/1a9b3c3a4fdf http://hg.rename-it.nl/dovecot-2.0-pigeonhole/rev/cb4c3ce31192
Now I'm wondering.. should this be configurable/optional?
Regards,
Stephan.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Mon, 19 Apr 2010, Stephan Bosch wrote:
Now I'm wondering.. should this be configurable/optional?
Ideally I would suggest a vendor feature, which one has to require before use. But this would make problems using the feature from Webmail frontends, that does not allow to add custom Sieve code.
Regards,
Steffen Kaiser -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux)
iQEVAwUBS81lZr+Vh58GPL/cAQLb2Af/cwI67piwRVyGkz4UpUZIKaBYG3uk0Atk wEovBX9qpWKFxFqs1Xw1OMnBuQgiX5iJIa3cOYw+ldx7XNv3YSRVczd12dZWWS3L DiUaFrGeKsLsvl9V3OKXp2U3BhZVe7X5I/6+dqXItV5+ZtgToyLyEYC5sM7p7k+5 aPbKudg5Ojh52VKR8LgYBbhMM+35A1GCYQQVFe34eitKgdyhXKZbLjr/B9SAmxQ8 8lcN9boHIg8wYRYwn4etCJymw3vAKwVn44kv65bhjwuGezQHh01pAXSCgzwlSifL K91ol3WixY3XdZYyHwVWFCGi2aGNy8ZKENQMyJe+qJsGP5ydB+z6DA== =3Kq8 -----END PGP SIGNATURE-----
Steffen Kaiser wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Mon, 19 Apr 2010, Stephan Bosch wrote:
Now I'm wondering.. should this be configurable/optional?
Ideally I would suggest a vendor feature, which one has to require before use. But this would make problems using the feature from Webmail frontends, that does not allow to add custom Sieve code.
If users don't want this to happen, they should specify :from explicitly. I'm more interested in whether administrators would would want to disable this behavior throughout the system.
Regards,
Stephan.
participants (4)
-
David Berard
-
Steffen Kaiser
-
Stephan Bosch
-
Timo Sirainen