[Dovecot] [PATCH] settings parsing section/context return bug
There seems to be a minor bug in the settings parsing code (as of today's dovecot-stable snapshot - 20050731) - after the closing bracket of protocol (imap/pop3) {} section, the parser still regards all options as affecting only that protocol and not globally (I have some options, protocol imap {}, protocol pop3 {}, and then some more options - now those latter options seem to only affect POP3).
It seems to be solved by the attached patch. Merely that the sub-section level has to be decreased after checking that it is positive (for returning the protocol in context to ANY). Would that change (prefix to postfix decrement) break anything else? If not, can it be applied?
-- Tom
-- Tom Alsberg - hacker (being the best description fitting this space) Web page: http://www.cs.huji.ac.il/~alsbergt/ DISCLAIMER: The above message does not even necessarily represent what my fingers have typed on the keyboard, save anything further.
On Sun, 2005-07-31 at 16:35 +0300, Tom Alsberg wrote:
There seems to be a minor bug in the settings parsing code (as of today's dovecot-stable snapshot - 20050731) - after the closing bracket of protocol (imap/pop3) {} section, the parser still regards all options as affecting only that protocol and not globally (I have some options, protocol imap {}, protocol pop3 {}, and then some more options - now those latter options seem to only affect POP3).
It seems to be solved by the attached patch. Merely that the sub-section level has to be decreased after checking that it is positive (for returning the protocol in context to ANY). Would that change (prefix to postfix decrement) break anything else? If not, can it be applied?
Committed to CVS, thanks.
participants (2)
-
Timo Sirainen
-
Tom Alsberg