Re: [Dovecot] dovecot-antispam has some kind of bug
My dspam users has the email as username somthing@domain.com and in dovecot.conf i need to specify the user when training, is there a way to get the resiptient address in the dovecot.conf? i am only able to get %u ie the username ;-(
Could you patch the antispam plugin to be able to take then resiptient as dspam user? ie the mail address , you can have a option in dovecot that says use resiptient address as user or something
it would be great if you had time to check this out ;-)
TBH, I don't, and I also don't see why you'd need the recipient address, can't you just build it like %u@%d or %u@example.com or something?
johannes
The problem is that my %u is a user not the mail address and i train on the mail address from master.cf I modded your old script to support (for dovecot 1.0.x) it but when 1.1.x came it didnot work anymore
i have a diffrent username for auth then for resiveing mail so it impossible to train on that You could have a option called train on resiptient or something
i got the recipient address in the script then added this:
execl(DSPAM, "--source=error", "--stdout", "--user", recipient, class_arg, sign_arg, NULL);
Regards /J3nkl3r
Johannes Berg wrote:
My dspam users has the email as username somthing@domain.com and in dovecot.conf i need to specify the user when training, is there a way to get the resiptient address in the dovecot.conf? i am only able to get %u ie the username ;-(
Could you patch the antispam plugin to be able to take then resiptient as dspam user? ie the mail address , you can have a option in dovecot that says use resiptient address as user or something
it would be great if you had time to check this out ;-)
TBH, I don't, and I also don't see why you'd need the recipient address, can't you just build it like %u@%d or %u@example.com or something?
johannes
On Thu, 2008-08-21 at 16:15 +0200, Mikael Jenkler wrote:
The problem is that my %u is a user not the mail address and i train on the mail address from master.cf I modded your old script to support (for dovecot 1.0.x) it but when 1.1.x came it didnot work anymore
i have a diffrent username for auth then for resiveing mail so it impossible to train on that You could have a option called train on resiptient or something
i got the recipient address in the script then added this:
execl(DSPAM, "--source=error", "--stdout", "--user", recipient, class_arg, sign_arg, NULL);
So how did you get the recipient? What if the To: header isn't right? Did you use the envelope recipient? How did you get it?
I'd rather not open that can of worms. If you can send me a clean patch, I might integrate it, but I'm surely not going to work on it.
johannes
The problem is that i dont have it working for the new antispam but here is your old script with the recipient fixed This is 100% your code so you should be able to understand what i have done
You have changed 1000 things in your antispam plugin so it relly hard for me to patch it atleast take a look at it, if its possible to do the same thing with the new plugin, please
I think that more people then me would like this feature, if the to is
wrong then its wrong but it would be great if this feature existed
= me happy ;-)
Look att the attached lib_dspam.c /J3nkl3r
Johannes Berg wrote:
On Thu, 2008-08-21 at 16:15 +0200, Mikael Jenkler wrote:
The problem is that my %u is a user not the mail address and i train on the mail address from master.cf I modded your old script to support (for dovecot 1.0.x) it but when 1.1.x came it didnot work anymore
i have a diffrent username for auth then for resiveing mail so it impossible to train on that You could have a option called train on resiptient or something
i got the recipient address in the script then added this:
execl(DSPAM, "--source=error", "--stdout", "--user", recipient, class_arg, sign_arg, NULL);
So how did you get the recipient? What if the To: header isn't right? Did you use the envelope recipient? How did you get it?
I'd rather not open that can of worms. If you can send me a clean patch, I might integrate it, but I'm surely not going to work on it.
johannes
What do you think about the modified plugin, can it be done in the new version? what var contains the mail or header?
Regards /j3nkl3r
Mikael Jenkler wrote:
The problem is that i dont have it working for the new antispam but here is your old script with the recipient fixed This is 100% your code so you should be able to understand what i have done
You have changed 1000 things in your antispam plugin so it relly hard for me to patch it atleast take a look at it, if its possible to do the same thing with the new plugin, please
I think that more people then me would like this feature, if the to is wrong then its wrong but it would be great if this feature
existed = me happy ;-)Look att the attached lib_dspam.c /J3nkl3r
Johannes Berg wrote:
On Thu, 2008-08-21 at 16:15 +0200, Mikael Jenkler wrote:
The problem is that my %u is a user not the mail address and i train on the mail address from master.cf I modded your old script to support (for dovecot 1.0.x) it but when 1.1.x came it didnot work anymore
i have a diffrent username for auth then for resiveing mail so it impossible to train on that You could have a option called train on resiptient or something
i got the recipient address in the script then added this:
execl(DSPAM, "--source=error", "--stdout", "--user", recipient, class_arg, sign_arg, NULL);
So how did you get the recipient? What if the To: header isn't right? Did you use the envelope recipient? How did you get it?
I'd rather not open that can of worms. If you can send me a clean patch, I might integrate it, but I'm surely not going to work on it.
johannes
On Fri, 2008-08-22 at 11:21 +0200, Mikael Jenkler wrote:
What do you think about the modified plugin, can it be done in the new version? what var contains the mail or header?
I haven't even looked at it, since I don't know that old code any more. If you can send me a diff, then I can maybe take a look.
johannes
I dont have the old orginal code anymore :-( only have the modded one
I can try to patch it myself, can you tell me where in what variable you have the mail header or mail Is it reachable in dspam-exec.c
I relly want this to work :-)
Regards /Jenkler
Johannes Berg wrote:
On Fri, 2008-08-22 at 11:21 +0200, Mikael Jenkler wrote:
What do you think about the modified plugin, can it be done in the new version? what var contains the mail or header?
I haven't even looked at it, since I don't know that old code any more. If you can send me a diff, then I can maybe take a look.
johannes
On Fri, 2008-08-22 at 11:35 +0200, Mikael Jenkler wrote:
I dont have the old orginal code anymore :-( only have the modded one
I can try to patch it myself, can you tell me where in what variable you have the mail header or mail Is it reachable in dspam-exec.c
Just took a quick look, you seem to be using the "Delivered-To" header. That's not guaranteed to be present in any way.
I relly want this to work :-)
hack it into the current code, it's possible, or just use the mailtrain backend to mail it to the dspam learning process.
johannes
if it does not exist get_mail_headers returns null or something ?
is this not the best way? resiptient = get_mail_headers(mail, "Delivered-To");
is mail a global var ?
Regards /J3nkl3r
Johannes Berg wrote:
On Fri, 2008-08-22 at 11:35 +0200, Mikael Jenkler wrote:
I dont have the old orginal code anymore :-( only have the modded one
I can try to patch it myself, can you tell me where in what variable you have the mail header or mail Is it reachable in dspam-exec.c
Just took a quick look, you seem to be using the "Delivered-To" header. That's not guaranteed to be present in any way.
I relly want this to work :-)
hack it into the current code, it's possible, or just use the mailtrain backend to mail it to the dspam learning process.
johannes
On Fri, 2008-08-22 at 11:52 +0200, Mikael Jenkler wrote:
if it does not exist get_mail_headers returns null or something ?
is this not the best way? resiptient = get_mail_headers(mail, "Delivered-To");
is mail a global var ?
Sorry, I don't have time to play this game. You can learn about dovecot's internal API yourself, or ask others, but I will not implement anything like this for you. I've pointed out other solutions, and I most definitely think your dspam setup is broken if you require this.
johannes
participants (2)
-
Johannes Berg
-
Mikael Jenkler