[Dovecot] Kerberos check logic incorrect
In configure.in, there is a check that does krb5-config --version | grep -v 1\.2, making sure there is no "1.2" in the version of Kerberos
in use. This is to prevent compiling against MIT Kerberos version 1.2,
which is too old for Dovecot.
Unfortunately for this idea, Heimdal 1.2.1 is out. And Dovecot builds fine against it.
Whoever committed this check also appears to have removed the comment warning that it was broken, to add insult to injury.
Please fix your checks to be for FEATURES, not version numbers. You never know when something else that correctly implements the features you want will come along.
Bryan Jacobs
On Thu, 2008-07-17 at 21:36 -0400, Bryan Jacobs wrote:
In configure.in, there is a check that does
krb5-config --version | grep -v 1\.2, making sure there is no "1.2" in the version of Kerberos in use. This is to prevent compiling against MIT Kerberos version 1.2, which is too old for Dovecot.Unfortunately for this idea, Heimdal 1.2.1 is out. And Dovecot builds fine against it.
Whoever committed this check also appears to have removed the comment warning that it was broken, to add insult to injury.
Oh? I do see the comment.
Please fix your checks to be for FEATURES, not version numbers. You never know when something else that correctly implements the features you want will come along.
I usually do that, but for some reason this wasn't done with Kerberos. I tried to find out the original bug report but couldn't. So I just removed the v1.2 check completely now: http://hg.dovecot.org/dovecot-1.1/rev/ecad3f2402a9
participants (2)
-
Bryan Jacobs
-
Timo Sirainen