[Dovecot] Dovecot returns everything starting with "." as folder
Hi,
I'm using dovecot imapd 0.99.10.5 from debian unstable and I noticed that dovecot returns everything in the maildir folder that starts with a "." as a folder as the result of
LIST "" "%"
command without checking if it is really a maildir folder (must contain the directories cur, new, tmp and the file maildirfolder).
This is a little bit annoying because it also returns Sylpheed's cache files '.sylpheed_cache' and '.sylpheed_mark' if they exist in the maildir.
-- http://reboot.animeirc.de http://sylpheed-claws.sourceforge.net/
On Sat, 2004-05-29 at 20:49, Christoph Hohmann wrote:
I'm using dovecot imapd 0.99.10.5 from debian unstable and I noticed that dovecot returns everything in the maildir folder that starts with a "." as a folder as the result of
LIST "" "%"
command without checking if it is really a maildir folder (must contain the directories cur, new, tmp and the file maildirfolder).
It's a bit useless to check it in most situations and it would just cause extra disk I/O if system doesn't support struct dirent->d_type field.. But since this has been asked often enough..:
http://www.dovecot.org/patches/maildir-stat-dirs.patch
You'd probably want to run autogen.sh + configure again, or just #define HAVE_DIRENT_D_TYPE in config.h.
Timo Sirainen tss@iki.fi wrote:
I'm using dovecot imapd 0.99.10.5 from debian unstable and I noticed that dovecot returns everything in the maildir folder that starts with a "." as a folder as the result of
LIST "" "%"
command without checking if it is really a maildir folder
It's a bit useless to check it in most situations and it would just cause extra disk I/O if system doesn't support struct dirent->d_type field.. But since this has been asked often enough..:
How often do IMAP clients use the LIST commands, that this extra IO would cause significant slowdown?
You'd probably want to run autogen.sh + configure again, or just #define HAVE_DIRENT_D_TYPE in config.h.
I'm using the debian package.
-- http://reboot.animeirc.de http://sylpheed-claws.sourceforge.net/
On Sun, 30 May 2004, Christoph Hohmann wrote:
Timo Sirainen tss@iki.fi wrote:
I'm using dovecot imapd 0.99.10.5 from debian unstable and I noticed that dovecot returns everything in the maildir folder that starts with a "." as a folder as the result of
LIST "" "%"
command without checking if it is really a maildir folder
It's a bit useless to check it in most situations and it would just cause extra disk I/O if system doesn't support struct dirent->d_type field.. But since this has been asked often enough..:
How often do IMAP clients use the LIST commands, that this extra IO would cause significant slowdown?
You'd probably want to run autogen.sh + configure again, or just #define HAVE_DIRENT_D_TYPE in config.h.
I'm using the debian package.
# apt-get install fakeroot dpkg-dev # apt-get source dovecot # apt-get build-dep dovecot $ cd dovecot-0.99.10.5 $ chmod +x debian/rules
(add the patch per Timos instructions)
change the 1st line of debian/changelog so the version is 0.99.10.5-1.1
$ fakeroot debian/rules binary $ cd .. $ apt-get moo
While I can add the patch to the official package, we really need to get this version into sarge which will happen after 8 days. If I upload a new version, the timer gets reset and it will take 10 days from the time of upload.
Debian users: my question is, is adding the patch worth the delay in getting 0.99.10.5 into sarge?
-- Jaldhar H. Vyas jaldhar@debian.org La Salle Debain - http://www.braincells.com/debian/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Jaldhar H. Vyas wrote: | On Sun, 30 May 2004, Christoph Hohmann wrote:
|>I'm using the debian package. |> |> | | | # apt-get install fakeroot dpkg-dev | # apt-get source dovecot | # apt-get build-dep dovecot | $ cd dovecot-0.99.10.5 | $ chmod +x debian/rules | | (add the patch per Timos instructions) | | change the 1st line of debian/changelog so the version is 0.99.10.5-1.1 | | $ fakeroot debian/rules binary | $ cd .. | $ apt-get moo
Or this:
# apt-get install fakeroot devscripts # apt-get build-dep dovecot $ apt-get source dovecot $ cd dovecot-0.99.10.5
(add the patch per Timos instructions)
$ dch -v 0.99.10.5-1.0.private.1 $ debuild
The reason for using the devscripts commands debuild and dch should be obvious: less and simpler commands.
There are several reasons for the longer version number: ~ * If next official Debian package is an NMU (done an hour ago but waiting to be released, so older than yours) it is silently ignored ~ * you can later on scan dpkg for version numbers containing "private" to see how much local mess you have done ~ * You have room to make another rebuild
| Debian users: my question is, is adding the patch worth the delay in | getting 0.99.10.5 into sarge?
No (if you ask me - I can naturally only speak for myself).
~ - Jonas
Debian maintainer of UW-imap, and eagerly awaiting dovecot to take over the world!
- Jonas Smedegaard - idealist og Internet-arkitekt
- Tlf.: +45 40843136 Website: http://dr.jones.dk/
~ - Enden er nær: http://www.shibumi.org/eoti.htm -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFAuSD9n7DbMsAkQLgRAli5AKCFY8lmkTESBzrI1WyT4j1SivCCMQCfYm/Y 0uALhhKnGV/uJTkYCmNrVLo= =aciI -----END PGP SIGNATURE-----
Jaldhar wrote:
Debian users: my question is, is adding the patch worth the delay in getting 0.99.10.5 into sarge?
You know my answer, no. Dovecot needs to get back into sarge before hell, er, code freezes over, this is something for a 0.99.10.5-n release.
Regards,
Christian
Christian Balzer Network/Systems Engineer NOC chibi@gol.com Global OnLine Japan/Fusion Network Services http://www.gol.com/
On Sun, 2004-05-30 at 01:33, Christoph Hohmann wrote:
It's a bit useless to check it in most situations and it would just cause extra disk I/O if system doesn't support struct dirent->d_type field.. But since this has been asked often enough..:
How often do IMAP clients use the LIST commands, that this extra IO would cause significant slowdown?
It depends on client, many of them do it every time while checking for mails. It probably don't slow down noticeably for most people, but why do it if it's useful only for a few people?
Anyway, with that patch it is done by default if dirent->d_type exists and works. I'm not sure what operating systems do that, but I'd guess most of the new ones. Some filesystems might not support that though (NFS?).
participants (5)
-
Christian Balzer
-
Christoph Hohmann
-
Jaldhar H. Vyas
-
Jonas Smedegaard
-
Timo Sirainen