[Dovecot] MANAGESIEVE patch v7 for dovecot 1.0.3
Hello dovecot users,
I have updated the MANAGESIEVE patch to fix a recently reported problem. This is a patch against the latest stable release 1.0.3. It currently won't compile with 1.1 due to significant changes in the master code.
Change Log V7
- Robin Breathe indicated that the regex capability was missing in the server's SIEVE listing. It turns out I forgot to make arrangements for setting ENABLE_REGEX in the cmu libsieve sources, so the regex extension was not compiled in. I copied the configure.in section regarding ENABLE_REGEX from dovecot-sieve-1.0.2 and that fixed the problem.
This patch still includes (yet another) instance of the CMU Sieve source, as explained in one of my previous e-mails (http://dovecot.org/list/dovecot/2006-July/015016.html).
The patch can be downloaded at:
http://sinas.rename-it.nl/~sirius/dovecot-1.0.3-MANAGESIEVE-v7.diff.gz
The README.managesieve is located in the root of the dovecot source tree after applying the patch.
Have fun testing the patch. Don't hesitate to notify me when there are problems.
Regards,
-- Stephan Bosch stephan@rename-it.nl IRC: Freenode, #dovecot, S[r]us
On Sat, Aug 18, 2007 at 01:06:37AM +0200, Stephan Bosch wrote:
This patch still includes (yet another) instance of the CMU Sieve source, as explained in one of my previous e-mails.
On Fri, Jul 28, 2006 at 12:10:35AM +0200, Stephan Bosch wrote:
Considering the dovecot-sieve plugin, I noticed that you obviously do not want to include the cmu sieve code in the main dovecot source tree. Unfortunately I did not see any other way but to include this library in my patch to make it support checking the uploaded scripts (for now).
IIRC pysieved[1] simply invokes dovecot's sievec on the uploaded script and checks the return value, can't you do that as well?
GeertHello Geert,
On Sat, Aug 18, 2007 at 01:06:37AM +0200, Stephan Bosch wrote:
This patch still includes (yet another) instance of the CMU Sieve source, as explained in one of my previous e-mails.
On Fri, Jul 28, 2006 at 12:10:35AM +0200, Stephan Bosch wrote:
Considering the dovecot-sieve plugin, I noticed that you obviously do not want to include the cmu sieve code in the main dovecot source tree. Unfortunately I did not see any other way but to include this library in my patch to make it support checking the uploaded scripts (for now).
I could. In July 2006 I did not yet notice the existance of the sievec binary so included the cmu sieve library just as Timo did for the dovecot-sieve plugin. Apart from the obvious omission of the libsieve
Geert Hendrickx schreef: source tree in the patch, I currently see no benefits in changing the patch to use sievec. When/If it is merged into the mainstream dovecot or the dovecot-sieve plugin, it will use the same sieve implementation as dovecot without using the sievec binary anyway. So changing that now would require even more changes to be made later on when thnings need to be merged. Apart from all that, I think compiling it directly with the sieve library is much cleaner; for instance, the managesieve server can directly query the library for the supported extensions without hardcoding them separately in the managesieve patch.
Unless you or Timo have strong arguments to the opposite, I currently have no plans to change the current connection of sieve to the managesieve patch until dovecot(-sieve) 2.0.
Kind regards,
Stephan.
On Mon, Aug 27, 2007 at 05:43:08PM +0200, Stephan Bosch wrote:
Unless you or Timo have strong arguments to the opposite, I currently have no plans to change the current connection of sieve to the managesieve patch until dovecot(-sieve) 2.0.
Ok. I just thought you wanted to get rid of the extra copy of cmusieve in the sources, and I understood from your previous e-mails that (with dovecot's current plugin architecture) it was not obvious to merge the two copies.
Geert
participants (2)
-
Geert Hendrickx
-
Stephan Bosch