Hi, attached patch makes dovecot build on cygwin (only have a windows computer at the moment :-/ ) It spews a lot of warnings, for example "unsigned int format but uint32_t argument". johannes Only in dovecot-1.0-test58.mod/: Makefile Only in dovecot-1.0-test58.mod/: config.h Only in dovecot-1.0-test58.mod/: config.log Only in dovecot-1.0-test58.mod/: config.status Only in dovecot-1.0-test58.mod/doc: Makefile Only in dovecot-1.0-test58.mod/: libtool Only in dovecot-1.0-test58.mod/src: Makefile Only in dovecot-1.0-test58.mod/src/auth: .deps Only in dovecot-1.0-test58.mod/src/auth: Makefile Only in dovecot-1.0-test58.mod/src/imap: .deps Only in dovecot-1.0-test58.mod/src/imap: Makefile Only in dovecot-1.0-test58.mod/src/imap-login: .deps Only in dovecot-1.0-test58.mod/src/imap-login: Makefile Only in dovecot-1.0-test58.mod/src/lib: .deps Only in dovecot-1.0-test58.mod/src/lib: Makefile Only in dovecot-1.0-test58.mod/src/lib-auth: .deps Only in dovecot-1.0-test58.mod/src/lib-auth: Makefile Only in dovecot-1.0-test58.mod/src/lib-charset: .deps Only in dovecot-1.0-test58.mod/src/lib-charset: Makefile Only in dovecot-1.0-test58.mod/src/lib-imap: .deps Only in dovecot-1.0-test58.mod/src/lib-imap: Makefile Only in dovecot-1.0-test58.mod/src/lib-index: .deps Only in dovecot-1.0-test58.mod/src/lib-index: Makefile diff -ur --strip-trailing-cr dovecot-1.0-test58/src/lib-index/mail-cache-decisions.c dovecot-1.0-test58.mod/src/lib-index/mail-cache-decisions.c --- dovecot-1.0-test58/src/lib-index/mail-cache-decisions.c 2004-11-24 19:40:17.000000000 +0100 +++ dovecot-1.0-test58.mod/src/lib-index/mail-cache-decisions.c 2004-12-16 15:31:24.659497600 +0100 @@ -71,7 +71,7 @@ #include "mail-cache-private.h" void mail_cache_decision_lookup(struct mail_cache_view *view, uint32_t seq, - unsigned int field) + uint32_t field) { struct mail_cache *cache = view->cache; const struct mail_index_header *hdr; @@ -115,7 +115,7 @@ } void mail_cache_decision_add(struct mail_cache_view *view, uint32_t seq, - unsigned int field) + uint32_t field) { struct mail_cache *cache = view->cache; uint32_t uid; Only in dovecot-1.0-test58.mod/src/lib-mail: .deps Only in dovecot-1.0-test58.mod/src/lib-mail: Makefile Only in dovecot-1.0-test58.mod/src/lib-ntlm: .deps Only in dovecot-1.0-test58.mod/src/lib-ntlm: Makefile Only in dovecot-1.0-test58.mod/src/lib-settings: .deps Only in dovecot-1.0-test58.mod/src/lib-settings: Makefile Only in dovecot-1.0-test58.mod/src/lib-sql: .deps Only in dovecot-1.0-test58.mod/src/lib-sql: Makefile Only in dovecot-1.0-test58.mod/src/lib-storage: .deps Only in dovecot-1.0-test58.mod/src/lib-storage: Makefile Only in dovecot-1.0-test58.mod/src/lib-storage/index: .deps Only in dovecot-1.0-test58.mod/src/lib-storage/index: Makefile Only in dovecot-1.0-test58.mod/src/lib-storage/index/maildir: .deps Only in dovecot-1.0-test58.mod/src/lib-storage/index/maildir: Makefile Only in dovecot-1.0-test58.mod/src/lib-storage/index/mbox: .deps Only in dovecot-1.0-test58.mod/src/lib-storage/index/mbox: Makefile Only in dovecot-1.0-test58.mod/src/lib-storage/register: .deps Only in dovecot-1.0-test58.mod/src/lib-storage/register: Makefile Only in dovecot-1.0-test58.mod/src/lib-storage/register: mail-storage-register.c Only in dovecot-1.0-test58.mod/src/lib-storage/subscription-file: .deps Only in dovecot-1.0-test58.mod/src/lib-storage/subscription-file: Makefile Only in dovecot-1.0-test58.mod/src/login-common: .deps Only in dovecot-1.0-test58.mod/src/login-common: Makefile Only in dovecot-1.0-test58.mod/src/master: .deps Only in dovecot-1.0-test58.mod/src/master: Makefile Only in dovecot-1.0-test58.mod/src/pop3: .deps Only in dovecot-1.0-test58.mod/src/pop3: Makefile Only in dovecot-1.0-test58.mod/src/pop3-login: .deps Only in dovecot-1.0-test58.mod/src/pop3-login: Makefile Only in dovecot-1.0-test58.mod/src/util: .deps Only in dovecot-1.0-test58.mod/src/util: Makefile diff -ur --strip-trailing-cr dovecot-1.0-test58/src/util/dovecotpw.c dovecot-1.0-test58.mod/src/util/dovecotpw.c --- dovecot-1.0-test58/src/util/dovecotpw.c 2004-07-30 05:16:23.000000000 +0200 +++ dovecot-1.0-test58.mod/src/util/dovecotpw.c 2004-12-16 15:34:03.818356800 +0100 @@ -7,7 +7,6 @@ #include <ctype.h> #include <fcntl.h> -#include <libgen.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h> Only in dovecot-1.0-test58.mod/: stamp-h1 Only in dovecot-1.0-test58.mod/: stamp.h
On Thu, 2004-12-16 at 15:36 +0100, Johannes Berg wrote:
attached patch makes dovecot build on cygwin (only have a windows computer at the moment :-/ )
It spews a lot of warnings, for example "unsigned int format but uint32_t argument".
Well.. unsigned int and uint32_t are equilevant in most systems, and if int was changed into 64bit integer, it would still work.. Only in 16bit systems it would break but I don't even try to support them. Would be better if it didn't complain about those at all, casting them would be just annoying.
diff -ur --strip-trailing-cr dovecot-1.0-test58/src/lib-index/mail-cache-decisions.c dovecot-1.0-test58.mod/src/lib-index/mail-cache-decisions.c --- dovecot-1.0-test58/src/lib-index/mail-cache-decisions.c 2004-11-24 19:40:17.000000000 +0100 +++ dovecot-1.0-test58.mod/src/lib-index/mail-cache-decisions.c 2004-12-16 15:31:24.659497600 +0100 @@ -71,7 +71,7 @@ #include "mail-cache-private.h"
void mail_cache_decision_lookup(struct mail_cache_view *view, uint32_t seq, - unsigned int field) + uint32_t field) { struct mail_cache *cache = view->cache; const struct mail_index_header *hdr; @@ -115,7 +115,7 @@ }
void mail_cache_decision_add(struct mail_cache_view *view, uint32_t seq, - unsigned int field) + uint32_t field) { struct mail_cache *cache = view->cache; uint32_t uid;
Why these? They are called with unsigned int parameter and I can't really think of any other reasons why these should be changed. Doesn't it really compile without?
diff -ur --strip-trailing-cr dovecot-1.0-test58/src/util/dovecotpw.c dovecot-1.0-test58.mod/src/util/dovecotpw.c --- dovecot-1.0-test58/src/util/dovecotpw.c 2004-07-30 05:16:23.000000000 +0200 +++ dovecot-1.0-test58.mod/src/util/dovecotpw.c 2004-12-16 15:34:03.818356800 +0100 @@ -7,7 +7,6 @@
#include <ctype.h> #include <fcntl.h> -#include <libgen.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h>
I actually had changed configure to check for that header, but I had forgotten to add #ifdefs around it. Fixed.
On Sun, 2004-12-19 at 07:49 +0200, Timo Sirainen wrote:
Why these? They are called with unsigned int parameter and I can't really think of any other reasons why these should be changed. Doesn't it really compile without?
Oh, their prototypes in .h file were wrong. unsigned int was right one :)
participants (2)
-
Johannes Berg
-
Timo Sirainen