Re: [Dovecot] [PATCH] Generalize HMAC implementation
Am 11.09.2012 20:21, schrieb Timo Sirainen:
Here is an updated version of the patch. It uses the variant defining the largest allowed content size. I choose 1024 bit (128 Byte), since that is what most of the SHA-3 candidates use, so it's hopefully somewhat future proof.
It's also rebased to the current head and switches the hmac uses added since the last version over to the changed API. It also fixes an "interesting" compiler warning I got with clang, which complained about the fact that struct hmac_context* was (re)declared in the prototype of hmac_md5_get_cram_context() and therefore separate from the one declared in hmac.h.
Regards, Florian
Am 19.09.2012 19:43, schrieb Florian Zeitz:
Forget I said that. Unfortunately the MD5 context is already bigger (the SHA-1 one isn't). So 256 Byte it is I guess. Sorry for the lack of thorough testing. I hope I didn't miss another hash function.
participants (1)
-
Florian Zeitz