Re: Bug reports - auth is broken in Dovecot 2.3.3
I do not have downloaded the source from GitHub.
On Wed, Oct 3, 2018 at 1:53 PM Timo Sirainen tss@iki.fi wrote:
On 3 Oct 2018, at 13.22, Berindeie Avram-Teodor berindeie.teo@gmail.com wrote:
I applied the patch and recompiled but nothing resolved. What else can I do?
You also need to run autogen.sh & configure again.
On 3 Oct 2018, at 14.09, Berindeie Avram-Teodor berindeie.teo@gmail.com wrote:
I do not have downloaded the source from GitHub.
The patch modifies configure.ac, so unless you run autogen.sh the configure script isn't modified and that patch doesn't work. Or as an alternative you could simply manually append to config.h:
#define HAVE_CRYPT_H
On Wed, Oct 3, 2018 at 1:53 PM Timo Sirainen
mailto:tss@iki.fi> wrote: On 3 Oct 2018, at 13.22, Berindeie Avram-Teodor mailto:berindeie.teo@gmail.com> wrote: I applied the patch and recompiled but nothing resolved. What else can I do?
You also need to run autogen.sh & configure again.
Thank you. Now it is working!
On Wed, Oct 3, 2018 at 2:44 PM Timo Sirainen tss@iki.fi wrote:
On 3 Oct 2018, at 14.09, Berindeie Avram-Teodor berindeie.teo@gmail.com wrote:
I do not have downloaded the source from GitHub.
The patch modifies configure.ac, so unless you run autogen.sh the configure script isn't modified and that patch doesn't work. Or as an alternative you could simply manually append to config.h:
#define HAVE_CRYPT_H
On Wed, Oct 3, 2018 at 1:53 PM Timo Sirainen tss@iki.fi wrote:
On 3 Oct 2018, at 13.22, Berindeie Avram-Teodor berindeie.teo@gmail.com wrote:
I applied the patch and recompiled but nothing resolved. What else can I do?
You also need to run autogen.sh & configure again.
On Wed, Oct 03, 2018 at 03:47:11PM +0300, Berindeie Avram-Teodor berindeie.teo@gmail.com wrote:
On Wed, Oct 3, 2018 at 2:44 PM Timo Sirainen tss@iki.fi wrote:
On 3 Oct 2018, at 14.09, Berindeie Avram-Teodor berindeie.teo@gmail.com wrote:
On Wed, Oct 3, 2018 at 1:53 PM Timo Sirainen tss@iki.fi wrote:
On 3 Oct 2018, at 13.22, Berindeie Avram-Teodor berindeie.teo@gmail.com wrote:
This seems to be a lot of discussion about a rather simple patch. What was the reason for not including it in the 2.3.3 release, given that the patch date says it is from August? To me it seems like a really simple patch that shouldn't cause any problems so I would have expected it to be included into master right away, but maybe I'm wrong there and there is some hidden issue. If that's the case, please tell me since I'd like to understand the reasoning a bit better.
Florian
On 04 October 2018 at 11:05 Florian Pritz bluewind@xinu.at wrote:
On Wed, Oct 03, 2018 at 03:47:11PM +0300, Berindeie Avram-Teodor berindeie.teo@gmail.com wrote:
On Wed, Oct 3, 2018 at 2:44 PM Timo Sirainen tss@iki.fi wrote:
On 3 Oct 2018, at 14.09, Berindeie Avram-Teodor berindeie.teo@gmail.com wrote:
On Wed, Oct 3, 2018 at 1:53 PM Timo Sirainen tss@iki.fi wrote:
On 3 Oct 2018, at 13.22, Berindeie Avram-Teodor berindeie.teo@gmail.com wrote:
This seems to be a lot of discussion about a rather simple patch. What was the reason for not including it in the 2.3.3 release, given that the patch date says it is from August? To me it seems like a really simple patch that shouldn't cause any problems so I would have expected it to be included into master right away, but maybe I'm wrong there and there is some hidden issue. If that's the case, please tell me since I'd like to understand the reasoning a bit better.
Florian
The patch is already in master, but 2.3.3 is not released as 'HEAD' from master. The reason it's not in 2.3.3, is that we do not see it as super-urgent patch, since it affects glibc-2.2.28 mostly.
Aki
On Thu, Oct 04, 2018 at 11:40:05AM +0300, Aki Tuomi aki.tuomi@open-xchange.com wrote:
The patch is already in master, but 2.3.3 is not released as 'HEAD' from master. The reason it's not in 2.3.3, is that we do not see it as super-urgent patch, since it affects glibc-2.2.28 mostly.
Thanks!
Florian
participants (4)
-
Aki Tuomi
-
Berindeie Avram-Teodor
-
Florian Pritz
-
Timo Sirainen