[Dovecot] mailbox_storage_vfuncs: mailbox_open -> ? in 2.0
Hello,
I am working on fixing dovecot-antispam to work with dovecot 2.0. I am down to three errors/warnigns that concern me.
The one I need help from those more familiar with dovecot internals is in the subject. What happened to mailbox_open? Did it disappear? Did it get renamed?
It appears that I am needing to override some methods:
if (need_folder_hook) {
/* override save_init to override want_mail, we need that */
box->v.save_begin = antispam_save_begin;
box->v.save_finish = antispam_save_finish;
box->v.transaction_begin =
antispam_mailbox_transaction_begin; box->v.transaction_commit = antispam_mailbox_transaction_commit; box->v.transaction_rollback = antispam_mailbox_transaction_rollback; box->v.copy = antispam_copy; }
if (need_keyword_hook)
box->v.mail_alloc = antispam_mailbox_mail_alloc;
Thank you for any help.
Trever
A traveler on the information superhighway who often stops and looks around...
On Tue, 2010-07-13 at 13:41 -0600, Trever L. Adams wrote:
I am working on fixing dovecot-antispam to work with dovecot 2.0.
You're actually a bit late :) Eugene Paskevich eugene@raptor.kiev.ua has been working on it for a while now and apparently it's nearly done. We were just about to put the repo to hg.dovecot.org.
I am down to three errors/warnigns that concern me.
The one I need help from those more familiar with dovecot internals is in the subject. What happened to mailbox_open? Did it disappear? Did it get renamed?
With v1.x you could only open+close a mailbox. Now you can alloc, open/close multiple times, free.
On 07/13/2010 01:47 PM, Timo Sirainen wrote:
You're actually a bit late :) Eugene Paskevich eugene@raptor.kiev.ua has been working on it for a while now and apparently it's nearly done. We were just about to put the repo to hg.dovecot.org.
Well, that will save me from having to find a way to host a git tree. Thank you for letting me know. The last few hours have been fun and I have learned a little about dovecot's internals.
Thank you Eugene.
Will this become an included plugin in the dovecot distribution?
Eugene, would you be interested in some comments on fixing the build system so that it can be packaged in RPM easily (all plugin versions compiled)? Right now, I do the trick through RPM, but I think they can all be moved into the Makefile without too much trouble.
Thank you Eugene and Timo.
Trever
On Tue, 2010-07-13 at 14:05 -0600, Trever L. Adams wrote:
Will this become an included plugin in the dovecot distribution?
Problem 1) It's currently GPL so it would need a license change to LGPLv2.
Problem 2) I don't want to add support for n different antispam software inside Dovecot. I'd rather prefer the code to just be a generic "execute this program" and then have those different external programs/scripts for different antispams.
And if 2) is done, it would be even nicer if the whole plugin could be a more generic "execute program x when event y happens" type of plugin that didn't really even have anything to do with spam..
participants (2)
-
Timo Sirainen
-
Trever L. Adams