Hi
According to the docs, setting VOLATILEDIR will improve I/O performance when using NFS - but as far as I can see, only vsize lock-files are put here, and little else?
Is this correct, and if so are there any plans to move dotlocks etc. to this directory?
Thanks.
Tom
On 4 Oct 2018, at 14.39, Tom Sommer <mail@tomsommer.dk> wrote:
Hi
According to the docs, setting VOLATILEDIR will improve I/O performance when using NFS - but as far as I can see, only vsize lock-files are put here, and little else?
Right. I think also autoexpunge locking.
Is this correct, and if so are there any plans to move dotlocks etc. to this directory?
What dotlocks? I guess mbox and Maildir have some locks that could be moved there, but a better performance optimization for those installations would be to switch to sdbox/mdbox. Other than that, I don't remember there being anything important that could be moved there.
On 2018-10-04 15:55, Timo Sirainen wrote:
On 4 Oct 2018, at 14.39, Tom Sommer <mail@tomsommer.dk> wrote:
Is this correct, and if so are there any plans to move dotlocks etc. to this directory?
What dotlocks? I guess mbox and Maildir have some locks that could be moved there, but a better performance optimization for those installations would be to switch to sdbox/mdbox. Other than that, I don't remember there being anything important that could be moved there.
Maildir locks yes, switching format is not a procedure I feel comfortable with :)
Would it be possible to move the maildir/mbox locks to VOLATILEDIR?
-- Tom Sommer
On 4 Oct 2018, at 17.13, Tom Sommer <mail@tomsommer.dk> wrote:
On 2018-10-04 15:55, Timo Sirainen wrote:
On 4 Oct 2018, at 14.39, Tom Sommer <mail@tomsommer.dk> wrote:
Is this correct, and if so are there any plans to move dotlocks etc. to this directory? What dotlocks? I guess mbox and Maildir have some locks that could be moved there, but a better performance optimization for those installations would be to switch to sdbox/mdbox. Other than that, I don't remember there being anything important that could be moved there.
Maildir locks yes, switching format is not a procedure I feel comfortable with :)
Would it be possible to move the maildir/mbox locks to VOLATILEDIR?
Sure it would be possible, but it's such a low priority for us that I doubt we'll be implementing it.
On 2018-10-05 11:35, Timo Sirainen wrote:
On 4 Oct 2018, at 17.13, Tom Sommer <mail@tomsommer.dk> wrote:
On 2018-10-04 15:55, Timo Sirainen wrote:
On 4 Oct 2018, at 14.39, Tom Sommer <mail@tomsommer.dk> wrote:
Is this correct, and if so are there any plans to move dotlocks etc. to this directory? What dotlocks? I guess mbox and Maildir have some locks that could be moved there, but a better performance optimization for those installations would be to switch to sdbox/mdbox. Other than that, I don't remember there being anything important that could be moved there.
Maildir locks yes, switching format is not a procedure I feel comfortable with :)
Would it be possible to move the maildir/mbox locks to VOLATILEDIR?
Sure it would be possible, but it's such a low priority for us that I doubt we'll be implementing it.
Hrmm okay, fair enough. Seems like a small task though.
Might try and look into it myself.
On 2018-10-05 11:50, Tom Sommer wrote:
On 2018-10-05 11:35, Timo Sirainen wrote:
On 4 Oct 2018, at 17.13, Tom Sommer <mail@tomsommer.dk> wrote:
On 2018-10-04 15:55, Timo Sirainen wrote:
On 4 Oct 2018, at 14.39, Tom Sommer <mail@tomsommer.dk> wrote:
Is this correct, and if so are there any plans to move dotlocks etc. to this directory? What dotlocks? I guess mbox and Maildir have some locks that could be moved there, but a better performance optimization for those installations would be to switch to sdbox/mdbox. Other than that, I don't remember there being anything important that could be moved there.
Maildir locks yes, switching format is not a procedure I feel comfortable with :)
Would it be possible to move the maildir/mbox locks to VOLATILEDIR?
Sure it would be possible, but it's such a low priority for us that I doubt we'll be implementing it.
Might try and look into it myself.
Something like this? See attached.
On 5 Oct 2018, at 16.42, Tom Sommer <mail@tomsommer.dk <mailto:mail@tomsommer.dk>> wrote:
On 2018-10-05 11:50, Tom Sommer wrote:
On 2018-10-05 11:35, Timo Sirainen wrote:
On 4 Oct 2018, at 17.13, Tom Sommer <mail@tomsommer.dk <mailto:mail@tomsommer.dk>> wrote:
On 2018-10-04 15:55, Timo Sirainen wrote:
Is this correct, and if so are there any plans to move dotlocks etc. to this directory? What dotlocks? I guess mbox and Maildir have some locks that could be moved there, but a better performance optimization for those installations would be to switch to sdbox/mdbox. Other than that, I don't remember there being anything important that could be moved
On 4 Oct 2018, at 14.39, Tom Sommer <mail@tomsommer.dk <mailto:mail@tomsommer.dk>> wrote: there. Maildir locks yes, switching format is not a procedure I feel comfortable with :) Would it be possible to move the maildir/mbox locks to VOLATILEDIR? Sure it would be possible, but it's such a low priority for us that I doubt we'll be implementing it. Might try and look into it myself.
Something like this? See attached.<volatile-dotlock.patch>
Looks like it works. But could you:
Add it to github as merge request
MAILBOX_LIST_PATH_TYPE_VOLATILEDIR might be useful, but it's kind of a separate change of its own. To simplify, in Maildir code you could have box->list->set->volatile_dir != NULL ? box->list->set->volatile_dir : control_dir. That way it's falling back to control_dir like the previous code when VOLATILEDIR wasn't set.
On 2018-10-05 21:56, Timo Sirainen wrote:
Looks like it works. But could you:
- Add it to github as merge request
Done, for the first part of the code.
- MAILBOX_LIST_PATH_TYPE_VOLATILEDIR might be useful, but it's kind of a separate change of its own. To simplify, in Maildir code you could have box->list->set->volatile_dir != NULL ? box->list->set->volatile_dir : control_dir. That way it's falling back to control_dir like the previous code when VOLATILEDIR wasn't set.
I just copied the code from above: if (mailbox_get_path_to(box, MAILBOX_LIST_PATH_TYPE_CONTROL, &control_dir) <= 0)
If I do as you suggest, I get this?:
maildir-uidlist.c:277:47: error: dereferencing pointer to incomplete type uidlist->path_dotlock = i_strconcat(box->list->set->volatile_dir != NULL ? box->list->set->volatile_dir : control_dir, "/"MAILDIR_UIDLIST_NAME, NULL);
That's the reason I expanded mailbox_get_path_to(), since that angle worked
Thanks for the feedback :)
-- Tom
participants (2)
-
Timo Sirainen
-
Tom Sommer