The compiler returns many warnings, and the test returns two IPv6-related errors. I am attaching both logs as reference.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Thursday, January 3, 2019 9:53 AM, Aki Tuomi aki.tuomi@open-xchange.com wrote:
We compile all core code with both gcc and clang. What sort of interesting things did you find?
Aki
On 03 January 2019 at 11:50 Rupert Gallagher via dovecot < dovecot@dovecot.org> wrote:
Please, use clang instead of gcc. Code quality can only profit from it. I just compiled 2.3.4 and compiler stderr is full of interesting problems.
Aki Tuomi
The arithmetic stuff has already been fixed in master with
https://github.com/dovecot/core/commit /5cccb4af850bb3ba81e73a8fb4f6881c3e1d4046.patch https://github.com/dovecot/core/commit /ac7aa955db4c77bbb169baa5d104a4c128674646.patch
I have not seen the second error ever, it would need more information, can you gdb to it and see what the actual value is?
Aki
On 03 January 2019 at 13:38 Rupert Gallagher via dovecot dovecot@dovecot.org wrote:
The compiler returns many warnings, and the test returns two IPv6-related errors. I am attaching both logs as reference.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Thursday, January 3, 2019 9:53 AM, Aki Tuomi aki.tuomi@open-xchange.com wrote:
We compile all core code with both gcc and clang. What sort of interesting things did you find?
Aki
On 03 January 2019 at 11:50 Rupert Gallagher via dovecot < dovecot@dovecot.org> wrote:
Please, use clang instead of gcc. Code quality can only profit from it. I just compiled 2.3.4 and compiler stderr is full of interesting problems.
Aki Tuomi
Same problem with 2.3.4.
configure lacks debug flags.
No joy with gdb breakpoint in mallock_error_break on make test.
On Thu, Jan 3, 2019 at 13:58, Aki Tuomi aki.tuomi@open-xchange.com wrote:
The arithmetic stuff has already been fixed in master with
https://github.com/dovecot/core/commit /5cccb4af850bb3ba81e73a8fb4f6881c3e1d4046.patch https://github.com/dovecot/core/commit /ac7aa955db4c77bbb169baa5d104a4c128674646.patch
I have not seen the second error ever, it would need more information, can you gdb to it and see what the actual value is?
Aki
On 03 January 2019 at 13:38 Rupert Gallagher via dovecot dovecot@dovecot.org wrote:
The compiler returns many warnings, and the test returns two IPv6-related errors. I am attaching both logs as reference.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Thursday, January 3, 2019 9:53 AM, Aki Tuomi aki.tuomi@open-xchange.com wrote:
We compile all core code with both gcc and clang. What sort of interesting things did you find?
Aki
On 03 January 2019 at 11:50 Rupert Gallagher via dovecot < dovecot@dovecot.org> wrote:
Please, use clang instead of gcc. Code quality can only profit from it. I just compiled 2.3.4 and compiler stderr is full of interesting problems.
Aki Tuomi
The unit test problems aren't clang issues, they're OSX issues. So:
test-net.c:79: Assert failed: strcmp(net_ip2addr(&ip), "::5") == 0 test-net.c:83: Assert failed: strcmp(net_ip2addr(&ip), "::5") == 0
This is because OSX writes the address out as "::0.0.0.5" instead of "::5". I don't remember if the core code should be fixed or if it's just the unit test that needs fixing.
test-lib(26058,0x7fff95cf7380) malloc: *** mach_vm_map(size=9223372036854775808) failed (error code=3) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug fatal_mempool_alloconly .............................................. : ok test-lib(26058,0x7fff95cf7380) malloc: *** mach_vm_map(size=9223372036854775808) failed (error code=3) *** error: can't allocate region *** set a breakpoint in malloc_error_break to debug fatal_mempool_allocfree .............................................. : ok
I'm pretty sure these are intentional. The unit tests are succeeding, and the unit tests are there to test failing memory allocations. OSX just wants to also write some extra errors to stderr.
On 3 Jan 2019, at 13.38, Rupert Gallagher via dovecot dovecot@dovecot.org wrote:
The compiler returns many warnings, and the test returns two IPv6-related errors. I am attaching both logs as reference.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Thursday, January 3, 2019 9:53 AM, Aki Tuomi aki.tuomi@open-xchange.com wrote:
We compile all core code with both gcc and clang. What sort of interesting things did you find?
Aki
On 03 January 2019 at 11:50 Rupert Gallagher via dovecot < dovecot@dovecot.org mailto:dovecot@dovecot.org> wrote:
Please, use clang instead of gcc. Code quality can only profit from it. I just compiled 2.3.4 and compiler stderr is full of interesting problems.
Aki Tuomi
participants (3)
-
Aki Tuomi
-
Rupert Gallagher
-
Timo Sirainen