[Dovecot] Pigeonhole make check fails with Dovecot 2.2.8
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Is it just here?
When compiling dovecot-2.2-pigeonhole-0.4.2 at the stage "make check" Pigeonhole is throwing the following message and stops:
Test case: ./tests/test-header.svtest:
1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header' SUCCEEDED
I have tried to compile Pigeonhole 0.4.2 and also the latest dovecot-2-2-pigeonhole-b7434a02fc51 from the Mercurial repository but the outcome at "make test" is always the same:
3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace
Cheers, Tamsy
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32)
iQEcBAEBAgAGBQJSjC2QAAoJEKYXVM1dyOfZ9xsIAKDC7goLP3N2rr90Lf0P6gam wQFmYY3HUMIKi3FKWcCy6DQBN6Qr33QWTk/b4OY1LDMOETolZTWIEwvlix+YdI8x oRdKQXWHR9k+jd9etWkNuuk2xUnbjz353IOMZ3Yc+spuv0JyUvYhef6pfq3MLTYQ R+YW4aoNp3XstAKcknnkduNwrfRXoZoFT/YOU3VQyDUwUa6u07JhuL+onZtb0mO+ HsdD4NNY28YqHY1/eoT3YNRbgtRxyOfzxh3f17ITbquM0ZgiPJucWX7HpIiwNJFu 3gqkceDLqqAL9DKUjDapSyR2IjxJlRSGcxQckxlkGXzcaTNNWqAn7mMxSr3hEaY= =EY7D -----END PGP SIGNATURE-----
On 11/20/2013 11:33 AM, Tamsy wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Is it just here?
You mean is it just you alone or ? If you really mean just you only... no you are not alone...
When compiling dovecot-2.2-pigeonhole-0.4.2 at the stage "make check" Pigeonhole is throwing the following message and stops:
Test case: ./tests/test-header.svtest:
1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header' SUCCEEDED
I have tried to compile Pigeonhole 0.4.2 and also the latest dovecot-2-2-pigeonhole-b7434a02fc51 from the Mercurial repository but the outcome at "make test" is always the same:
3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace
Same thing happened to me as well...
Test case: ./tests/test-header.svtest: 1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header' SUCCEEDED FAIL: 1 of 6 tests failed. make: *** [tests/test-header.svtest] Error 1
Thanks.
Kindest regards, Giam Teck Choon
Cheers, Tamsy
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32)
iQEcBAEBAgAGBQJSjC2QAAoJEKYXVM1dyOfZ9xsIAKDC7goLP3N2rr90Lf0P6gam wQFmYY3HUMIKi3FKWcCy6DQBN6Qr33QWTk/b4OY1LDMOETolZTWIEwvlix+YdI8x oRdKQXWHR9k+jd9etWkNuuk2xUnbjz353IOMZ3Yc+spuv0JyUvYhef6pfq3MLTYQ R+YW4aoNp3XstAKcknnkduNwrfRXoZoFT/YOU3VQyDUwUa6u07JhuL+onZtb0mO+ HsdD4NNY28YqHY1/eoT3YNRbgtRxyOfzxh3f17ITbquM0ZgiPJucWX7HpIiwNJFu 3gqkceDLqqAL9DKUjDapSyR2IjxJlRSGcxQckxlkGXzcaTNNWqAn7mMxSr3hEaY= =EY7D -----END PGP SIGNATURE-----
Le 20 nov. 2013 à 04:33, Tamsy a écrit :
[...]
I have tried to compile Pigeonhole 0.4.2 and also the latest dovecot-2-2-pigeonhole-b7434a02fc51 from the Mercurial repository but the outcome at "make test" is always the same:
3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace
Hello Tamsy,
No such failure here, with a standard compilation of 2.2.7/0.4.2 on Mac OS X 10.8.5. Could this be OS-related, related to some libraries? During the compilation, were warnings that could provide some hints emitted?
Axel
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Axel Luttgens wrote the following on 20.11.2013 15:16:
Le 20 nov. 2013 à 04:33, Tamsy a écrit :
[...]
I have tried to compile Pigeonhole 0.4.2 and also the latest dovecot-2-2-pigeonhole-b7434a02fc51 from the Mercurial repository but the outcome at "make test" is always the same:
3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace
Hello Tamsy,
No such failure here, with a standard compilation of 2.2.7/0.4.2 on Mac OS X 10.8.5. Could this be OS-related, related to some libraries? During the compilation, were warnings that could provide some hints emitted?
Axel
Hi Axel,
Thank you for the info.
Our servers are running on Ubuntu 10.04, 32bit. With Dovecot/Pigeonhole 2.2.7/0.4.2 that error when running "make check" for Pigeonhole does not happen on any of our servers. It seems to be the combo Dovecot/Pigeonhole 2.2.8/0.4.2 (and also with Mercurial b7434a02fc51). Probably some incompatibilities. Maybe Stephan can take a look at this? "Configure" and "make" for Pigeonhole is going without any errors but "make check" just stops after the following without any further message:
Test case: ./tests/test-header.svtest: 1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header' SUCCEEDED FAIL: 1 of 6 tests failed. make: *** [tests/test-header.svtest] Error 1
"header test does not strip leading whitespace" is the only clue.
Cheers, Tamsy
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32)
iQEcBAEBAgAGBQJSjHLYAAoJEKYXVM1dyOfZJMEH/0L42e9kcW380BSoDblvUjMJ 4xWzbYbRikliKqF8+8QOvmcHZF5wgmsxhdNtPdvMlLnS6YDhLGcJbPf4BeY3/IIi pTehQ8h+v4qBB2lJvJfdFAZ1ZEQ6QLK11nCxg5X+u50tAOoflZbWZUdmhu7zDJ8W Kw5Ta6l2etMjEbXwKEK3w+aQh/jAd89fcPlCbOcfHsq85Y3hTT5Wtn8itCFYUOkh aVSr40R5wV93T3GpwvNxaOk5FLeSRcx/1sqzWjVrUTSTJhLLMG9RQEYDCxwpecRx af94Uw5ir5qBym4lqK48arLhH8xv4FF+2Z9Yj8tiC0YKKcTr3OowdaWKbgVd544= =Vkol -----END PGP SIGNATURE-----
Le 20 nov. 2013 à 09:29, Tamsy a écrit :
[...]
Our servers are running on Ubuntu 10.04, 32bit. With Dovecot/Pigeonhole 2.2.7/0.4.2 that error when running "make check" for Pigeonhole does not happen on any of our servers. It seems to be the combo Dovecot/Pigeonhole 2.2.8/0.4.2 (and also with Mercurial b7434a02fc51). Probably some incompatibilities. Maybe Stephan can take a look at this? "Configure" and "make" for Pigeonhole is going without any errors but "make check" just stops after the following without any further message:
Test case: ./tests/test-header.svtest: 1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header' SUCCEEDED FAIL: 1 of 6 tests failed. make: *** [tests/test-header.svtest] Error 1
"header test does not strip leading whitespace" is the only clue.
OK, just downloaded and tried with 2.2.8. And yes, that 2.2.8/0.4.2 combo fails the same way here too...
Axel
On 20.11.2013, at 5.33, Tamsy dovecot-list@mohtex.net wrote:
When compiling dovecot-2.2-pigeonhole-0.4.2 at the stage "make check" Pigeonhole is throwing the following message and stops:
Test case: ./tests/test-header.svtest:
1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header’ SUCCEEDED
Interestingly caused by the improved caching code. Fixed by http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2
On 20.11.2013, at 14.40, Timo Sirainen tss@iki.fi wrote:
On 20.11.2013, at 5.33, Tamsy dovecot-list@mohtex.net wrote:
When compiling dovecot-2.2-pigeonhole-0.4.2 at the stage "make check" Pigeonhole is throwing the following message and stops:
Test case: ./tests/test-header.svtest:
1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header’ SUCCEEDED
Interestingly caused by the improved caching code. Fixed by http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2
And http://hg.dovecot.org/dovecot-2.2/rev/4ef184875799 http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56
These are very old bugs. Wonder if they’ve caused other trouble earlier.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Timo Sirainen wrote the following on 20.11.2013 20:08:
On 20.11.2013, at 14.40, Timo Sirainen tss@iki.fi wrote:
On 20.11.2013, at 5.33, Tamsy dovecot-list@mohtex.net wrote:
When compiling dovecot-2.2-pigeonhole-0.4.2 at the stage "make check" Pigeonhole is throwing the following message and stops:
Test case: ./tests/test-header.svtest:
1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header’ SUCCEEDED Interestingly caused by the improved caching code. Fixed by http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2 And http://hg.dovecot.org/dovecot-2.2/rev/4ef184875799 http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56
These are very old bugs. Wonder if they’ve caused other trouble earlier.
Hi Timo,
After applying your patches to Dovecot 2.2.8:
- http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2
- http://hg.dovecot.org/dovecot-2.2/rev/4ef184875799
- http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56
I can confirm that "make check" using latest dovecot-2-2-pigeonhole-b7434a02fc51 from the Mercurial repository is finishing without error now, all tests are succeeding.
In particular "Test case: ./tests/test-header.svtest":
1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' SUCCEEDED 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header' SUCCEEDED
PASS: 6 tests succeeded.
Thank you, Tamsy -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32)
iQEcBAEBAgAGBQJSjLzMAAoJEKYXVM1dyOfZzvwH/1Xl5ysdOFQel5jWMeCDtuZP a/nli5L0mZe2l16MVdUJ8lDn7tpQv13WkZV81vYTIayu/b+MTGa1OZVoQakgWUUx dF26Jc0E5/pVOM0jlJgagGjwhFjjAUGkOeKEfIi6ScGekTuvunlBfkJ+rbouAise HCRHnPgvIv+o+S8hDNTOyKz2S8/2cR/Yip8j2k6UYn9DUCR1Phs7ypugkcXhBIHG ee4vHyY0tFCprps9tN12xr+qOn7R/wTHTqw9JZZNyXVrxt3ZLOH7IApeaWeMNFDz FmwKjrDiXHK0HVJVVfjvvSZqDX5+BMFe4kDiKVqEdewex1b+tVXTCD5wSlU3pTk= =srRX -----END PGP SIGNATURE-----
On 11/20/2013 09:44 PM, Tamsy wrote:
Timo Sirainen wrote the following on 20.11.2013 20:08:
On 20.11.2013, at 14.40, Timo Sirainen tss@iki.fi wrote:
On 20.11.2013, at 5.33, Tamsy dovecot-list@mohtex.net wrote:
When compiling dovecot-2.2-pigeonhole-0.4.2 at the stage "make check" Pigeonhole is throwing the following message and stops:
Test case: ./tests/test-header.svtest:
1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' FAILED: header test does not strip leading whitespace 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header’ SUCCEEDED Interestingly caused by the improved caching code. Fixed by http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2 And http://hg.dovecot.org/dovecot-2.2/rev/4ef184875799 http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56
These are very old bugs. Wonder if they’ve caused other trouble earlier.
Hi Timo,
After applying your patches to Dovecot 2.2.8: 1. http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2 2. http://hg.dovecot.org/dovecot-2.2/rev/4ef184875799 3. http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56
Same here but I also include http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56 as well.
Thanks!
Kindest regards, Giam Teck Choon
I can confirm that "make check" using latest dovecot-2-2-pigeonhole-b7434a02fc51 from the Mercurial repository is finishing without error now, all tests are succeeding.
In particular "Test case: ./tests/test-header.svtest":
1: Test 'Basic functionality' SUCCEEDED 2: Test 'Matching empty key' SUCCEEDED 3: Test 'Ignoring whitespace' SUCCEEDED 4: Test 'Absent or empty header' SUCCEEDED 5: Test 'Invalid header name' SUCCEEDED 6: Test 'Folded header' SUCCEEDED
PASS: 6 tests succeeded.
Thank you, Tamsy
Le 20 nov. 2013 à 16:20, Giam Teck Choon a écrit :
[...]
Same here but I also include http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56 as well.
Hello Giam,
Just for the sake of the archives consistency... I guess you meant:
http://hg.dovecot.org/dovecot-2.2/rev/a91437fe94b6so that the patches you have applied are:
http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2
http://hg.dovecot.org/dovecot-2.2/rev/a91437fe94b6
http://hg.dovecot.org/dovecot-2.2/rev/4ef184875799
http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56Or?
Axel
On 11/21/2013 06:29 AM, Axel Luttgens wrote:
Le 20 nov. 2013 à 16:20, Giam Teck Choon a écrit :
[...]
Same here but I also include http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56 as well.
Hello Giam,
Just for the sake of the archives consistency... I guess you meant:
http://hg.dovecot.org/dovecot-2.2/rev/a91437fe94b6
so that the patches you have applied are:
http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2 http://hg.dovecot.org/dovecot-2.2/rev/a91437fe94b6 http://hg.dovecot.org/dovecot-2.2/rev/4ef184875799 http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56
Yes, the latest 4 commits... sorry if I am not clear ;)
Thanks.
Kindest regards, Giam Teck Choon
Or?
Axel
Le 20 nov. 2013 à 14:08, Timo Sirainen a écrit :
[...] Interestingly caused by the improved caching code. Fixed by http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2
And http://hg.dovecot.org/dovecot-2.2/rev/4ef184875799 http://hg.dovecot.org/dovecot-2.2/rev/47923cfd4b56
These are very old bugs. Wonder if they’ve caused other trouble earlier.
Hello Timo,
Following Tamsy and Giam: above patches (probably the first one alone, but the other ones should be like chicken soup - you know, the one that doesn't hurt) indeed avoid that "make check" failure with PigeonHole here too.
Once again, many thanks, Axel
On Wed, Nov 20, 2013 at 02:40:22PM +0200, Timo Sirainen wrote:
When compiling dovecot-2.2-pigeonhole-0.4.2 at the stage "make check" Pigeonhole is throwing the following message and stops:
Interestingly caused by the improved caching code. Fixed by http://hg.dovecot.org/dovecot-2.2/rev/f4eb4b5884b2
Hi all,
no make it more difficult I have this story:
I run a autoresponder at echo@signing-milter.org. Messages to this address are answered by sieve vacation. Messages generated by sieve are sent via smtp
# doveconf submission_host submission_host = signing-milter.org:587
There my signing-milter take the plain message and apply an s/mime signature. That worked for years until I upgrades the host (spring 2013). Starting that time the signatures are invalid. I focused my bug search on /my software/ and the new openssl version (0.9.8 -> 1.0.1e)
Looks like that was wrong. Yesterday I installed stock dovecot-2.2.8 and dovecot-2.2-pigeonhole-0.4.2. The signatures are valid again!
But then I found, I build dovecot + pigeonhole without "make check". I did not noticed any "make check" failures till yesterday. I applied all 5 patches mentioned in http://dovecot.org/list/dovecot/2013-November/093654.html and build dovecot + pigeonhole again. Now also "make check" did not fail.
But the s/mime signatures are invalid again :-(
Conclusion: the patch dial with whitespaces. Signatures are very sensitive indiators for any change in a message. I could imagine, that the messages generated by sieve vacation are unexpected/invalid at some whitespaces. This invalid whitespace may be s/mime signed but modified a moment later by postfix? On the other side I apply also dkim signatures just after the s/mime signature was generated. These dkim signatures are valid all the time.
Unfortunately I have no idea if that help neither how to debug this...
Andreas
-- Andreas Schulze Internetdienste | P252
DATEV eG 90329 Nürnberg | Telefon +49 911 319-0 | Telefax +49 911 319-3196 E-Mail info @datev.de | Internet www.datev.de Sitz: 90429 Nürnberg, Paumgartnerstr. 6-14 | Registergericht Nürnberg, GenReg Nr.70 Vorstand Prof. Dieter Kempf (Vorsitzender) Dipl.-Kfm. Wolfgang Stegmann (stellvertretender Vorsitzender) Dipl.-Kfm. Michael Leistenschneider Dipl.-Kfm. Dr. Robert Mayr Jörg Rabe v. Pappenheim Dipl.-Vw. Eckhard Schwarzer Vorsitzender des Aufsichtsrates: Reinhard Verholen
participants (5)
-
Andreas Schulze
-
Axel Luttgens
-
Giam Teck Choon
-
Tamsy
-
Timo Sirainen