Dsync Header Hashing

older
Fwd: Plus addressing on Sentora...

Richard Laager

4 Mar 2016 4 Mar '16

7:47 a.m.

Is there any way to disable the header hashing in dsync?

I'm doing a one-time migration to Dovecot using imapc. The FETCHes for Date & Message-ID take a non-trivial amount of time and it's not clear to me if they have a function for a one-time migration.

-- Richard

Show replies by date

Timo Sirainen

4 Mar 4 Mar

4:52 p.m.

On 04 Mar 2016, at 07:47, Richard Laager rlaager@wiktel.com wrote:

...

Is there any way to disable the header hashing in dsync?

I'm doing a one-time migration to Dovecot using imapc. The FETCHes for Date & Message-ID take a non-trivial amount of time and it's not clear to me if they have a function for a one-time migration.

That would be nice, yes. Does the attached patch happen to work? Compiles, but untested for now.

Richard Laager

8 Mar 8 Mar

7:16 a.m.

On 03/04/2016 08:52 AM, Timo Sirainen wrote:

...

On 04 Mar 2016, at 07:47, Richard Laager wrote:

...
Is there any way to disable the header hashing in dsync? ... Does the attached patch happen to work? Compiles, but untested for now.

It works with one more change on top of your patch: diff --git a/src/doveadm/dsync/dsync-mailbox-export.c b/src/doveadm/dsync/dsync-mailbox-export.c index 361cc55..0267f86 100644 --- a/src/doveadm/dsync/dsync-mailbox-export.c +++ b/src/doveadm/dsync/dsync-mailbox-export.c @@ -518,7 +518,7 @@ dsync_mailbox_export_init(struct mailbox *box, p_array_init(&exporter->expunged_seqs, pool, 16); p_array_init(&exporter->expunged_guids, pool, 16); - if (!exporter->mails_have_guids) + if (!exporter->mails_have_guids && !exporter->no_hdr_hashes) exporter->wanted_headers = dsync_mail_get_hash_headers(box); /* first scan transaction log and save any expunges and flag changes */ -- Richard

Richard Laager

12 Apr 12 Apr

11:46 p.m.

We've completed our migration to Dovecot (yay!), so this isn't critical for me any more. But this change might still be a useful addition to Dovecot. It doesn't create any non-standard behavior (like my patch for non-atom flags). On 03/07/2016 11:16 PM, Richard Laager wrote:

...

On 03/04/2016 08:52 AM, Timo Sirainen wrote:

...
On 04 Mar 2016, at 07:47, Richard Laager wrote:

...
Is there any way to disable the header hashing in dsync? ... Does the attached patch happen to work? Compiles, but untested for now.

It works with one more change on top of your patch:

diff --git a/src/doveadm/dsync/dsync-mailbox-export.c b/src/doveadm/dsync/dsync-mailbox-export.c index 361cc55..0267f86 100644 --- a/src/doveadm/dsync/dsync-mailbox-export.c +++ b/src/doveadm/dsync/dsync-mailbox-export.c @@ -518,7 +518,7 @@ dsync_mailbox_export_init(struct mailbox *box, p_array_init(&exporter->expunged_seqs, pool, 16); p_array_init(&exporter->expunged_guids, pool, 16);

- if (!exporter->mails_have_guids) + if (!exporter->mails_have_guids && !exporter->no_hdr_hashes) exporter->wanted_headers = dsync_mail_get_hash_headers(box);

/* first scan transaction log and save any expunges and flag changes */

-- Richard

Timo Sirainen

13 Apr 13 Apr

12:05 a.m.

I added it today: https://github.com/dovecot/core/commit/03af8e5325a7b4fec36414ac35949457bc426...

...

On 12 Apr 2016, at 23:46, Richard Laager wrote:

We've completed our migration to Dovecot (yay!), so this isn't critical for me any more. But this change might still be a useful addition to Dovecot. It doesn't create any non-standard behavior (like my patch for non-atom flags).

On 03/07/2016 11:16 PM, Richard Laager wrote:

...
On 03/04/2016 08:52 AM, Timo Sirainen wrote:

...
On 04 Mar 2016, at 07:47, Richard Laager wrote:

...
Is there any way to disable the header hashing in dsync? ... Does the attached patch happen to work? Compiles, but untested for now.

It works with one more change on top of your patch:

diff --git a/src/doveadm/dsync/dsync-mailbox-export.c b/src/doveadm/dsync/dsync-mailbox-export.c index 361cc55..0267f86 100644 --- a/src/doveadm/dsync/dsync-mailbox-export.c +++ b/src/doveadm/dsync/dsync-mailbox-export.c @@ -518,7 +518,7 @@ dsync_mailbox_export_init(struct mailbox *box, p_array_init(&exporter->expunged_seqs, pool, 16); p_array_init(&exporter->expunged_guids, pool, 16);

- if (!exporter->mails_have_guids) + if (!exporter->mails_have_guids && !exporter->no_hdr_hashes) exporter->wanted_headers = dsync_mail_get_hash_headers(box);

/* first scan transaction log and save any expunges and flag changes */

-- Richard

Richard Laager

12:09 a.m.

On 04/12/2016 04:05 PM, Timo Sirainen wrote:

...

I added it today: https://github.com/dovecot/core/commit/03af8e5325a7b4fec36414ac35949457bc426...

Cool. And thanks for the awesome software!

-- Richard

3148

Age (days ago)

3187

Last active (days ago)

List overview

5 comments

2 participants

participants (2)

Richard Laager
Timo Sirainen