v2.2.28: patches (to use libressl 2.4.5) and test error (strftime)
t_strftime and variants now .......................................... : ok
test-time-util.c:123: Assert failed: strcmp(t_strftime(RFC2822_FMT, gmtime(&ts)), exp) == 0
test-time-util.c:124: Assert failed: strcmp(t_strfgmtime(RFC2822_FMT, ts), exp) == 0
t_strftime and variants fixed timestamp .............................. : FAILED
timings 0 ............................................................ : ok
On 25 Feb 2017, at 21.11, Ruga <ruga@protonmail.com> wrote:
t_strftime and variants now .......................................... : ok
test-time-util.c:123: Assert failed: strcmp(t_strftime(RFC2822_FMT, gmtime(&ts)), exp) == 0
test-time-util.c:124: Assert failed: strcmp(t_strfgmtime(RFC2822_FMT, ts), exp) == 0
t_strftime and variants fixed timestamp .............................. : FAILED
What OS is this? Could you try with the attached patch what it logs?
<configure.ac.patch>
Why do you want to disable /dev/urandom?
<dcrypt-openssl.c.patch>
Oh, I forgot to remove the #if OPENSSL_VERSION_NUMBER checks from lib-dcrypt. Will be removed in v2.2.29. Attached the planned patch that should do it.
tästä jäi pätsi =)
Aki
On 2017-02-25 22:08, Timo Sirainen wrote:
On 25 Feb 2017, at 21.54, Timo Sirainen <tss@iki.fi> wrote:
Oh, I forgot to remove the #if OPENSSL_VERSION_NUMBER checks from lib-dcrypt. Will be removed in v2.2.29. Attached the planned patch that should do it. Well that didn't work with <v1.1. Maybe this one.
Silly thunderbird, does not understand that "reply to sender" should reply to sender...
Aki
On 2017-02-25 23:40, Aki Tuomi wrote:
tästä jäi pätsi =)
Aki
On 2017-02-25 22:08, Timo Sirainen wrote:
On 25 Feb 2017, at 21.54, Timo Sirainen <tss@iki.fi> wrote:
Oh, I forgot to remove the #if OPENSSL_VERSION_NUMBER checks from lib-dcrypt. Will be removed in v2.2.29. Attached the planned patch that should do it. Well that didn't work with <v1.1. Maybe this one.
Timo,
re: What OS is this? OS 10.12.3 with Xcode 8.2.1 and the official clang 3.9.0
re: test-time-util.c
t_strftime and variants now .......................................... : ok
Info: 'Thu, 08 Dec 2016 18:42:16 +0100'
test-time-util.c:124: Assert failed: strcmp(t_strftime(RFC2822_FMT, gmtime(&ts)), exp) == 0
Info: 'Thu, 08 Dec 2016 18:42:16 +0100'
test-time-util.c:126: Assert failed: strcmp(t_strfgmtime(RFC2822_FMT, ts), exp) == 0
t_strftime and variants fixed timestamp .............................. : FAILED
timings 0 ............................................................ : ok
re: Why do you want to disable /dev/urandom? https://github.com/libressl-portable/portable/issues/278
re: dcrypt-openssl.c, ssl.m4 and HMAC_CTX_free(NULL) Please discuss this with busterb at GitHub.
-------- Original Message -------- Subject: Re: v2.2.28: patches (to use libressl 2.4.5) and test error (strftime) Local Time: 25 February 2017 8:54 PM UTC Time: 25 February 2017 19:54 From: tss@iki.fi To: Ruga <ruga@protonmail.com> Dovecot Mailing List <dovecot@dovecot.org>
On 25 Feb 2017, at 21.11, Ruga <ruga@protonmail.com> wrote:
t_strftime and variants now .......................................... : ok
test-time-util.c:123: Assert failed: strcmp(t_strftime(RFC2822_FMT, gmtime(&ts)), exp) == 0
test-time-util.c:124: Assert failed: strcmp(t_strfgmtime(RFC2822_FMT, ts), exp) == 0
t_strftime and variants fixed timestamp .............................. : FAILED
What OS is this? Could you try with the attached patch what it logs?
<configure.ac.patch>
Why do you want to disable /dev/urandom?
<dcrypt-openssl.c.patch>
Oh, I forgot to remove the #if OPENSSL_VERSION_NUMBER checks from lib-dcrypt. Will be removed in v2.2.29. Attached the planned patch that should do it.
On 26 Feb 2017, at 14.42, Ruga <ruga@protonmail.com> wrote:
Timo,
re: What OS is this? OS 10.12.3 with Xcode 8.2.1 and the official clang 3.9.0
re: test-time-util.c
t_strftime and variants now .......................................... : ok
Info: 'Thu, 08 Dec 2016 18:42:16 +0100'
test-time-util.c:124: Assert failed: strcmp(t_strftime(RFC2822_FMT, gmtime(&ts)), exp) == 0
Info: 'Thu, 08 Dec 2016 18:42:16 +0100'
test-time-util.c:126: Assert failed: strcmp(t_strfgmtime(RFC2822_FMT, ts), exp) == 0
t_strftime and variants fixed timestamp .............................. : FAILED
Fixed: https://github.com/dovecot/core/commit/3e6f1c0a999cc0abfc05d817dd89f39fb9337... <https://github.com/dovecot/core/commit/3e6f1c0a999cc0abfc05d817dd89f39fb9337e76>
re: Why do you want to disable /dev/urandom? https://github.com/libressl-portable/portable/issues/278 <https://github.com/libressl-portable/portable/issues/278>
That is fixed in v2.2.28 already.
re: dcrypt-openssl.c, ssl.m4 and HMAC_CTX_free(NULL) Please discuss this with busterb at GitHub.
Added a comment there, but I guess the changes should work fine.
participants (4)
-
Aki Tuomi
-
Peter Chiochetti
-
Ruga
-
Timo Sirainen