2021-09-16 19:32:02 +0300 Timo Sirainen (095089c) acl: acl_backend_vfile_has_acl() - Simplify code M src/plugins/acl/acl-backend-vfile.c 2021-09-16 19:13:09 +0300 Timo Sirainen (4f76565) acl: acl_backend_vfile_has_acl() - Open mailbox to check if it exists This is a bit more expensive than the previous behavior, but it's done only when creating or renaming mailboxes which are pretty rare operations. This fixes copying parent ACLs with obox when the parent mailbox doesn't exist in local metacache. M src/plugins/acl/acl-backend-vfile.c M src/plugins/acl/acl-backend-vfile.h 2021-09-16 19:26:07 +0300 Timo Sirainen (3533994) acl: acl_backend_vfile_has_acl() - Avoid unnecessary local ACL file check The local ACL file can't exist if its mailbox doesn't exist. M src/plugins/acl/acl-backend-vfile.c 2021-09-16 19:22:41 +0300 Timo Sirainen (0f8fb68) acl: acl_backend_vfile_has_acl() - Check first if global ACL exists Global ACL can be checked more efficiently. If it exists, there's no need anymore to access the local mailbox ro ACL files. M src/plugins/acl/acl-backend-vfile.c 2021-09-16 18:05:04 +0300 Timo Sirainen (f63bda4) acl: Consistently determine whether ACL files are in control or mailbox directory Add mail_storage_get_acl_list_path_type() that is used for it. This fixes ACL inheritance with obox. M src/plugins/acl/acl-backend-vfile-acllist.c M src/plugins/acl/acl-backend-vfile.c M src/plugins/acl/acl-backend-vfile.h 2021-09-06 00:49:06 +0100 Siavash Tavakoli (e1cbc8f) lib-lua: Add function for restricting global variable definition Add "dovecot.restrict_global_variables()" with a boolean argument to mitigate unintended variable assignments and to prevent unnecessarily populating global namespace. If enabled, variables can only be defined local to the script but global functions are still allowed. M src/lib-lua/dlua-dovecot.c 2021-09-07 15:03:37 +0100 Siavash Tavakoli (460edc6) lib-lua: Use rawget to check presence of functions in scripts With the restricted global variables in next commit, checking for undeclared functions results in error. Use rawget to avoid metamethods. M src/lib-lua/dlua-script.c 2021-09-17 12:26:35 +0300 Timo Sirainen (dc21a1d) lib-lua: Build test-dict-lua only with Lua 5.3+ Fixes building with Lua 5.1 M src/lib-lua/Makefile.am 2021-09-14 10:33:50 +0300 Aki Tuomi (85e65dd) lib-compression: bench-compress - Ensure we have both istream and ostream constructor After 6e5ae5ef0f0f31acd7bde0db53980a708c81eced we have read-only compression mechanism, that leads to null pointer crash in bench-compress. M src/lib-compression/bench-compression.c 2021-09-16 20:12:13 +0300 Timo Sirainen (4ee8601) NEWS: Add news for 2.3.16 M NEWS 2021-09-10 15:52:43 +0300 Timo Sirainen (9e3df2c) lib-lua: Add test-dict-lua M src/lib-lua/Makefile.am A src/lib-lua/test-dict-lua.c 2021-09-10 15:47:47 +0300 Timo Sirainen (39f2166) dict-lua: Change dict:lookup() to actually return nil if key isn't found It was previously returning an empty table, although the comment said it should have returned nil. M src/lib-dict/dict-lua.c 2021-09-10 12:49:50 +0300 Timo Sirainen (a564b60) lib-dict: dict-lua - Add set_timestamp() M src/lib-dict/dict-txn-lua.c 2021-09-01 19:33:49 +0300 Timo Sirainen (53eeb81) lib-dict: dict-lua - Add unset() M src/lib-dict/dict-txn-lua.c 2021-09-07 17:00:07 +0300 Timo Sirainen (3740bc1) indexer: Remove the concept of a "busy" connection All the connections are busy, since they are created for a new request and they are disconnected when the request is done. M src/indexer/indexer.c M src/indexer/worker-connection.c M src/indexer/worker-connection.h M src/indexer/worker-pool.c M src/indexer/worker-pool.h 2021-09-07 16:56:16 +0300 Timo Sirainen (2f8bdc9) indexer: Handle more requests whenever indexer-worker connection closes Previously this was done only when worker process sent a "request finished" notification. Crashing worker processes could have caused the queue to get stuck until more requests were added to the queue. M src/indexer/indexer.c M src/indexer/worker-connection.c M src/indexer/worker-connection.h M src/indexer/worker-pool.c M src/indexer/worker-pool.h 2021-09-07 16:52:40 +0300 Timo Sirainen (61ca1eb) indexer: Disconnect from worker after each request service_count won't be tracked correctly otherwise. M src/indexer/worker-connection.c 2021-09-07 15:47:23 +0300 Timo Sirainen (9718957) indexer: Fix tracking indexer-worker's process_limit After recent changes, the process_limit was too often thought to be 1. M src/indexer/worker-connection.c M src/indexer/worker-connection.h M src/indexer/worker-pool.c 2021-08-31 12:14:15 +0300 Timo Sirainen (4018f44) indexer: Change status callback to take struct indexer_request parameter M src/indexer/indexer.c M src/indexer/indexer.h M src/indexer/worker-connection.c M src/indexer/worker-connection.h 2021-08-31 12:12:49 +0300 Timo Sirainen (b1c4f2b) indexer: Don't free worker_connection too early There's no need for the status callback anymore to free the connection. It will be tracked automatically. M src/indexer/indexer.c M src/indexer/worker-connection.c M src/indexer/worker-connection.h M src/indexer/worker-pool.c M src/indexer/worker-pool.h 2021-08-31 12:08:32 +0300 Timo Sirainen (a15eb46) indexer: Use a separate indexer_queue_callback_t type for indexer-queue callback M src/indexer/indexer-queue.c M src/indexer/indexer-queue.h 2021-09-14 15:33:50 +0300 sergey.kitov (e7a3c48) lib: Remove connect_finished_time field from connection event. M src/lib/connection.c 2021-09-10 19:00:09 +0300 Timo Sirainen (da3bc6e) lib: ENUM_NEGATE() - Disable runtime sizeof() check with STATIC_CHECKER This is to avoid "Dangerous variable-length array (VLA) declaration" errors with clang 12 scan-build, which happen because scan-build keeps thinking that the enums can become larger than 2147483647. M src/lib/macros.h 2021-08-31 15:44:20 +0300 Aki Tuomi (4826b08) doveadm: Flush data to server client asynchronously M src/doveadm/doveadm-print-server.c 2021-07-13 13:32:09 +0200 Markus Valentin (d89e8a5) virtual: Add storage flag for secondary index M src/plugins/virtual/virtual-storage.c 2021-07-13 13:28:43 +0200 Markus Valentin (69ddbe6) lib-storage: Add storage_class_flag for secondary index M src/lib-storage/mail-storage-private.h 2021-09-10 06:47:21 +0200 Bernhard M. Wiedemann (00eba31) man: doveadm director flush - The parameter is -F, not -f M doc/man/doveadm-director.1.in 2021-09-08 09:53:12 +0300 Aki Tuomi (30eecd1) doveadm: doveadm-stats - Allocate field_types field_types was function local variable that got used outside of function. Change to use datastack allocation instead to keep it valid after leaving function. Broken in e9a46e3a6df2edd6cb68a8fc04a5e8e4564a9d5e M src/doveadm/doveadm-stats.c 2021-08-31 12:48:38 +0300 Aki Tuomi (601b546) lib-storage: Move (un)deleting debug message to mailbox_mark_index_deleted M src/lib-storage/list/mail-storage-list-index-rebuild.c M src/lib-storage/mail-storage.c 2021-08-09 11:56:17 +0300 Aki Tuomi (99efbc7) lib-storage: mailbox-list - Detect duplicate GUIDs This is only done for LAYOUT=INDEX. M src/lib-storage/list/mailbox-list-index.c 2021-08-19 17:10:31 +0300 Aki Tuomi (f30403d) lib-storage: mailbox-list - Add duplicate pool for duplicate detection M src/lib-storage/list/mailbox-list-index.c 2021-08-16 14:38:47 +0300 Aki Tuomi (196a5ed) lib-storage: maildir - Use mail_storage_index_list_rebuild M src/lib-storage/index/maildir/maildir-storage.c M src/lib-storage/index/maildir/maildir-sync.c 2021-08-20 11:43:27 +0300 Aki Tuomi (18afa46) lib-storage: maildir - Allow creating existing folder when rebuilding list index M src/lib-storage/index/maildir/maildir-storage.c 2021-08-09 14:23:13 +0300 Aki Tuomi (a92541c) lib-storage: dbox - Use mailbox_list_index_rebuild M src/lib-storage/index/dbox-multi/mdbox-storage.c M src/lib-storage/index/dbox-multi/mdbox-sync.c M src/lib-storage/index/dbox-single/sdbox-storage.c M src/lib-storage/index/dbox-single/sdbox-sync.c M src/lib-storage/index/index-storage.c 2021-08-09 15:47:28 +0300 Aki Tuomi (451883d) lib-storage: dbox - Allow creating existing folder when rebuilding list index M src/lib-storage/index/dbox-common/dbox-storage.c M src/lib-storage/index/index-storage.c 2021-08-13 14:18:21 +0300 Aki Tuomi (2fc8d70) lib-storage: Add list index rebuild code M src/lib-storage/list/Makefile.am A src/lib-storage/list/mail-storage-list-index-rebuild.c M src/lib-storage/mail-storage-private.h 2021-08-27 12:59:59 +0300 Aki Tuomi (5a75724) lib-storage: Populate mailboxes_fs if needed M src/lib-storage/mail-storage.c 2021-08-20 14:30:46 +0300 Aki Tuomi (3855ccb) lib-storage: mailbox-list - Try to get GUID from mailbox path M src/lib-storage/list/mailbox-list-index-status.c 2021-08-13 10:29:59 +0300 Aki Tuomi (a92b1f9) lib-storage: Add fields to mail_storage needed for list rebuild M src/lib-storage/mail-storage-private.h M src/lib-storage/mail-storage.c 2021-06-30 08:44:33 +0300 Aki Tuomi (36f96c4) lib-storage: Fix changing mailbox GUID with LAYOUT=index The old path would generate Mail/mailboxes/mailboxes/ M src/lib-storage/list/mailbox-list-index-backend.c 2021-06-22 15:59:25 +0300 sergey.kitov (c1a57f4) doveadm-stats: Add doveadm stats add/remove documentation M doc/man/doveadm-stats.1.in 2021-05-27 11:46:02 +0300 sergey.kitov (bc31da4) doveadm: Add 'stats add' and 'stats remove' commands M src/doveadm/Makefile.am M src/doveadm/doveadm-cmd.c M src/doveadm/doveadm-cmd.h M src/doveadm/doveadm-stats.c 2021-06-09 17:23:28 +0300 sergey.kitov (eef75dd) stats: replace hardcoded value of default exporter_include with macro M src/stats/stats-settings.c M src/stats/stats-settings.h 2021-06-09 17:22:39 +0300 sergey.kitov (e9a46e3) doveadm: Rewrite doveadm stats dump command to allow reuse code in other commands. M src/doveadm/doveadm-stats.c 2021-05-10 16:39:21 +0300 sergey.kitov (57bb3b9) lib-master: Accept filter updates from stats by stats-client. M src/lib-master/stats-client.c 2021-04-20 17:07:36 +0300 sergey.kitov (0444b73) stats: Implement ipc interface for adding and removing metrics M src/stats/client-reader.c 2021-05-10 16:13:12 +0300 sergey.kitov (adbbd40) stats: Implement sending filter updates to connected processes. M src/stats/client-writer.c M src/stats/client-writer.h 2021-04-20 17:06:58 +0300 sergey.kitov (a2a79fb) stats: Add functions for adding or removing metrics M src/stats/stats-metrics.c M src/stats/stats-metrics.h 2021-04-13 11:49:43 +0300 sergey.kitov (50f36bb) stats: Expose stats_metric_setting_parser_info M src/stats/stats-settings.h 2021-04-20 17:06:26 +0300 sergey.kitov (fcacfde) lib: Add function removing queries from event_filter M src/lib/event-filter.c M src/lib/event-filter.h 2021-09-02 14:31:36 +0300 Timo Sirainen (a476e16) lib-http: test-http-client-errors - Fix random hangs Wait for subprocesses to be initialized before starting each test. This should fix random hangs with the test. M src/lib-http/test-http-client-errors.c 2021-09-02 15:39:33 +0300 Timo Sirainen (8b88374) lib-test: test_subprocess_notify_signal_*() - Add signo parameter This allows using multiple notification signals. M src/lib-http/test-http-client-errors.c M src/lib-test/test-subprocess.c M src/lib-test/test-subprocess.h 2021-08-19 12:50:04 +0200 Timo Sirainen (5280904) lib-storage: Make sure header parsing is deinitialized after failures This should fix all the possible reasons for: Panic: file index-mail-headers.c: line 198 (index_mail_parse_header_init): assertion failed: (!mail->data.header_parser_initialized) M src/lib-storage/index/index-mail-headers.c M src/lib-storage/index/index-mail.c M src/lib-storage/index/index-mail.h 2021-08-19 12:32:45 +0200 Timo Sirainen (0b6a2fb) lib-storage: Fix potential assert-crash if filter-stream fails If filter-stream isn't read until header (because the parent istream fails), the header parsing isn't deinitialized. If after the failure the headers are attempted to be parsed again, there's an assert-crash. Make sure this won't happen by finishing the filter-istream read, and if that fails then reset the header parsing anyway. Destroying the filter_stream may also change the parent istream offset to change, so this commit adds an extra seek to beginning of the istream when beginning to parse the mail headers. Fixes: Panic: file index-mail-headers.c: line 198 (index_mail_parse_header_init): assertion failed: (!mail->data.header_parser_initialized) M src/lib-storage/index/index-mail-headers.c 2021-08-19 12:29:36 +0200 Timo Sirainen (45df815) lib-storage: Split off index_mail_filter_stream_destroy() M src/lib-storage/index/index-mail-headers.c 2021-08-17 14:33:56 +0200 Markus Valentin (6b7e4d1) imapc: Fix crashing when copying nonexistent mails Check the msgmap before attempting to copy an mail which may has been expunged already. Fixes: Panic: file mail-storage.c: line 2385 (mailbox_transaction_commit_get_changes): assertion failed: (ret < 0 || seq_range_count(&changes_r->saved_uids) == save_count || array_count(&changes_r->saved_uids) == 0) M src/lib-storage/index/imapc/imapc-save.c 2021-08-18 14:04:53 +0200 Timo Sirainen (8e59266) lib-storage: Fix assert-crash in special partial mail parsing failures This happened for example if: - mail_precache() started parsing mail - header was parsed, but mail body parsing failed due to mail size mismatch - vsize parsing doesn't restart header parsing, because header size is already known - body parsing assert-crashes because there is no messsage parser initialized Fixes: Panic: file index-mail.c: line 1290 (index_mail_parse_body): assertion failed: (data->parser_ctx != NULL) M src/lib-storage/index/index-mail.c 2021-08-12 12:42:40 +0300 Aki Tuomi (35f7ff1) lib-oauth2: Add unit test for missing exp field M src/lib-oauth2/test-oauth2-jwt.c 2021-08-12 12:40:39 +0300 Aki Tuomi (5bc6fa7) lib-oauth2: Add unit tests for valid tokens M src/lib-oauth2/test-oauth2-jwt.c 2021-06-08 00:35:13 +0200 s3lph <5564491+s3lph@users.noreply.github.com> (f3bef96) lib-oauth2-jwt: Remove 'nbf < iat' check, as it's not mandated by RFC7519, and not uncommon to predate the nbf field M src/lib-oauth2/oauth2-jwt.c 2021-08-24 22:58:59 +0200 Timo Sirainen (8a7fa00) lib-test: Fix race when subprocess immediately receives signal Signal could be received before test_subprocess_is_child=1 is set, causing the subprocess's signal handler to also attempt to cleanup other subprocesses. This was causing http-test-client-errors unit tests to fail somewhat randomly, especially when running them only with 1 CPU. M src/lib-test/test-subprocess.c 2021-08-24 15:02:44 +0300 Timo Sirainen (07d6636) lib: Add test-macros M src/lib/Makefile.am M src/lib/test-lib.inc A src/lib/test-macros.c 2021-08-23 14:21:02 +0300 Timo Sirainen (a4f9219) lib: Rewrite POINTER_CAST_TO() to avoid new clang warning Fixes: warning: performing pointer subtraction with a null pointer has undefined behavior [-Wnull-pointer-subtraction] M src/lib/macros.h 2021-08-23 14:20:54 +0300 Timo Sirainen (9c4077a) dbox: Remove unnecessary variable The variable was set and updated, but never read. M src/lib-storage/index/dbox-common/dbox-file.c 2021-08-23 14:20:24 +0300 Timo Sirainen (a11c739) lib-dcrypt: Remove unnecessary variable The variable was set and updated, but never read. M src/lib-dcrypt/istream-decrypt.c 2021-08-23 11:46:46 +0300 Martti Rannanjärvi (bc67923) doveadm-dsync: Free ssl_iostream_context on connection failure M src/doveadm/doveadm-dsync.c 2021-04-13 18:25:06 +0200 Stephan Bosch (415c305) lib-smtp: smtp-server-cmd-rcpt - Fix assert crash occurring for pipelined MAIL RCPT MAIL sequence. The assertion is wrong in that it assumes that no MAIL commands can be pending once RCPT command is next to reply. The RCPT command does not block the pipeline, so that a subsequent MAIL command can also be pending (but will almost never succeed). M src/lib-smtp/smtp-server-cmd-rcpt.c M src/lib-smtp/test-smtp-server-errors.c 2021-04-13 18:25:31 +0200 Stephan Bosch (2324661) lib-smtp: smtp-server-cmd-data - Add comment to pipeline state assertion. M src/lib-smtp/smtp-server-cmd-data.c 2021-08-20 01:19:28 +0200 Stephan Bosch (741a963) lib-smtp: smtp-server-cmd-data - Remove useless trans != NULL checks. M src/lib-smtp/smtp-server-cmd-data.c 2021-08-19 17:06:42 +0100 Siavash Tavakoli (285cf9c) dict-sql: Fail early if there's unexpected number of bind arguments for iter Otherwise, lib-sql raises a panic. M src/lib-dict-backend/dict-sql.c 2021-08-17 15:23:31 +0200 Timo Sirainen (e34bffa) lib: istreams - Make sure freeing snapshots can't access freed parent istream memory This happened after the recent istream-header-filter snapshot changes. M src/lib/istream.c 2021-08-18 19:49:43 +0200 Timo Sirainen (b401e41) imap: Fix mailbox leak if MOVE can't open the source mailbox Broken by 143b7c2b412ed8f155e812603fda81886bec466e Fixes: Panic: file mail-user.c: line 229 (mail_user_deinit): assertion failed: ((*user)->refcount == 1) M src/imap/cmd-copy.c 2021-08-18 13:54:39 +0100 Siavash Tavakoli (16deb5b) lib-lua: Don't include lua_resume_compat() for 5.1 lua_resume() is not supported in 5.1, so don't try to add a compatibility function that fails compilation. M src/lib-lua/dlua-compat.c M src/lib-lua/dlua-compat.h 2021-05-25 19:26:14 +0300 Timo Sirainen (bb1d67a) lib: Remove unused event_filter_add() M src/lib/event-filter.c M src/lib/event-filter.h 2021-08-16 17:13:27 +0300 Timo Sirainen (f1bbfcb) lib: test-event-filter - Replace event_filter_add() with event_filter_parse() M src/lib/test-event-filter.c 2021-05-24 23:57:13 +0300 Timo Sirainen (c4369cb) lib: Add comments to event-related code M src/lib/event-log.c M src/lib/event-log.h M src/lib/lib-event-private.h M src/lib/lib-event.h 2021-05-24 22:26:27 +0300 Timo Sirainen (d2c0f13) lib: event_want_level() - Minor code cleanup event_want_log_level() internally does both of these checks, so it's enough to just check its return value. M src/lib/event-log.c 2021-08-17 12:12:18 +0300 Timo Sirainen (730b2a4) lib-fs: Fix fs_stats.copy_count tracking with fs_default_copy() The copy_count could have been decreased too many times with async operations. M src/lib-fs/fs-api-private.h M src/lib-fs/fs-api.c 2021-08-16 15:36:37 +0300 Timo Sirainen (b82faee) global: Add ATTR_UNSIGNED_WRAPS to fix various ubsan issues M src/auth/crypt-blowfish.c M src/lib/numpack.c M src/lib/sha3.c 2021-08-05 18:53:57 +0300 Timo Sirainen (9e80b58) global: Fix various ubsan issues M src/lib-mail/istream-header-filter.c M src/lib-mail/test-qp-decoder.c M src/lib-test/test-istream.c M src/lib/test-base64.c M src/lib/test-data-stack.c 2021-08-17 10:59:49 +0300 Timo Sirainen (05189ec) doveadm: Free memory for all loaded mail_plugins at deinit M src/doveadm/doveadm-mail.c 2021-08-17 10:50:34 +0300 Timo Sirainen (654d7b2) doveadm pw -l: Free all memory to avoid memory leak complaints M src/doveadm/doveadm-pw.c 2021-08-17 09:30:25 +0200 Timo Sirainen (b997fc9) doveadm batch: Fix memory leak M src/doveadm/doveadm-mail-batch.c 2021-08-17 11:06:36 +0300 Timo Sirainen (46a5114) doveadm: Split off doveadm_mail_cmd_deinit() M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-mail.h 2021-05-07 21:15:04 +0300 Timo Sirainen (f708052) doveadm: Make doveadm_mail_cmd_free() public M src/doveadm/doveadm-mail.c M src/doveadm/doveadm-mail.h 2021-08-13 11:08:30 +0100 Siavash Tavakoli (f28482a) global: Use consistent lua function names Change lua-style function names to be consistent with dovecot's style. M src/auth/db-lua.c M src/lib-lua/dlua-dovecot.c M src/lib-lua/dlua-error.c M src/lib-lua/dlua-pushstring.c M src/lib-lua/dlua-script-private.h M src/lib-lua/dlua-script.c M src/lib-storage/mail-lua.c M src/lib-storage/mail-storage-lua.c M src/lib-storage/mail-user-lua.c M src/lib-storage/mailbox-lua.c M src/plugins/push-notification/push-notification-driver-lua.c 2021-08-12 19:43:25 +0100 Siavash Tavakoli (e14026e) lib-lua: test-lua: Fix the test for lua versions later than 5.3 M src/lib-lua/test-lua.c 2021-08-12 19:40:22 +0100 Siavash Tavakoli (72a864b) lib-lua: Add lua_resume_compat() and use it in lua versions prior to 5.4 Starting lua 5.4 "lua_resume()" expects an extra "nresults" argument. Add a compatibility function to handle this argument in earlier versions. M src/lib-lua/dlua-compat.c M src/lib-lua/dlua-compat.h M src/lib-lua/dlua-resume.c 2020-05-24 14:47:18 -0400 Felipe Gasper (2595113) man: Document command/args destination format to sync/backup. M doc/man/doveadm-sync.1.in 2021-08-16 14:52:50 +0300 Timo Sirainen (e14e68c) lib-compression: istream-lz4 - Fix handling partial header reads Reading assert-crashed if the header was read only partially. Either because the file really was truncated or because parent stream already had fewer bytes buffered. M src/lib-compression/istream-lz4.c M src/lib-compression/test-compression.c 2021-08-16 14:51:29 +0300 Timo Sirainen (d899545) lib-compression: istream-lz4 - Remove redundant check The loop is reached only if ret is 0, so there's no need to check it again. M src/lib-compression/istream-lz4.c 2021-08-16 14:50:10 +0300 Timo Sirainen (eea3b75) lib-compression: istream-lz4 - Add asserts to make sure parent buffer isn't full The parent buffer's max size would have to be tiny for these to happen. M src/lib-compression/istream-lz4.c 2021-07-01 13:52:29 +0100 Siavash Tavakoli (f38100a) dict: Use dict-init-cache Make use of dict-init-cache for initialization and deinitialization of dicts. M src/dict/dict-connection.c M src/dict/main.c 2021-06-25 14:11:52 +0100 Siavash Tavakoli (222e8d5) dict: Add caching mechanism for initializing dicts Add a pool for dict instances. Each dict is refcounted and given a grace period of 30 seconds for deletion. If refcount drops to 0 and no new dict operation uses the instance in that period, it will be freed. A maximum of 10 dicts are kept in the cache. M src/dict/Makefile.am A src/dict/dict-init-cache.c A src/dict/dict-init-cache.h 2021-08-09 00:35:09 +0100 Siavash Tavakoli (f5a2a9a) dict: Add dict_created and dict_destroyed events Inherit from dict.event and emitted at dict initialization/deinit. M src/lib-dict/dict.c 2021-08-15 12:45:12 +0300 Martti Rannanjärvi (fcf23d9) lib-sasl: test-sasl-client.c - Initialize authid of sasl_empty_set This fixes the compiler warning: test-sasl-client.c:8:1: error: missing initializer for field 'authid' of 'const struct dsasl_client_settings' M src/lib-sasl/test-sasl-client.c 2021-08-15 07:12:42 +0300 Martti Rannanjärvi (0434bd9) lib-sasl: oauthbearer - Fix memory leak on auth failure M src/lib-sasl/mech-oauthbearer.c 2021-08-11 09:48:06 +0300 Aki Tuomi (64ab5d8) lib-sasl: Add unit tests M src/lib-sasl/Makefile.am A src/lib-sasl/test-sasl-client.c 2021-08-11 09:59:05 +0300 Aki Tuomi (5071cfe) lib-sasl: Do not crash if password is NULL M src/lib-sasl/dsasl-client.c 2021-08-11 09:47:17 +0300 Aki Tuomi (feba4f0) lib-sasl: When setting port, parse value, not key. Broken in 228f1e8d583 M src/lib-sasl/mech-oauthbearer.c 2021-08-11 08:49:44 +0300 Aki Tuomi (902407f) auth: Do not forward empty "master" passdb field M src/auth/auth-request-handler.c 2021-08-11 08:48:29 +0300 Aki Tuomi (f4cf9d6) login-common: Ignore empty value for "master" passdb extra field M src/login-common/client-common-auth.c 2021-08-10 12:26:14 +0100 Siavash Tavakoli (a0c1fe3) mail-crypt: Add password confirmation for doveadm cryptokey password command To prevent setting wrong passwords by accident. M src/plugins/mail-crypt/doveadm-mail-crypt.c 2021-08-10 12:23:55 +0100 Siavash Tavakoli (1383076) mail-crypt: Fix -O argument type for doveadm cryptokey password command Should be boolean instead of string. M src/plugins/mail-crypt/doveadm-mail-crypt.c 2021-04-28 02:01:14 +0300 Timo Sirainen (ddf2248) lib-index: Fix "Extension introduction for unknown id" errors after map is generated This happens when: * View is opened * Messages are expunged * View is synced with NOEXPUNGES flag * A new extension is introduced * Index is rotated at least twice * View is again synced with NOEXPUNGES flag * More changes are done to index with the new extension * Once more view is synced with NOEXPUNGES flag The last sync will see changes with the new extension ID, but the view's map doesn't know its ID. M src/lib-index/mail-index-sync-ext.c M src/lib-index/test-mail-index.c 2021-06-24 12:58:58 -0400 Josef 'Jeff' Sipek (710346b) virtual: Expunge old emails if backend box guid changed This introduces a new extensible "ext2" header to make it easier to add new fields in the future. It also allows keeping backwards/forwards compatibility with the old code, so the virtual index isn't rebuilt on upgrades or downgrades. M src/plugins/virtual/virtual-storage.c M src/plugins/virtual/virtual-storage.h M src/plugins/virtual/virtual-sync.c 2021-07-29 12:38:12 +0300 Timo Sirainen (5310858) virtual: Don't use data stack when building extension header Some users may have thousands of mailboxes, which grows the data stack unnecessarily large. M src/plugins/virtual/virtual-sync.c 2021-08-09 13:01:12 +0300 Timo Sirainen (97367ef) indexer: Fix crash if client disconnects while it's waiting for command reply This happened for example if IMAP SEARCH triggered long fts indexing and the IMAP client disconnected while waiting for the reply. Broken by f62a25849358e40a08a2c47f5bcaa1613a31d076 M src/indexer/indexer-client.c 2021-05-06 11:58:21 +0200 Stephan Bosch (9f5e723) lib-smtp: smtp-server-cmd-data - Fix global state cleanup upon DATA command