2021-04-20 18:06:19 +0200 Timo Sirainen (f199883) util/dovecot-sysreport: Finish report even if doveadm calls fail It can be useful to generate the report even when dovecot isn't running. M src/util/dovecot-sysreport 2021-04-01 14:16:34 +0300 Timo Sirainen (ebf2557) util/dovecot-sysreport --core: Support multiple core files M doc/man/dovecot-sysreport.1.in M src/util/dovecot-sysreport 2021-04-01 14:12:14 +0300 Timo Sirainen (d7cb97d) util/dovecot-sysreport --core: Check gdb existence earlier Simplifies the next commit. M src/util/dovecot-sysreport 2021-04-01 14:09:42 +0300 Timo Sirainen (74d399f) util/dovecot-sysreport --core: Change binary path to be optional If not specified, detect it from the core file itself M src/util/dovecot-sysreport 2021-05-06 01:08:50 +0300 Timo Sirainen (e2651f1) global: Use array_idx_elem() where possible M src/auth/auth-worker-server.c M src/auth/db-dict.c M src/auth/db-ldap.c M src/auth/db-lua.c M src/director/director.c M src/doveadm/dsync/dsync-mailbox-import.c M src/doveadm/dsync/dsync-mailbox-tree-sync.c M src/indexer/indexer-queue.c M src/lib-dict-backend/dict-ldap.c M src/lib-dict/dict-client.c M src/lib-dns/test-dns-util.c M src/lib-http/http-server-resource.c M src/lib-imap-client/imapc-connection.c M src/lib-index/mail-index-transaction.c M src/lib-ldap/ldap-connection.c M src/lib-sql/driver-cassandra.c M src/lib-storage/index/imapc/imapc-save.c M src/lib-storage/index/imapc/imapc-sync.c M src/lib-storage/index/maildir/maildir-keywords.c M src/lib-storage/list/mailbox-list-fs-iter.c M src/lib-storage/list/mailbox-list-index-notify.c M src/lib-storage/mail-search-args-imap.c M src/lib-storage/mailbox-attribute.c M src/lib-storage/mailbox-list.c M src/lib/hash2.c M src/plugins/acl/acl-lookup-dict.c M src/plugins/push-notification/push-notification-drivers.c M src/plugins/push-notification/push-notification-events.c M src/plugins/quota/quota.c M src/plugins/virtual/virtual-save.c M src/stats/stats-service-openmetrics.c 2021-05-04 16:40:09 +0300 Timo Sirainen (2070e0f) lib: Add array_idx_elem() This returns array_idx()'s value dereferenced, so it only works for arrays of pointers. Note that using *array_idx() does the same, but it won't compile if the compiler doesn't have typeof() support. M src/lib/array.h M src/lib/test-array.c 2021-02-10 22:06:29 +0200 Timo Sirainen (f79dbc2) lib: Remove array_swap() It's not used anywhere, and it's a bit too weird. M src/lib/array.h M src/lib/test-array.c 2021-02-10 21:45:58 +0200 Timo Sirainen (2b50ec1) global: Use array_foreach_elem() where possible M src/dict/dict-commands.c M src/imap-login/imap-login-commands.c M src/imap-urlauth/imap-urlauth-worker.c M src/ipc/ipc-connection.c M src/ipc/ipc-group.c M src/lib-fs/fs-api.c M src/lib-mail/istream-attachment-connector.c M src/lib-master/master-service-settings.c M src/lib-program-client/program-client-local.c M src/lib-program-client/program-client-remote.c M src/lib-sql/driver-cassandra.c M src/lib-sql/driver-sqlpool.c M src/lib-test/test-subprocess.c M src/lmtp/lmtp-proxy.c M src/login-common/login-proxy.c M src/login-common/main.c M src/replication/replicator/doveadm-connection.c M src/replication/replicator/replicator-brain.c 2021-02-10 21:45:41 +0200 Timo Sirainen (b3bc25e) lib-fts: Use array_foreach_elem() where possible M src/lib-fts/fts-filter.c M src/lib-fts/fts-language.c M src/lib-fts/fts-tokenizer.c 2021-02-10 21:45:19 +0200 Timo Sirainen (bdc37a1) submission: Use array_foreach_elem() where possible M src/submission/submission-backend-relay.c M src/submission/submission-backend.c M src/submission/submission-recipient.c 2021-02-10 21:43:18 +0200 Timo Sirainen (6392b07) stats: Use array_foreach_elem() where possible M src/stats/client-http.c M src/stats/stats-metrics.c M src/stats/stats-service-openmetrics.c M src/stats/stats-settings.c 2021-02-10 21:35:04 +0200 Timo Sirainen (7c7e721) lib-smtp: Use array_foreach_elem() where possible M src/lib-smtp/smtp-server-cmd-data.c M src/lib-smtp/smtp-server-transaction.c M src/lib-smtp/smtp-submit.c 2021-02-10 21:31:16 +0200 Timo Sirainen (162320b) lib-old-stats: Use array_foreach_elem() where possible M src/lib-old-stats/stats.c 2021-02-10 21:20:25 +0200 Timo Sirainen (1bf42b1) config: Use array_foreach_elem() where possible M src/config/config-filter.c M src/config/config-parser.c M src/config/doveconf.c 2021-02-10 21:18:42 +0200 Timo Sirainen (3200ca5) plugins: Use array_foreach_elem() where possible M src/plugins/fts/fts-search-args.c M src/plugins/fts/fts-user.c M src/plugins/mail-crypt/doveadm-mail-crypt.c M src/plugins/mail-crypt/mail-crypt-acl-plugin.c M src/plugins/mail-crypt/mail-crypt-key.c M src/plugins/notify-status/notify-status-plugin.c M src/plugins/push-notification/push-notification-driver-dlog.c M src/plugins/push-notification/push-notification-driver-lua.c M src/plugins/push-notification/push-notification-drivers.c M src/plugins/push-notification/push-notification-event-flagsclear.c M src/plugins/push-notification/push-notification-event-flagsset.c M src/plugins/push-notification/push-notification-plugin.c M src/plugins/push-notification/push-notification-triggers.c 2021-02-10 21:09:42 +0200 Timo Sirainen (6a1099f) master: Use array_foreach_elem() where possible M src/master/main.c M src/master/master-client.c M src/master/master-settings.c M src/master/service-listen.c M src/master/service-log.c M src/master/service-monitor.c M src/master/service.c 2021-02-10 21:03:16 +0200 Timo Sirainen (4dea1ae) lib-index: Use array_foreach_elem() where possible M src/lib-index/mail-index-fsck.c M src/lib-index/mail-index-transaction.c 2021-02-10 21:01:06 +0200 Timo Sirainen (6d8e8e3) lib-imap-client: Use array_foreach_elem() where possible M src/lib-imap-client/imapc-client.c M src/lib-imap-client/imapc-connection.c 2021-02-10 20:58:20 +0200 Timo Sirainen (d97ca59) lib-http: Use array_foreach_elem() where possible M src/lib-http/http-client-host.c M src/lib-http/http-client-peer.c M src/lib-http/http-client-queue.c M src/lib-http/http-client.c M src/lib-http/http-message-parser.c M src/lib-http/http-request.c M src/lib-http/http-response.c M src/lib-http/http-server-resource.c M src/lib-http/http-server-response.c M src/lib-http/http-server.c 2021-02-10 20:45:50 +0200 Timo Sirainen (93c59b3) lib-dict: Use array_foreach_elem() where possible M src/lib-dict/dict-client.c M src/lib-dict/dict.c 2021-02-10 20:44:08 +0200 Timo Sirainen (b797b83) imap: Use array_foreach_elem() where possible M src/imap/imap-client.c M src/imap/imap-commands-util.c M src/imap/imap-notify.c M src/imap/imap-state.c 2021-02-10 20:41:27 +0200 Timo Sirainen (75b985c) doveadm: Use array_foreach_elem() where possible M src/doveadm/doveadm-dump.c M src/doveadm/doveadm-fs.c M src/doveadm/doveadm-mail-batch.c M src/doveadm/doveadm-mail-mailbox.c M src/doveadm/doveadm-mail-server.c M src/doveadm/doveadm-print-table.c M src/doveadm/doveadm-who.c M src/doveadm/dsync/dsync-brain.c M src/doveadm/dsync/dsync-ibc-pipe.c M src/doveadm/dsync/dsync-mailbox-import.c M src/doveadm/server-connection.c 2021-02-10 20:34:25 +0200 Timo Sirainen (8364fd0) director: Use array_foreach_elem() where possible M src/director/director-connection.c M src/director/director-host.c M src/director/director.c M src/director/doveadm-connection.c M src/director/mail-host.c M src/director/main.c M src/director/notify-connection.c M src/director/user-directory.c 2021-02-10 20:25:30 +0200 Timo Sirainen (cab67ca) auth: Use array_foreach_elem() where possible M src/auth/auth-worker-server.c M src/auth/auth.c M src/auth/db-dict-cache-key.c M src/auth/db-dict.c M src/auth/passdb.c M src/auth/userdb.c 2021-02-10 20:13:52 +0200 Timo Sirainen (6c540c7) lib-storage: Use array_foreach_elem() where possible M src/lib-storage/index/dbox-single/sdbox-file.c M src/lib-storage/index/dbox-single/sdbox-sync.c M src/lib-storage/index/imapc/imapc-mail-fetch.c M src/lib-storage/index/imapc/imapc-mailbox.c M src/lib-storage/index/index-search.c M src/lib-storage/index/maildir/maildir-save.c M src/lib-storage/list/mailbox-list-index-sync.c M src/lib-storage/list/mailbox-list-index.c M src/lib-storage/mail-autoexpunge.c M src/lib-storage/mail-namespace.c M src/lib-storage/mail-storage-hooks.c M src/lib-storage/mail-storage.c M src/lib-storage/mailbox-list.c M src/lib-storage/mailbox-lua.c M src/lib-storage/mailbox-tree.c M src/lib-storage/mailbox-watch.c 2021-02-10 20:06:07 +0200 Timo Sirainen (6934e3e) lib: Use array_foreach_elem() where possible M src/lib/env-util.c M src/lib/event-filter.c M src/lib/ioloop.c M src/lib/istream-multiplex.c M src/lib/lib-event.c M src/lib/ostream-multiplex.c 2021-02-10 19:53:25 +0200 Timo Sirainen (e788a21) lib: array.h - Update array_foreach*() comments M src/lib/array.h 2021-02-10 19:49:00 +0200 Timo Sirainen (178a24d) lib: array.h - Require C99 We're already requiring C99 elsewhere. M src/lib/array.h 2021-05-05 17:49:33 +0300 Timo Sirainen (50957d3) lib: array_foreach_elem() - Don't allow using it for sizes larger than a pointer Dovecot doesn't use any types larger than the pointer size (e.g. long double). Restricting it to max pointer size might prevent inefficient usage. M src/lib/array.h M src/lib/test-array.c 2021-02-10 19:47:13 +0200 Timo Sirainen (db41d8a) lib: array_foreach_elem() - Small optimization Avoid having to recalculate the end of the array after each loop. This makes the resulting assembler output similar to array_foreach(). M src/lib/array.h 2021-04-01 17:24:10 +0300 Timo Sirainen (c9fa200) lib-index: Try harder to open index with MAIL_INDEX_OPEN_FLAG_READONLY The readonly-flag is used when rebuilding index or dumping indexes. In both cases it's better to try to open the index as best as possible, since fsck isn't allowed. M src/lib-index/mail-index-map-read.c M src/lib-index/mail-index.c 2021-05-06 15:17:05 -0400 Josef 'Jeff' Sipek (ef61bea) lib-lua: Remove obsolete threading check We support multiple lua thread as long as they are created using the dlua_script_new_thread() helper. M src/lib-lua/dlua-script.c 2021-05-05 16:47:43 +0300 Timo Sirainen (3d2a582) dict-ldap: Fix calling dict_wait() on async lookup The dict_wait() could have waited forever because nothing stopped the ioloop. Also fix calling the callback with the proper active ioloop. M src/lib-dict-backend/dict-ldap.c 2021-05-05 16:41:21 +0300 Timo Sirainen (8e730ab) dict-redis: dict-client: Use the proper active ioloop while calling commit() callbacks If the callbacks did any IO/timeout changes, they would have gone to a wrong ioloop. This would have caused a warning about IO/timeout leak though, so it doesn't seem like there were such code paths currently. M src/lib-dict/dict-redis.c 2021-05-05 16:37:52 +0300 Timo Sirainen (d559180) dict-memcached-ascii: Assert-crash if dict ioloop gets any unexpected IOs or timeouts M src/lib-dict/dict-memcached-ascii.c 2021-03-22 17:05:24 +0200 Timo Sirainen (92c30d0) dict-client: Assert-crash if dict ioloop gets any unexpected IOs or timeouts M src/lib-dict/dict-client.c 2021-03-22 16:50:04 +0200 Timo Sirainen (ad5d1ee) dict-client: Use the proper active ioloop while calling commit() and lookup() callbacks If the callbacks did any IO/timeout changes, they would have gone to a wrong ioloop. M src/lib-dict/dict-client.c 2021-03-22 16:59:09 +0200 Timo Sirainen (4c40609) lib: Add io_loop_is_empty() M src/lib/ioloop.c M src/lib/ioloop.h M src/lib/test-ioloop.c 2021-05-05 11:19:24 +0300 Timo Sirainen (49b2183) stats: Truncate field values to 1000 bytes with log exporter This attempts to prevent log lines from growing longer than 4 kB, which causes them to wrap. M src/stats/event-exporter-fmt-json.c M src/stats/event-exporter-fmt-tab-text.c M src/stats/stats-metrics.c M src/stats/stats-metrics.h 2021-05-04 14:12:20 +0300 Timo Sirainen (2227e1a) imap: copy/move: Refresh source mailbox before copying/moving This way if another session had just expunged mails, the expunges will be noticed and the copy/move will abort early. M src/imap/cmd-copy.c 2021-04-29 15:49:00 +0300 Timo Sirainen (143b7c2) imap: move: Sync source mailbox between commits This way the messages are actually expunged from storage after the commit, not just requested to be expunged. Most importantly this means that if another session attempts to start moving the same messages it can be noticed earlier and one of the moves aborted. M src/imap/cmd-copy.c 2021-04-29 15:45:44 +0300 Timo Sirainen (739a46f) imap: Add imap_search_anyset_to_uidset() M src/imap/imap-search-args.c M src/imap/imap-search-args.h 2021-04-29 15:46:48 +0300 Timo Sirainen (3704149) imap: Allow imap_search_seqset_iter_init() to iterate over uidset also M src/imap/imap-search-args.c M src/imap/imap-search-args.h 2021-04-29 15:43:10 +0300 Timo Sirainen (3421ea2) lib-storage: Fix mailbox_get_uid_range() to handle "*" correctly Previously attempting to convert e.g. 1:* range would just assert-crash. There were no such callers currently though. M src/lib-storage/mailbox-get.c M src/lib-storage/test-mailbox-get.c 2021-04-29 15:39:29 +0300 Timo Sirainen (91ba53a) lib-storage: Always set struct mail.expunged Previously it was set only when some error noticed that there was a problem accessing the mail. Now this is set immediately in mail_set_seq(). This allows e.g. IMAP COPY/MOVE to abort when it encounters expunged mails. M src/lib-storage/index/index-mail.c 2021-05-04 02:19:07 +0200 Stephan Bosch (d9ce815) lib-program-client: test-program-client-unix - Add test for delayed disconnect after sending result code. M src/lib-program-client/test-program-client-unix.c 2021-05-03 23:54:11 +0200 Stephan Bosch (9599b0d) lib-program-client: test-program-client-net - Add test for delayed disconnect after sending result code. M src/lib-program-client/test-program-client-net.c 2021-05-04 02:12:21 +0200 Stephan Bosch (9af1bb3) lib-program-client: test-program-client-unix - Fix server-side argument count check. M src/lib-program-client/test-program-client-unix.c 2021-05-04 02:11:34 +0200 Stephan Bosch (982322a) lib-program-client: test-program-client-net - Fix server-side argument count check. M src/lib-program-client/test-program-client-net.c 2021-05-03 23:54:26 +0200 Stephan Bosch (1666e89) lib-program-client: program-client-remote - Fix result parsing in the istream. This fixes internal errors occurring when the parent stream is fully read before EOF is signaled. This was caused by the fact that the final bytes were not always reserved properly for parsing, so that these ended up being exposed to and eaten by the application. At the end, the result parsing code would be faced with no data, thereby causing an internal error to be returned by the calling application. This came to light as CI tests involving Sieve extprograms failed irregularly. This problem only occurs when a (slight) delay exists between the last data being sent and the connection being closed by the script service, making this hard to reproduce. It typically occurred only under high server load. M src/lib-program-client/program-client-remote.c 2021-05-03 23:51:36 +0200 Stephan Bosch (4d4b1a1) lib-program-client: program-client-remote - Fix error handling of istream. These days, input streams also set eof upon error, making the existing code path wrong. M src/lib-program-client/program-client-remote.c 2021-05-04 01:46:22 +0200 Stephan Bosch (0ffc146) lib-program-client: program-client-remote - Add proper error and debug logging for result code parsing. M src/lib-program-client/program-client-remote.c 2021-05-04 01:34:30 +0200 Stephan Bosch (17ca57d) lib-program-client: program-client-local - Add debug for child start problem. M src/lib-program-client/program-client-local.c 2021-05-03 23:49:11 +0200 Stephan Bosch (ca34fd9) lib-program-client: Reformat test-program-client-unix.c. M src/lib-program-client/test-program-client-unix.c 2021-05-03 23:43:47 +0200 Stephan Bosch (e04a83a) lib-program-client: Reformat test-program-client-net.c. M src/lib-program-client/test-program-client-net.c 2021-05-03 23:35:38 +0200 Stephan Bosch (cfb3944) lib-program-client: Reformat program-client-remote.c. M src/lib-program-client/program-client-remote.c 2021-04-22 12:07:12 +0300 Timo Sirainen (159e078) lib-test: Convert test_assert()s to fatal asserts when running static analyzer This avoids unnecessary warnings about unit tests crashing when test_assert()s fail. The warnings are correct, but it's a bit unnecessary to write the failure code paths that nicely. M src/lib-test/test-common.c M src/lib-test/test-common.h 2021-04-26 14:14:45 +0300 Timo Sirainen (e71b889) lib: Perform most of the event logging within data stack frame M src/lib/event-log.c M src/lib/test-event-log.c 2021-04-26 14:13:09 +0300 Timo Sirainen (7fae81d) lib-storage: Add data stack frames to mail_set_*() This can reduce data stack usage significantly with mail thread building. M src/lib-storage/mail.c 2021-03-31 16:26:00 +0300 Timo Sirainen (6a058be) lib: data-stack - If frame doesn't change current block, no blocks need to be freed This is a micro-optimization to t_pop() to avoid an extra if-check. M src/lib/data-stack.c 2021-03-31 16:22:24 +0300 Timo Sirainen (68ecc20) lib: data-stack - Use stack_block.left_lowwater only with DEBUG M src/lib/data-stack.c 2021-03-31 16:17:30 +0300 Timo Sirainen (e8942f8) lib: Remove data_stack_set_clean_after_pop() M src/lib/data-stack.c M src/lib/data-stack.h M src/lib/test-data-stack.c 2021-03-31 16:04:47 +0300 Timo Sirainen (62fa24f) lib: data-stack - Move frame memory allocation inside data stack block M src/lib/data-stack.c M src/lib/test-data-stack.c 2021-03-31 14:25:47 +0300 Timo Sirainen (158dfdf) lib: data-stack - Replace stack_frame_block with a single stack_frame This simplifies the code at the cost of more memory allocations. However, this will be fixed by the following commit. M src/lib/data-stack.c 2020-11-16 20:54:20 +0200 Timo Sirainen (0e3652c) lib: data-stack - Add data_stack_grow event This is now always enabled, not just in debug builds. M src/lib/data-stack.c M src/lib/data-stack.h M src/lib/lib.c M src/lib/test-data-stack.c 2021-03-31 14:40:12 +0300 Timo Sirainen (aff9293) lib: t_get_bytes_available() - Fix return value when current_block is almost full M src/lib/data-stack.c M src/lib/test-data-stack.c 2020-11-16 14:56:50 +0200 Timo Sirainen (f520a62) lib-settings: settings_check() - Avoid growing data stack unnecessarily Each check_func() could have increased data stack usage. Add it inside a data stack frame to avoid it growing unnecessarily large. M src/lib-settings/settings-parser.c 2020-11-16 14:58:08 +0200 Timo Sirainen (df4f703) lib: module_dir_*load*(): Avoid growing data stack when checking duplicates This check could have unnecessarily grown data stack size when many plugins are installed. M src/lib/module-dir.c 2020-11-16 19:37:26 +0200 Timo Sirainen (a7ccda0) global: Use T_END_PASS_STR() where possible M src/config/config-parser.c M src/lib-fs/fs-api.c M src/lib-imap/imap-bodystructure.c M src/lib-mail/mail-user-hash.c M src/lib-mail/message-search.c M src/lib-settings/settings-parser.c M src/lib-sql/driver-cassandra.c M src/lib-sql/driver-sqlpool.c 2020-11-16 18:23:59 +0200 Timo Sirainen (6f68dc6) lib: data-stack - Add t_pop_pass_str() and T_END_PASS_STR[_IF]() This simplifies passing error strings out of stack frames. For example: const char *error; T_BEGIN { ... if (ret < 0) error = t_strdup_printf("foo() failed: %m"); } T_END_PASS_STR_IF(ret < 0, &error); // error is still valid M src/lib/data-stack.c M src/lib/data-stack.h M src/lib/test-data-stack.c 2021-03-31 11:56:10 +0300 Timo Sirainen (b5b15e1) lib: Add data_stack_frame_contains() M src/lib/data-stack.c M src/lib/data-stack.h 2021-03-31 13:19:00 +0300 Timo Sirainen (f0180e7) lib: Add data_stack_get_alloc_size() M src/lib/data-stack.c M src/lib/data-stack.h 2021-03-31 12:59:29 +0300 Timo Sirainen (b2bb139) lib: Fix data_stack_get_used_size() to return correct size It only included the last allocated block's used size. M src/lib/data-stack.c 2021-03-31 12:52:47 +0300 Timo Sirainen (1f021a2) lib: data-stack - Don't set stack_block.next=NULL after mem_block_alloc() already did it M src/lib/data-stack.c 2021-03-31 12:51:34 +0300 Timo Sirainen (7b1c81b) lib: data-stack - mem_block_alloc() - Set stack_block.left to final value immediately There's no need to first set it to 0 and then have the caller change it again. M src/lib/data-stack.c 2020-11-17 00:36:27 +0200 Timo Sirainen (6c37802) lib: data-stack - Remove unused_frame_blocks It's not that expensive to keep allocating them as needed, and it's a potential waste of memory to keep them around. M src/lib/data-stack.c 2020-11-17 00:32:45 +0200 Timo Sirainen (2da2108) lib: data-stack - Don't keep largest unused block in memory It's not that expensive to allocate it again, but it might be expensive to keep allocated a block that became huge due to a bug. The huge block could be just wasting memory without ever being used again. M src/lib/data-stack.c 2020-11-16 18:09:44 +0200 Timo Sirainen (59ff832) lib: data-stack - Add unit test for data_stack_set_clean_after_pop() M src/lib/test-data-stack.c 2020-11-16 18:08:57 +0200 Timo Sirainen (8d5c1b2) lib: data-stack - Rename variables in clean_after_pop handling These new variables make more sense than the old ones. M src/lib/data-stack.c 2020-11-16 18:06:55 +0200 Timo Sirainen (c702072) lib: data-stack - Rename lowwater to left_lowwater This describes its behavior better. Also add a comment explaining what exactly it is. M src/lib/data-stack.c 2020-11-16 17:57:39 +0200 Timo Sirainen (8a37fc6) lib: data-stack - Rename block_space_used[] to block_space_left[] This describes its behavior better. Also add a comment explaining what exactly it is. M src/lib/data-stack.c 2020-11-16 15:25:36 +0200 Timo Sirainen (d3e36b2) lib: data-stack - Use INITIAL_STACK_SIZE without growing it to nearest power M src/lib/data-stack.c 2021-03-31 13:13:22 +0300 Timo Sirainen (dda74fe) global: Never use t_push(NULL) A non-NULL name is expected by the debug logging. M src/lib-master/master-service.c M src/lib/data-stack.c 2021-03-31 13:11:16 +0300 Timo Sirainen (afe3adb) lib: Recalculate events' debug logging state after replacing event filters M src/lib/event-log.c M src/lib/event-log.h M src/lib/lib-event-private.h M src/lib/lib-event.c 2021-05-03 19:40:23 +0300 Timo Sirainen (10dbf46) lib-index: test-mail-index-sync-ext - Fix memory leak M src/lib-index/test-mail-index-sync-ext.c 2021-04-12 22:43:57 +0200 Stephan Bosch (02de37f) lib-smtp: smtp-server-transaction - Make sure current data command is recorded as soon as possible. This prevents crashes when replies are sent early. This also prevents crashes when invalid DATA commands are sent in succession. M src/lib-smtp/smtp-server-cmd-data.c M src/lib-smtp/smtp-server-recipient.c M src/lib-smtp/smtp-server-transaction.c M src/lib-smtp/test-smtp-server-errors.c 2021-04-12 22:50:48 +0200 Stephan Bosch (b9d4136) lib-smtp: smtp-server-transaction - Rename smtp_server_transaction_last_data() to smtp_server_transaction_data_command(). M src/lib-smtp/smtp-server-cmd-data.c M src/lib-smtp/smtp-server-private.h M src/lib-smtp/smtp-server-transaction.c 2021-04-12 22:46:17 +0200 Stephan Bosch (b98ebb2) lib-smtp: smtp-server-recipient - Rename smtp_server_recipient_last_data() to smtp_server_recipient_data_command(). M src/lib-smtp/smtp-server-private.h M src/lib-smtp/smtp-server-recipient.c M src/lib-smtp/smtp-server-transaction.c 2021-05-03 14:07:44 +0300 Timo Sirainen (635fb84) login-common: Add client.list_type to better track which linked list client belongs to Add asserts to make sure the client is always in the expected list. M src/login-common/client-common.c M src/login-common/client-common.h 2021-04-23 16:43:36 +0300 Timo Sirainen (e619fe5) login-common: Fix handling destroyed_clients linked list The client needs to be removed from destroyed_clients linked list before it's added to client_fd_proxies linked list. Broken by 1c622cdbe08df2f642e28923c39894516143ae2a M src/login-common/client-common.c 2021-02-06 20:11:14 +0200 Timo Sirainen (1992a4d) lib-index: test-mail-index-sync-ext - Fix to link with the full libindex M src/lib-index/Makefile.am M src/lib-index/test-mail-index-sync-ext.c 2021-02-02 17:41:28 +0200 Timo Sirainen (37a5735) lib-index: Add/update comments related to cloning maps M src/lib-index/mail-index-map.c M src/lib-index/mail-index-private.h M src/lib-index/mail-index-sync-update.c 2021-02-02 17:25:33 +0200 Timo Sirainen (b249bb7) lib-index: Don't call mail_index_modseq_sync_map_replaced() if nothing changed M src/lib-index/mail-index-sync-update.c 2021-02-02 16:13:50 +0200 Timo Sirainen (e274d91) lib-index: Add comments to struct mail_transaction_log and related M src/lib-index/mail-transaction-log-private.h 2021-02-02 16:13:01 +0200 Timo Sirainen (4c74469) lib-index: Rename MAIL_TRANSACTION_LOG_LOCK_CHANGE_TIMEOUT to .._DOTLOCK_.. M src/lib-index/mail-transaction-log-private.h M src/lib-index/mail-transaction-log.c 2021-02-02 16:02:58 +0200 Timo Sirainen (f309a14) lib-index: Rename mail_transaction_log_file.lock_created to lock_create_time M src/lib-index/mail-transaction-log-file.c M src/lib-index/mail-transaction-log-private.h M src/lib-index/mail-transaction-log.c 2021-02-02 15:59:34 +0200 Timo Sirainen (7eb8a13) lib-index: Move mail_transaction_log_file_get_modseq_next_offset() to its own file This nicely isolates the modseq_cache code to its own file. M src/lib-index/Makefile.am M src/lib-index/mail-transaction-log-file.c A src/lib-index/mail-transaction-log-modseq.c 2021-02-02 15:26:08 +0200 Timo Sirainen (52fb040) lib-index: Remove unused mail_transaction_log_file.saved_tail_sync_offset Shrinking tail_offsets have been ignored since 082e82792b8ac33ad42beac510441b37a3c50737 M src/lib-index/mail-transaction-log-file.c M src/lib-index/mail-transaction-log-private.h 2021-02-02 15:24:53 +0200 Timo Sirainen (f2a5850) lib-index: Rename mail_transaction_log_file.saved_tail_offset to last_read_hdr_tail_offset This describes better what it's actually used for.