2019-03-14 10:54:30 -0600 Michael Slusarz (06e5b2f) core: Update README.md to fix broken RFC links M README.md 2019-03-08 12:34:29 +0200 Timo Sirainen (fb40704) lib: Panic on most epoll_ctl() failures Anything except ENOSPC or ENOMEM points to a bug in code. Getting core dump from those helps debugging. M src/lib/ioloop-epoll.c 2019-03-01 10:57:40 +0200 Sergey Kitov (9b9d746) auth: Add client_secret setting M src/auth/db-oauth2.c M src/lib-oauth2/oauth2-passwd-grant.c 2019-03-01 10:57:22 +0200 Sergey Kitov (d0b9cf0) auth: Fix for processing oauth2 responses with 4xx HTTP status. M src/auth/db-oauth2.c 2018-12-09 21:18:22 +0100 Stephan Bosch (543bed6) lib-oauth2: Provide a unit test for the JSON response payload parser. M src/lib-oauth2/Makefile.am A src/lib-oauth2/test-oauth2-json.c 2018-12-09 21:14:29 +0100 Stephan Bosch (dce9f26) lib-oauth2: Fix assert panic occurring while skipping ignored object and array fields. Fixed by using json_parse_skip(), rather than json_parse_skip_next(). The latter is not suitable for skipping a value that is already partially parsed by json_parse_next(). Panic was: Panic: file json-parser.c: line 668 (json_parse_skip_next): assertion failed: (parser->state == JSON_STATE_OBJECT_COLON || parser->state == JSON_STATE_OBJECT_VALUE || parser->state == JSON_STATE_ARRAY_VALUE || parser->state == JSON_STATE_ARRAY_NEXT) M src/lib-oauth2/oauth2.c 2018-12-09 21:08:53 +0100 Stephan Bosch (679286c) lib-oauth2: Fix asynchronous parsing of JSON response payload. The problem was caused by the fact that req->field_name was reset in the beginning of oauth2_parse_json(), which is continuously called when more payload can be read from the input stream. This leads to corruption of the parser state machine each time parsing is continued. To fix this issue, the field_name is now reset only when the parsing commences. M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c M src/lib-oauth2/oauth2.c 2018-12-09 20:27:10 +0100 Stephan Bosch (2ba3d8a) lib: json-parser: Add unit test on skipping various object member fields. This both tests skipping fields based on their member key and based on their value types; i.e., after calling json_parse_next() for the object member value. M src/lib/test-json-parser.c 2018-12-09 20:24:28 +0100 Stephan Bosch (dcc5ac2) lib: json-parser: Add support for skipping a value that is already partially parsed. Adds json_parse_skip(), which skips the remainder of the value parsed earlier by json_parse_next(). This is needed when values need to be skipped by their value type rather than their object member key. M src/lib/json-parser.c M src/lib/json-parser.h 2019-02-27 15:25:06 +0200 Aki Tuomi (ea4a6a3) lib-storage: pop3c - Copy SSL settings correctly When attempting to use pop3c with immediate SSL, it would crash due to invalid memory access during connection setup. Also the SSL mode is not copied so SSL handshake is not attempted at later stage. Was broken in 01435c38e7 and ebcf7d6c92 M src/lib-storage/index/pop3c/pop3c-client.c 2019-02-27 15:39:34 +0200 Sergey Kitov (b130bc9) auth: Fix processing of wrong password for oauth2 password grant M src/auth/db-oauth2.c 2019-02-26 03:26:00 +0200 Stephan Bosch (46759cf) doc: Add Solr 7.7 configuration files The schema for 7.7 is based on work by Daniel Miller . M doc/Makefile.am A doc/solr-config-7.7.0.xml A doc/solr-schema-7.7.0.xml 2019-02-26 03:07:25 +0200 Martti Rannanjärvi (fb5a10b) fts-solr: Add rawlog support M src/plugins/fts-solr/fts-solr-plugin.c M src/plugins/fts-solr/fts-solr-plugin.h M src/plugins/fts-solr/solr-connection.c 2019-02-25 19:51:27 +0200 Martti Rannanjärvi (06ee92e) fts-solr: Use fts_solr_settings struct in solr_connection_init() M src/plugins/fts-solr/fts-backend-solr-old.c M src/plugins/fts-solr/fts-backend-solr.c M src/plugins/fts-solr/solr-connection.c M src/plugins/fts-solr/solr-connection.h 2019-02-25 16:40:46 +0200 Aki Tuomi (ba49949) doveadm: server-connection - Remove redundant ssl verification Certificate validation is done by lib-ssl-iostream already, don't do it here again. Fixes ssl_client_require_valid_cert=no for doveadm sync M src/doveadm/server-connection.c 2019-02-25 16:46:59 +0200 Aki Tuomi (f4e9bff) doveadm: Make sure SSL settings are always available M src/doveadm/doveadm-settings.c M src/doveadm/doveadm-settings.h M src/doveadm/doveadm.c M src/doveadm/main.c 2019-02-25 18:07:45 +0200 Aki Tuomi (02da1c3) lib-ssl-iostream: Add comment about using ssl_iostream_check_cert_validity M src/lib-ssl-iostream/iostream-ssl.h 2019-02-25 17:22:57 +0200 Aki Tuomi (1bf07f3) lib-ssl-iostream: Add comment about verifying certs in callbacks M src/lib-ssl-iostream/iostream-ssl.h 2019-02-25 17:44:09 +0200 Aki Tuomi (f25fb87) lib-ssl-iostream: Call ssl_iostream_check_cert_validity as default Unless callback is specified, call ssl_iostream_check_cert_validity instead of ssl_iostream_cert_match_name to make sure we perform same checks consistently. M src/lib-ssl-iostream/iostream-openssl.c 2019-02-17 23:02:16 +0200 Aki Tuomi (1ca0b11) doveadm-server: Load SSL settings Otherwise operations that might use ssl can lead into invalid memory access. M src/doveadm/main.c 2019-02-14 16:03:02 +0200 Sergey Kitov (417c53e) auth: Add caching to passdb-oauth. M src/auth/db-oauth2.c M src/auth/db-oauth2.h M src/auth/passdb-oauth2.c 2019-02-05 09:43:09 +0200 Sergey Kitov (d8b1886) auth: Add support for oauth2 password grant M src/auth/db-oauth2.c 2019-02-05 09:45:07 +0200 Sergey Kitov (e9b1be3) lib-oauth2: Implement password grant authentication. M src/lib-oauth2/Makefile.am A src/lib-oauth2/oauth2-passwd-grant.c M src/lib-oauth2/oauth2-private.h M src/lib-oauth2/oauth2.h 2019-01-31 10:36:49 +0200 Sergey Kitov (671eee1) lib-oauth2: Take http_client_request_url_str in use for oauth2 requests. M src/lib-oauth2/oauth2-introspect.c M src/lib-oauth2/oauth2-refresh.c M src/lib-oauth2/oauth2-token-validate.c 2019-01-31 10:31:43 +0200 Sergey Kitov (25ed151) lib-http: Expose origin_url of the struct http_client_request M src/lib-http/http-client-request.c M src/lib-http/http-client.h 2019-02-13 22:21:21 +0100 Stephan Bosch (fe7a7d6) submission-login: Only overwrite XCLIENT fields in the client when a value is assigned. Before, omitted fields in the XCLIENT command would cause the values in the client to be reset to the equivalent of zero. M src/submission-login/client.c 2019-02-08 20:47:42 +0200 Aki Tuomi (fd50e6f) lib-smtp: Mark default as unreached in smtp_client_command_abort Satisfies static analyzers M src/lib-smtp/smtp-client-command.c 2019-02-07 02:37:27 +0100 Stephan Bosch (bb7d90d) lib-smtp: smtp-client-command - Avoid calling the callback for the DATA command during submission. This causes a race condition in which the command object is already freed when it is returned from smtp_client_command_data_submit(). This scenario occurs when reading data for the first BDAT command fails. M src/lib-smtp/smtp-client-command.c M src/lib-smtp/smtp-client-connection.c M src/lib-smtp/smtp-client-private.h 2019-02-06 20:54:26 +0100 Stephan Bosch (630453b) lib-smtp: smtp-client - Send correct size value for BDAT command when the data lacks CR. The addition of CR was ignored in the size specification because the original unaltered stream was used for the size calculations. M src/lib-smtp/smtp-client-command.c 2019-01-22 22:45:33 +0200 Timo Sirainen (f020a33) lib: istreams - Don't lose IO pending state when unsetting and setting io This makes sure that the pending state stays even after io_remove() when io_add_istream() is again called. M src/lib/istream.c 2019-01-22 12:59:57 +0200 Timo Sirainen (b197576) lib: Fix i_stream_set_input_pending() when IO is set later After i_stream_set_io() is called to set the IO, it should already be marked as pending. This fixes at least running imaptest with SSL. M src/lib/istream-private.h M src/lib/istream.c 2019-01-22 22:43:53 +0200 Timo Sirainen (2779173) lib: Add io_is_pending() M src/lib/ioloop.c M src/lib/ioloop.h 2019-01-23 17:22:27 +0200 Timo Sirainen (f6492f5) lib-index: Add mail_index_append_finish_uids_full() M src/lib-index/mail-index-transaction-update.c M src/lib-index/mail-index.h 2019-01-23 17:29:22 +0200 Timo Sirainen (1c48505) lib-index: mail_index_append_finish_uids() cleanup: remove unnecessary if check It was pretty confusing, and it was always TRUE. M src/lib-index/mail-index-transaction-update.c 2018-11-15 14:47:32 +0200 Aki Tuomi (b9b46fb) doveadm: Use doveadm_get_ssl_settings M src/doveadm/doveadm-fs.c M src/doveadm/server-connection.c 2018-11-15 14:46:44 +0200 Aki Tuomi (162da60) doveadm: dsync - use mail_storage_settings_init_ssl_client_settings M src/doveadm/doveadm-dsync.c 2018-11-15 14:42:28 +0200 Aki Tuomi (9c58858) lib-storage: mail-user - Use mail_storage_settings_init_ssl_client_settings M src/lib-storage/mail-user.c 2018-11-15 14:40:46 +0200 Aki Tuomi (da77d03) mail-storage: Add mail_storage_settings_init_ssl_client_settings Simplifies following commits M src/lib-storage/mail-storage-settings.c M src/lib-storage/mail-storage-settings.h 2018-11-15 14:35:36 +0200 Aki Tuomi (18b16b6) doveadm: Use master service SSL settings M src/doveadm/doveadm-settings.c M src/doveadm/doveadm-settings.h M src/doveadm/doveadm.c M src/doveadm/main.c 2019-01-22 22:06:38 +0100 Stephan Bosch (0682329) lib-smtp: client: Fix dead assignment in smtp_client_command_pipeline_is_open(). Found by scan-build. M src/lib-smtp/smtp-client-command.c 2018-12-09 12:13:59 +0100 Stephan Bosch (571631d) lib-smtp: command: Move main loop from sub-function to smtp_client_command_send_more() itself. This reduces code indent in smtp_client_command_do_send_more() (the sub-function) and it turns the inifite for loop into a nice conditional while loop. M src/lib-smtp/smtp-client-command.c 2018-11-11 23:32:15 +0100 Stephan Bosch (0b4a81d) lib-smtp: test-smtp-client-errors: Test early DATA command success and error replies. Early success for the DATA command is treated as a protocol error, while early failure is allowed. Both situations are tested in a new scenario for the test-smtp-client-errors unit test. M src/lib-smtp/test-smtp-client-errors.c 2018-11-11 23:25:50 +0100 Stephan Bosch (8b04485) lib-smtp: client: Fix handling of non-blocking command payload stream. By inference, this fixes the handling of non-blocking transaction payload as well. No io was created when the payload stream returned no data. M src/lib-smtp/smtp-client-command.c M src/lib-smtp/smtp-client-connection.c M src/lib-smtp/smtp-client-private.h 2018-11-11 20:30:25 +0100 Stephan Bosch (7fff5b2) lib-smtp: test-smtp-client-errors: Add test scenario for premature success replies. Such replies are sent immediately along with the reply of the previous command. So, the reply is sent before the corresponding command is even submitted. This tests whether the client handles this erroneous situation correctly. M src/lib-smtp/test-smtp-client-errors.c 2018-08-16 22:34:53 +0200 Stephan Bosch (ff439e9) lib-smtp: test-smtp-payload: Add option to test payload exchange with small socket buffers. This is not part of the normal `make check` procedure, since using small socket buffers makes the test extremely slow. M src/lib-smtp/test-smtp-payload.c 2018-08-15 18:29:11 +0200 Stephan Bosch (0de6654) lib-smtp: client: Allow receiving replies before command data stream is sent completely. This avoids unnecessary problems with servers that reply somewhat early to DATA and BDAT commands. For one, early failure replies are now handled properly. Also, race conditions at the client between sending the closing CRLF.CRLF and receiving the DATA reply are no longer causing problems. M src/lib-smtp/smtp-client-command.c M src/lib-smtp/smtp-client-connection.c M src/lib-smtp/smtp-client-private.h 2018-12-09 11:34:56 +0100 Stephan Bosch (4c4dad9) lib-smtp: client: Put moving a command from the queue to the wait list in a separate function. M src/lib-smtp/smtp-client-command.c 2018-08-16 22:15:36 +0200 Stephan Bosch (9636d0d) lib-smtp: client: Put determining the status of the command pipeline in a separate function. M src/lib-smtp/smtp-client-command.c 2018-08-16 22:07:08 +0200 Stephan Bosch (48a4a6d) lib-smtp: client: Put sending the command line in a separate function. M src/lib-smtp/smtp-client-command.c 2019-01-21 22:21:03 +0100 Stephan Bosch (92495b9) lib-smtp: client: Don't put connection in TRANSACTION state unless there's a transaction. Fixes hang occurring when connection is ready before transaction is started. M src/lib-smtp/smtp-client-connection.c 2019-01-21 10:50:24 +0200 Martti Rannanjärvi (b14b713) quota: Rename quota_set_resource() error_r to client_error_r Don't pass on the error from dict_init() to client, though. M src/plugins/imap-quota/imap-quota-plugin.c M src/plugins/quota/quota.c M src/plugins/quota/quota.h 2019-01-21 13:01:27 +0200 Martti Rannanjärvi (6c788a5) imap-acl: Rename error_r sent to client as client_error_r M src/plugins/imap-acl/imap-acl-plugin.c 2019-01-21 13:00:09 +0200 Martti Rannanjärvi (6c4d251) lib-imap-urlauth: Rename error_r sent to clients as client_error_r M src/lib-imap-urlauth/imap-urlauth-backend.c M src/lib-imap-urlauth/imap-urlauth-backend.h M src/lib-imap-urlauth/imap-urlauth.c M src/lib-imap-urlauth/imap-urlauth.h 2019-01-21 12:59:45 +0200 Martti Rannanjärvi (722bac7) lib-imap-storage: Rename error_r sent to clients as client_error_r M src/lib-imap-storage/imap-metadata.c M src/lib-imap-storage/imap-metadata.h M src/lib-imap-storage/imap-msgpart-url.c M src/lib-imap-storage/imap-msgpart-url.h 2019-01-21 12:41:20 +0200 Martti Rannanjärvi (0585dba) imap,lib-storage: Rename error_r sent to clients as client_error_r M src/imap/cmd-append.c M src/imap/cmd-delete.c M src/imap/cmd-fetch.c M src/imap/cmd-genurlauth.c M src/imap/cmd-getmetadata.c M src/imap/cmd-notify.c M src/imap/cmd-select.c M src/imap/cmd-setmetadata.c M src/imap/imap-client.c M src/imap/imap-client.h M src/imap/imap-commands-util.c M src/imap/imap-commands-util.h M src/imap/imap-fetch.c M src/imap/imap-fetch.h M src/imap/imap-search-args.c M src/imap/imap-search.c M src/lib-storage/mail-search-build.c M src/lib-storage/mail-search-build.h 2018-09-27 23:00:22 +0200 Anton Dollmaier (356d276) submission-login: proxy: Fix omission of spaces between XCLIENT command parameters. It would send for example: > XCLIENT ADDR=10.0.1.2PORT=39074 The other end will obviously not accept this. -- Commit message modified by Stephan Bosch M src/submission-login/submission-proxy.c 2018-09-08 20:54:54 +0200 Stephan Bosch (692119a) lib-smtp: client: BDAT command: Make sure the message contains CRLF consistently. Before, only messages sent using DATA command guaranteed consistent CRLF, because these are sent using o_stream_dot(), which does that internally. For the BDAT command, the message was sent as-is, which is not always accepted by MTAs. M src/lib-smtp/smtp-client-command.c 2018-10-26 12:15:45 +0200 Stephan Bosch (44964bc) lib-smtp: client: BDAT command: Ensure data stream max buffer size is appropriate when stream size is unknown. When stream size is unknown, the chunk size are determined by what can be buffered in the data input stream immediately. If it's maximum buffer size is (much) smaller than the maximum chunk size, the maximum chunk size is never achieved. M src/lib-smtp/smtp-client-command.c 2018-10-26 16:17:06 +0200 Stephan Bosch (587a534) lib-smtp: server: Fix forwarding a multi-line reply. A multi-line reply had the '-' on the first line stripped upon sending, which makes clients see two separate responses rather than just one. This was caused by the fact that forwarded replies had the last_line field not set properly, in which case the '-' was substituted on the first line, rather than the last. The fix makes a forwarded reply indistinguishable from a normally created reply by also allowing for amending the reply with additional lines using smtp_server_reply_add_text(). M src/lib-smtp/smtp-server-reply.c 2018-10-26 15:50:17 +0200 Stephan Bosch (d54721e) lib-smtp: test-smtp-reply: Test whether parsed valid replies can be written back to the original input. In some cases, the parser mangles the input a little to substitute invalid characters. In those cases, the expected output is stated explicitly. M src/lib-smtp/test-smtp-reply.c 2018-10-26 15:36:21 +0200 Stephan Bosch (2a87fdf) lib-smtp: Rename test-smtp-reply-parser.c to test-smtp-reply.c. Encoding tests will also be included, making the old name confusing. M src/lib-smtp/Makefile.am D src/lib-smtp/test-smtp-reply-parser.c A src/lib-smtp/test-smtp-reply.c 2019-01-14 18:28:42 -0500 Josef 'Jeff' Sipek (f32c658) global: hash_table_iterate_deinit(NULL) is a no-op @@ expression E; @@ - if (E != NULL) { - hash_table_iterate_deinit(&E); - } + hash_table_iterate_deinit(&E); M src/doveadm/dsync/dsync-brain.c 2019-01-14 18:27:12 -0500 Josef 'Jeff' Sipek (ddd6158) lib: hash_table_iterate_deinit(NULL) should be a no-op M src/lib/hash.c 2019-01-17 11:09:13 -0500 Josef 'Jeff' Sipek (5f48a23) global: hash_table_destroy(NULL) is a no-op @@ expression E; @@ - if (hash_table_is_created(E)) - hash_table_destroy(&E); + hash_table_destroy(&E); M src/auth/db-passwd-file.c M src/doveadm/dsync/dsync-mailbox-tree.c M src/lib-fts/fts-filter-stopwords.c M src/lib-master/master-service-settings-cache.c M src/lib-storage/index/maildir/maildir-uidlist.c M src/plugins/lazy-expunge/lazy-expunge-plugin.c 2019-01-14 17:52:26 +0200 Timo Sirainen (f644157) lib: hash_table_destroy(NULL) should be a no-op M src/lib/hash.c 2018-12-07 22:38:19 +0100 Stephan Bosch (b922e51) lib-http: client: Fix panic occurring at connection failure. In http_client_peer_connection_failed_pool(), all linked queues are notified about the connection failure through http_client_queue_connection_failure(). That function can internally link and unlink peers to the queue, including the calling one. This means that the peer->queues array can be modified while it is iterated in the array_foreach() loop. The problem is fixed by making a local copy of the peer->queues array. M src/lib-http/http-client-peer.c 2018-10-25 10:31:07 +0200 Stephan Bosch (df14938) lib-http: client: Fix handling of servers with several alternative IP addresses. This also addresses an assert failure occurring with parallel clients: Panic: file http-client-queue.c: line 518 (http_client_queue_connection_failure): assertion failed: (queue->cur_peer == peer) M src/lib-http/http-client-queue.c M src/lib-http/test-http-client-errors.c 2018-12-04 14:40:04 +0200 Aki Tuomi (8d78721) driver-mysql: Avoid double-closing MySQL connection Fixes double-free M src/lib-sql/driver-mysql.c 2018-11-14 15:44:14 +0200 Aki Tuomi (6bc371f) lib-storage: pop3c - Use mail_user_init_ssl_client_settings M src/lib-storage/index/pop3c/pop3c-client.c M src/lib-storage/index/pop3c/pop3c-client.h M src/lib-storage/index/pop3c/pop3c-storage.c 2018-11-14 15:43:58 +0200 Aki Tuomi (57e7f1b) lib-imap-client: Drop unused fields from settings M src/lib-imap-client/imapc-client.h 2018-11-14 15:24:41 +0200 Aki Tuomi (d8c7ec3) auth: passdb-imap - Adapt to imap-client API change M src/auth/passdb-imap.c 2018-11-14 15:24:18 +0200 Aki Tuomi (66771b9) lib-storage: imapc - Use mail_user_ssl_settings M src/lib-storage/index/imapc/imapc-storage.c 2018-11-14 15:21:36 +0200 Aki Tuomi (0372fd6) lib-imap-client: Use iostream ssl settings directly Prevents custom SSL CAs and certificate verification disabling until fixed by subsequent commits. M src/lib-imap-client/imapc-client.c M src/lib-imap-client/imapc-client.h M src/lib-imap-client/imapc-connection.c M src/lib-storage/index/imapc/Makefile.am M src/plugins/quota/Makefile.am 2018-11-14 14:05:24 +0200 Aki Tuomi (1748571) auth: Use master service ssl settings for http client in policy checks M src/auth/auth-policy.c M src/auth/main.c 2018-11-14 14:43:52 +0200 Aki Tuomi (143a1a3) lib-master: When duplicating SSL settings set empty values NULL Otherwise default CA is not used for client connections. Broken in 30dca954 M src/lib-master/master-service-ssl-settings.c 2018-11-09 09:54:38 +0200 Aki Tuomi (4eed33d) doc: Update example config about `ssl_client_require_valid_cert` M doc/example-config/conf.d/10-ssl.conf 2018-10-31 14:19:49 +0200 Aki Tuomi (a752b76) lib-storage: Copy all relevant TLS settings Not just ca path and dir M src/lib-storage/mail-user.c 2018-10-31 14:09:30 +0200 Aki Tuomi (90a5d98) lib-storage: Add all client ssl settings to mail storage settings M src/lib-master/master-service-ssl-settings.c M src/lib-storage/mail-storage-settings.c M src/lib-storage/mail-storage-settings.h 2018-10-31 14:20:36 +0200 Aki Tuomi (1fa72df) lib-master: Add new setting `ssl_client_require_valid_cert` This controls whether TLS certificates are verified for TLS CLIENT connections. M src/lib-master/master-service-ssl-settings.c M src/lib-master/master-service-ssl-settings.h 2018-07-24 09:51:39 +0300 Aki Tuomi (9da7d81) lib-ssl-iostream: If certificate check fails, suggest checking ssl ca settings M src/lib-ssl-iostream/iostream-openssl.c 2018-07-23 12:40:15 +0300 Aki Tuomi (89010c6) lib-ssl-iostream: Always fall back to default CAs for client contexts When creating a client context, we always try to load the default CA, if no CA settings have been provided. This makes it also possible to allow invalid certs without specifying ssl_client_ca settings, and also makes dovecot trust system store by default for outgoing connections. M src/lib-ssl-iostream/iostream-openssl-context.c 2016-03-15 09:21:49 +0200 Aki Tuomi (4a43b62) lib-iostream-ssl: Use default CA locations with client context If no CA settings are provided, fall back to default CA settings from openssl library. M src/lib-ssl-iostream/iostream-openssl-context.c 2019-03-04 16:44:30 +0000 Timo Sirainen (e5ecc88) NEWS: Add v2.3.5 (cherry picked from commit 622d67fdf0a51c5c3b0114603f62afc5651642a9) M NEWS 2019-02-25 20:55:03 +0200 Timo Sirainen (ae72b86) fs-posix: fs_read_stream() - Don't close file's fd This is especially important with newly created files, because they may still be accessed after reading. The next file access attempt after fs_read_stream() might cause the file to be recreated and crash. Fixes: Panic: file fs-posix.c: line 252 (fs_posix_create): assertion failed: (file->temp_path == NULL) M src/lib-fs/fs-posix.c 2019-02-19 10:49:37 +0200 Timo Sirainen (267c247) lib: test-istream-seekable - Add asserts to make sure blocking state changes at EOF M src/lib/test-istream-seekable.c 2019-02-19 10:22:43 +0200 Timo Sirainen (c2f6ae2) lib-storage: mail_get_*stream*() - Assert that returned streams are blocking Several callers already rely on them being blocking. Making these asserts explicit makes sure that any bugs are caught early. M src/lib-storage/mail.c 2019-02-19 10:17:45 +0200 Timo Sirainen (dd649c1) lib: istream-seekable - Change stream to be blocking=TRUE after reaching EOF After EOF is reached, the stream is now fully read into file or memory. read()s can no longer return 0, so blocking=TRUE can be used. Some callers were reusing the seekable stream in places that required blocking=TRUE. Fixes at least with imapsieve vnd.dovecot report extension: Panic: file ostream.c: line 427 (o_stream_nsend_istream): assertion failed: (instream->blocking) M src/lib/istream-seekable.c 2019-02-19 11:31:45 +0100 Stephan Bosch (9f809b6) lib-ssl-iostream: iostream-ssl-test - Update the test certificate to have very long expiry period. The old certificate expired after one year, which causes all kinds of unit test failures. M src/lib-ssl-iostream/iostream-ssl-test.c 2018-08-30 16:40:16 +0300 Timo Sirainen (28caca1) lib-http: Add assert to make sure http_client_init_shared(NULL, NULL) isn't called This should make scan-build happy. M src/lib-http/http-client.c 2018-12-27 14:13:15 +0100 Stephan Bosch (511f513) lib-smtp: client: Move connection to TRANSACTION state immediately when a transaction is started. Before, it waited until the actual start handler was called from timeout, but that causes a race condition with mtp_client_connection_abort_transaction(), which in turn causes an assert panic. Panic was: Panic: file smtp-client-connection.c: line 2153 (smtp_client_connection_abort_transaction): assertion failed: (conn->state != SMTP_CLIENT_CONNECTION_STATE_READY) M src/lib-smtp/smtp-client-connection.c 2018-11-11 20:41:18 +0100 Stephan Bosch (cd7ea3c) lib-smtp: client: Properly reset connection state upon reconnect. M src/lib-smtp/smtp-client-connection.c 2018-11-11 20:32:09 +0100 Stephan Bosch (615d91a) lib-smtp: client: connection: Prevent timeout leak for transaction start. Perform timeout management in a single place. Also, always start the next transaction only through a timeout. M src/lib-smtp/smtp-client-connection.c 2019-01-14 14:37:03 +0200 Aki Tuomi (808f073) m4: Fix moduledir behaviour This is mainly a fix for plugins that depend on dovecot.m4 M configure.ac M m4/dovecot.m4 2018-06-19 15:30:36 +0300 Phil Carmody (b5a86f0) m4/dovecot.m4: rename valgrind output file to hide it from certain tests Some lib-http tests use readdir() to create test cases, and sometimes object to the contents of test.out.$$. However, as lib-http is also sensitive to certain characters in the filenames of the files it uses, we can hide the valgrind output by chosing its filename to exclude it from the lib_http tests. Non-initial '~' is not known to cause any issues for either the shell or any known operating system, so is the safest of lib-http's 'dodgy' characters to use as the separator. Signed-off-by: Phil Carmody M m4/dovecot.m4 2018-08-29 14:57:45 +0300 Phil Carmody (a8d0871) m4/dovecot.m4 - Apply DRY principle to test output filename Define the name we will use for the file once, then just use that variable instead of using explicit repeatition. Signed-off-by: Phil Carmody M m4/dovecot.m4 2018-06-04 19:58:23 +0300 Phil Carmody (764ef7e) m4/dovecot.m4: run-test.sh - disable valgrind for individual tests OpenSSL doesn't like valgrind on my setup, so permit a local instalation to have a list of excluded binaries that won't use valgrind in make check. Signed-off-by: Phil Carmody M m4/dovecot.m4 2018-06-19 13:29:46 +0300 Phil Carmody (e1e7ff0) lib-http: increase pool sizes in tests Pool growth messages spam the test output, just dive in with a slightly larger default to shut them up. Only affects these individual tests, not any other users of the library. Signed-off-by: Phil Carmody M src/lib-http/test-http-payload.c M src/lib-http/test-http-server-errors.c 2018-06-19 13:28:12 +0300 Phil Carmody (18b8e66) lib-http: change default client/server pool sizes when using SSL SSL carries a lot of state with it, so just start with a bigger pool if we know we're using it. Signed-off-by: Phil Carmody M src/lib-http/http-client.c M src/lib-http/http-server.c 2018-06-14 08:51:37 +0300 Phil Carmody (4db5e93) lib-http: harden payload tests against dodgy filenames Tests use files from readdir() as input, but do no sanitation of the names,