[dovecot-cvs] dovecot/src/imap cmd-append.c,1.54,1.55
    cras at dovecot.org 
    cras at dovecot.org
       
    Sat Feb 12 11:36:25 EET 2005
    
        - Previous message: [dovecot-cvs] 
	dovecot/src/imap cmd-fetch.c, 1.26, 1.27 imap-fetch.c,
	1.36, 1.37 imap-fetch.h, 1.13, 1.14
 
        - Next message: [dovecot-cvs] dovecot/src/auth auth-client-connection.c, 1.34,
	1.35 auth-master-connection.c, 1.27,
	1.28 auth-request-handler-default.c, 1.3, 1.4 auth-request.c,
	1.7, 1.8 auth-request.h, 1.7, 1.8 db-ldap.c, 1.25,
	1.26 db-ldap.h, 1.12, 1.13 passdb-cache.c, 1.4,
	1.5 passdb-ldap.c, 1.22, 1.23 passdb-sql.c, 1.12,
	1.13 userdb-ldap.c, 1.26, 1.27 userdb-passdb.c, 1.2,
	1.3 userdb-passwd-file.c, 1.11, 1.12 userdb-passwd.c, 1.12,
	1.13 userdb-sql.c, 1.6, 1.7 userdb-static.c, 1.10,
	1.11 userdb-vpopmail.c, 1.13, 1.14 userdb.h, 1.19, 1.20
 
         -  Messages sorted by: 
              [ date ]
              [ thread ]
              [ subject ]
              [ author ]
         
 
       
    
  
Update of /var/lib/cvs/dovecot/src/imap
In directory talvi:/tmp/cvs-serv31894
Modified Files:
	cmd-append.c 
Log Message:
Don't crash if client disconnects in the middle of APPEND. The last fix
was incorrect.
Index: cmd-append.c
===================================================================
RCS file: /var/lib/cvs/dovecot/src/imap/cmd-append.c,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -d -r1.54 -r1.55
--- cmd-append.c	5 Feb 2005 18:07:26 -0000	1.54
+++ cmd-append.c	12 Feb 2005 09:36:23 -0000	1.55
@@ -306,9 +306,8 @@
 		i_stream_skip(ctx->input, size);
 	}
 
-	if (ctx->input->v_offset == ctx->msg_size || ctx->input->closed) {
+	if (ctx->input->v_offset == ctx->msg_size || client->input->closed) {
 		/* finished */
-		failed = ctx->input->closed;
 		i_stream_unref(ctx->input);
 		ctx->input = NULL;
 
@@ -323,6 +322,8 @@
 		} else if (mailbox_save_finish(ctx->save_ctx, NULL) < 0) {
 			failed = TRUE;
 			client_send_storage_error(cmd, ctx->storage);
+		} else {
+			failed = client->input->closed;
 		}
 		ctx->save_ctx = NULL;
 
    
    
        
	- Previous message: [dovecot-cvs] 
	dovecot/src/imap cmd-fetch.c, 1.26, 1.27 imap-fetch.c,
	1.36, 1.37 imap-fetch.h, 1.13, 1.14
 
	- Next message: [dovecot-cvs] dovecot/src/auth auth-client-connection.c, 1.34,
	1.35 auth-master-connection.c, 1.27,
	1.28 auth-request-handler-default.c, 1.3, 1.4 auth-request.c,
	1.7, 1.8 auth-request.h, 1.7, 1.8 db-ldap.c, 1.25,
	1.26 db-ldap.h, 1.12, 1.13 passdb-cache.c, 1.4,
	1.5 passdb-ldap.c, 1.22, 1.23 passdb-sql.c, 1.12,
	1.13 userdb-ldap.c, 1.26, 1.27 userdb-passdb.c, 1.2,
	1.3 userdb-passwd-file.c, 1.11, 1.12 userdb-passwd.c, 1.12,
	1.13 userdb-sql.c, 1.6, 1.7 userdb-static.c, 1.10,
	1.11 userdb-vpopmail.c, 1.13, 1.14 userdb.h, 1.19, 1.20
 
         -  Messages sorted by: 
              [ date ]
              [ thread ]
              [ subject ]
              [ author ]
         
 
       
More information about the dovecot-cvs
mailing list