[dovecot-cvs] dovecot: Removed some asserts that check if parameter is NULL. W...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot/rev/e383a6b4f4da
changeset: 5675:e383a6b4f4da
user:      Timo Sirainen <tss at iki.fi>
date:      Sun Jun 10 22:47:08 2007 +0300
description:
Removed some asserts that check if parameter is NULL. We can't check for all
errors anyway, so a segfault is a good enough "assert".

diffstat:

3 files changed, 12 deletions(-)
src/lib/istream.c  |    2 --
src/lib/network.c  |    8 --------
src/lib/strfuncs.c |    2 --

diffs (63 lines):

diff -r f55afcf1ff7d -r e383a6b4f4da src/lib/istream.c
--- a/src/lib/istream.c	Sun Jun 10 22:39:48 2007 +0300
+++ b/src/lib/istream.c	Sun Jun 10 22:47:08 2007 +0300
@@ -170,8 +170,6 @@ char *i_stream_next_line(struct istream 
 	char *ret_buf;
         size_t i;
 
-        i_assert(stream != NULL);
-
 	if (_stream->skip >= _stream->pos) {
 		stream->stream_errno = 0;
 		return NULL;
diff -r f55afcf1ff7d -r e383a6b4f4da src/lib/network.c
--- a/src/lib/network.c	Sun Jun 10 22:39:48 2007 +0300
+++ b/src/lib/network.c	Sun Jun 10 22:47:08 2007 +0300
@@ -236,8 +236,6 @@ int net_listen(const struct ip_addr *my_
 	union sockaddr_union so;
 	int ret, fd, opt = 1;
 	socklen_t len;
-
-	i_assert(port != NULL);
 
 	memset(&so, 0, sizeof(so));
 	sin_set_port(&so, *port);
@@ -364,7 +362,6 @@ ssize_t net_receive(int fd, void *buf, s
 	ssize_t ret;
 
 	i_assert(fd >= 0);
-	i_assert(buf != NULL);
 	i_assert(len <= SSIZE_T_MAX);
 
 	ret = read(fd, buf, len);
@@ -392,7 +389,6 @@ ssize_t net_transmit(int fd, const void 
         ssize_t ret;
 
 	i_assert(fd >= 0);
-	i_assert(data != NULL);
 	i_assert(len <= SSIZE_T_MAX);
 
 	ret = send(fd, data, len, 0);
@@ -417,10 +413,6 @@ int net_gethostbyname(const char *addr, 
 	struct hostent *hp;
 #endif
         int count;
-
-	i_assert(addr != NULL);
-	i_assert(ips != NULL);
-	i_assert(ips_count != NULL);
 
 	*ips = NULL;
         *ips_count = 0;
diff -r f55afcf1ff7d -r e383a6b4f4da src/lib/strfuncs.c
--- a/src/lib/strfuncs.c	Sun Jun 10 22:39:48 2007 +0300
+++ b/src/lib/strfuncs.c	Sun Jun 10 22:47:08 2007 +0300
@@ -194,8 +194,6 @@ char *p_strdup_vprintf(pool_t pool, cons
 	char *ret;
 	va_list args2;
 	size_t len;
-
-	i_assert(format != NULL);
 
 	if (!pool->datastack_pool)
 		t_push();