dovecot-1.2: IMAP: ESORT extension was implemented wrong.

dovecot at dovecot.org dovecot at dovecot.org
Fri Mar 20 18:28:49 EET 2009


details:   http://hg.dovecot.org/dovecot-1.2/rev/d6ef39b9e4cf
changeset: 8846:d6ef39b9e4cf
user:      Timo Sirainen <tss at iki.fi>
date:      Fri Mar 20 12:28:37 2009 -0400
description:
IMAP: ESORT extension was implemented wrong.

diffstat:

1 file changed, 8 insertions(+), 8 deletions(-)
src/imap/cmd-sort.c |   16 ++++++++--------

diffs (33 lines):

diff -r 78586322a1d2 -r d6ef39b9e4cf src/imap/cmd-sort.c
--- a/src/imap/cmd-sort.c	Thu Mar 19 20:34:58 2009 -0400
+++ b/src/imap/cmd-sort.c	Fri Mar 20 12:28:37 2009 -0400
@@ -102,6 +102,14 @@ bool cmd_sort(struct client_command_cont
 	if (!client_verify_open_mailbox(cmd))
 		return TRUE;
 
+	ctx = p_new(cmd->pool, struct imap_search_context, 1);
+	ctx->cmd = cmd;
+
+	if ((ret = cmd_search_parse_return_if_found(ctx, &args)) <= 0) {
+		/* error / waiting for unambiguity */
+		return ret < 0;
+	}
+
 	/* sort program */
 	if (args->type != IMAP_ARG_LIST) {
 		client_send_command_error(cmd, "Invalid sort argument.");
@@ -121,14 +129,6 @@ bool cmd_sort(struct client_command_cont
 	charset = IMAP_ARG_STR(args);
 	args++;
 
-	ctx = p_new(cmd->pool, struct imap_search_context, 1);
-	ctx->cmd = cmd;
-
-	if ((ret = cmd_search_parse_return_if_found(ctx, &args)) <= 0) {
-		/* error / waiting for unambiguity */
-		return ret < 0;
-	}
-
 	ret = imap_search_args_build(cmd, args, charset, &sargs);
 	if (ret <= 0)
 		return ret < 0;


More information about the dovecot-cvs mailing list