dovecot-1.2: crc32*() didn't return a standard CRC32 value.

dovecot at dovecot.org dovecot at dovecot.org
Sat Feb 6 01:21:03 EET 2010


details:   http://hg.dovecot.org/dovecot-1.2/rev/c24a31b423ed
changeset: 9538:c24a31b423ed
user:      Timo Sirainen <tss at iki.fi>
date:      Sat Feb 06 01:16:26 2010 +0200
description:
crc32*() didn't return a standard CRC32 value.

diffstat:

1 file changed, 6 insertions(+), 2 deletions(-)
src/lib/crc32.c |    8 ++++++--

diffs (38 lines):

diff -r fa1f5b4590d1 -r c24a31b423ed src/lib/crc32.c
--- a/src/lib/crc32.c	Fri Jan 29 16:42:02 2010 +0200
+++ b/src/lib/crc32.c	Sat Feb 06 01:16:26 2010 +0200
@@ -60,28 +60,32 @@ static uint32_t crc32tab[256] = {
 
 uint32_t crc32_data(const void *data, size_t size)
 {
-	return crc32_data_more((uint32_t)-1, data, size);
+	return crc32_data_more(0, data, size);
 }
 
 uint32_t crc32_data_more(uint32_t crc, const void *data, size_t size)
 {
 	const uint8_t *p = data, *end = p + size;
 
+	crc ^= 0xffffffff;
 	for (; p != end; p++)
 		crc = (crc >> 8) ^ crc32tab[((crc ^ *p) & 0xff)];
+	crc ^= 0xffffffff;
 	return crc;
 }
 
 uint32_t crc32_str(const char *str)
 {
-	return crc32_str_more((uint32_t)-1, str);
+	return crc32_str_more(0, str);
 }
 
 uint32_t crc32_str_more(uint32_t crc, const char *str)
 {
 	const uint8_t *p = (const uint8_t *)str;
 
+	crc ^= 0xffffffff;
 	for (; *p != '\0'; p++)
 		crc = (crc >> 8) ^ crc32tab[((crc ^ *p) & 0xff)];
+	crc ^= 0xffffffff;
 	return crc;
 }


More information about the dovecot-cvs mailing list