dovecot-2.0-sslstream: master: service_signal() reimplemented us...

dovecot at dovecot.org dovecot at dovecot.org
Sat Feb 13 02:55:14 EET 2010


details:   http://hg.dovecot.org/dovecot-2.0-sslstream/rev/33c448ce13f9
changeset: 10101:33c448ce13f9
user:      Timo Sirainen <tss at iki.fi>
date:      Mon Oct 19 18:34:00 2009 -0400
description:
master: service_signal() reimplemented using the service process linked list.

diffstat:

1 file changed, 4 insertions(+), 10 deletions(-)
src/master/service.c |   14 ++++----------

diffs (30 lines):

diff -r fea8122e1deb -r 33c448ce13f9 src/master/service.c
--- a/src/master/service.c	Mon Oct 19 18:31:46 2009 -0400
+++ b/src/master/service.c	Mon Oct 19 18:34:00 2009 -0400
@@ -447,22 +447,16 @@ int services_create(const struct master_
 
 void service_signal(struct service *service, int signo)
 {
-	struct hash_iterate_context *iter;
-	void *key, *value;
-
-	iter = hash_table_iterate_init(service_pids);
-	while (hash_table_iterate(iter, &key, &value)) {
-		struct service_process *process = value;
-
-		if (process->service != service)
-			continue;
+	struct service_process *process = service->processes;
+
+	for (; process != NULL; process = process->next) {
+		i_assert(process->service == service);
 
 		if (kill(process->pid, signo) < 0 && errno != ESRCH) {
 			service_error(service, "kill(%s, %d) failed: %m",
 				      dec2str(process->pid), signo);
 		}
 	}
-	hash_table_iterate_deinit(&iter);
 }
 
 static void services_kill_timeout(struct service_list *service_list)


More information about the dovecot-cvs mailing list