dovecot-1.2: Disabled stats istream. It's not used by default, a...

dovecot at dovecot.org dovecot at dovecot.org
Sun Feb 28 16:21:27 EET 2010


details:   http://hg.dovecot.org/dovecot-1.2/rev/6c9f2ed821df
changeset: 9546:6c9f2ed821df
user:      Timo Sirainen <tss at iki.fi>
date:      Sun Feb 28 16:20:46 2010 +0200
description:
Disabled stats istream. It's not used by default, and it breaks mbox.
When stats istream is enabled, reading a mail with a huge header from mbox
causes Dovecot to eat all CPU for a long time. This bug is fixed properly in
v2.0.

diffstat:

 src/lib-storage/index/index-mail.c |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (25 lines):

diff -r 93ee1f7bfeff -r 6c9f2ed821df src/lib-storage/index/index-mail.c
--- a/src/lib-storage/index/index-mail.c	Sat Feb 20 05:55:10 2010 +0200
+++ b/src/lib-storage/index/index-mail.c	Sun Feb 28 16:20:46 2010 +0200
@@ -824,17 +824,19 @@
 			   struct istream **stream_r)
 {
 	struct index_mail_data *data = &mail->data;
-	struct istream *input;
 	int ret;
 
+#if 0
 	if (!data->initialized_wrapper_stream && mail->mail.stats_track) {
+		struct istream *input;
+
 		input = i_stream_create_mail_stats_counter(&mail->mail,
 							   data->stream);
 		i_stream_unref(&data->stream);
 		data->stream = input;
 		data->initialized_wrapper_stream = TRUE;
 	}
-
+#endif
 	i_stream_set_destroy_callback(data->stream,
 				      index_mail_stream_destroy_callback, mail);
 


More information about the dovecot-cvs mailing list