dovecot-2.0: auth: Don't crash when auth requests timeout.

dovecot at dovecot.org dovecot at dovecot.org
Tue May 4 01:33:39 EEST 2010


details:   http://hg.dovecot.org/dovecot-2.0/rev/83b4020d1edf
changeset: 11254:83b4020d1edf
user:      Timo Sirainen <tss at iki.fi>
date:      Tue May 04 01:31:31 2010 +0300
description:
auth: Don't crash when auth requests timeout.

diffstat:

 src/auth/auth-request-handler.c |  4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diffs (14 lines):

diff -r da497a62cf44 -r 83b4020d1edf src/auth/auth-request-handler.c
--- a/src/auth/auth-request-handler.c	Mon May 03 18:15:15 2010 +0300
+++ b/src/auth/auth-request-handler.c	Tue May 04 01:31:31 2010 +0300
@@ -95,6 +95,10 @@
 {
 	i_assert(request->handler == handler);
 
+	/* if db lookup is stuck, this call doesn't actually free the auth
+	   request, so make sure we don't get back here. */
+	timeout_remove(&request->to_abort);
+
 	hash_table_remove(handler->requests, POINTER_CAST(request->id));
 	auth_request_unref(&request);
 }


More information about the dovecot-cvs mailing list