dovecot-2.0: director: Properly detect invalid command parameter...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.0/rev/a224997afefd
changeset: 12208:a224997afefd
user:      Timo Sirainen <tss at iki.fi>
date:      Thu Sep 30 15:33:56 2010 +0100
description:
director: Properly detect invalid command parameters in director<->director connections.
Found by Paul E. Black.

diffstat:

 src/director/director-connection.c |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (21 lines):

diff -r 10544c9cd8e8 -r a224997afefd src/director/director-connection.c
--- a/src/director/director-connection.c	Wed Sep 29 19:07:16 2010 +0100
+++ b/src/director/director-connection.c	Thu Sep 30 15:33:56 2010 +0100
@@ -603,7 +603,7 @@
 	unsigned int port, seq;
 
 	if (str_array_length(args) != 3 ||
-	    director_args_parse_ip_port(conn, args, &ip, &port) < 0 ||
+	    !director_args_parse_ip_port(conn, args, &ip, &port) ||
 	    str_to_uint(args[2], &seq) < 0) {
 		i_error("director(%s): Invalid SYNC args", conn->name);
 		return FALSE;
@@ -655,7 +655,7 @@
 	unsigned int port;
 
 	if (str_array_length(args) != 2 ||
-	    director_args_parse_ip_port(conn, args, &ip, &port) < 0) {
+	    !director_args_parse_ip_port(conn, args, &ip, &port)) {
 		i_error("director(%s): Invalid CONNECT args", conn->name);
 		return FALSE;
 	}