dovecot-2.2: auth: Fixed error handling in GSSAPI when __gss_use...

dovecot at dovecot.org dovecot at dovecot.org
Fri Aug 10 05:24:41 EEST 2012


details:   http://hg.dovecot.org/dovecot-2.2/rev/35ae9569de5a
changeset: 14804:35ae9569de5a
user:      Timo Sirainen <tss at iki.fi>
date:      Tue Jul 17 16:20:20 2012 +0300
description:
auth: Fixed error handling in GSSAPI when __gss_userok() was used.
An invalid username would have been treated as successful and auth process
probably would have crashed.

diffstat:

 src/auth/mech-gssapi.c |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (14 lines):

diff -r ced6a796f56d -r 35ae9569de5a src/auth/mech-gssapi.c
--- a/src/auth/mech-gssapi.c	Tue Jul 17 16:17:40 2012 +0300
+++ b/src/auth/mech-gssapi.c	Tue Jul 17 16:20:20 2012 +0300
@@ -416,8 +416,8 @@
 	bool ret = FALSE;
 
 	/* Parse out the principal's username */
-	if (!get_display_name(&request->auth_request, name, &name_type,
-			      &princ_display_name) < 0)
+	if (get_display_name(&request->auth_request, name, &name_type,
+			     &princ_display_name) < 0)
 		return FALSE;
 
 	if (!mech_gssapi_oid_cmp(name_type, GSS_KRB5_NT_PRINCIPAL_NAME) &&


More information about the dovecot-cvs mailing list