dovecot-2.2: Avoid doing side effects in assert.

dovecot at dovecot.org dovecot at dovecot.org
Fri Sep 6 02:40:10 EEST 2013


details:   http://hg.dovecot.org/dovecot-2.2/rev/209a1ef01426
changeset: 16714:209a1ef01426
user:      Timo Sirainen <tss at iki.fi>
date:      Fri Sep 06 02:39:56 2013 +0300
description:
Avoid doing side effects in assert.

diffstat:

 src/lib-imap-client/imapc-connection.c |  3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diffs (13 lines):

diff -r 00d0856b4a0b -r 209a1ef01426 src/lib-imap-client/imapc-connection.c
--- a/src/lib-imap-client/imapc-connection.c	Fri Sep 06 02:39:16 2013 +0300
+++ b/src/lib-imap-client/imapc-connection.c	Fri Sep 06 02:39:56 2013 +0300
@@ -1854,7 +1854,8 @@
 			/* %1s - no quoting */
 			const char *arg = va_arg(args, const char *);
 
-			i_assert(cmd_fmt[++i] == 's');
+			i++;
+			i_assert(cmd_fmt[i] == 's');
 			str_append(cmd->data, arg);
 			break;
 		}


More information about the dovecot-cvs mailing list