dovecot-2.2: auth: Internal passdb failures were always failing ...

[dovecot at dovecot.org]

details:   http://hg.dovecot.org/dovecot-2.2/rev/14082c2d81dd
changeset: 17714:14082c2d81dd
user:      Timo Sirainen <tss at iki.fi>
date:      Fri Aug 15 13:58:47 2014 +0300
description:
auth: Internal passdb failures were always failing the request even if another passdb succeeded later.

diffstat:

 src/auth/auth-request.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (21 lines):

diff -r c810e288aaed -r 14082c2d81dd src/auth/auth-request.c
--- a/src/auth/auth-request.c	Wed Aug 13 13:34:22 2014 +0300
+++ b/src/auth/auth-request.c	Fri Aug 15 13:58:47 2014 +0300
@@ -651,14 +651,14 @@
 			request->passdbs_seen_internal_failure = TRUE;
 		}
 		return FALSE;
+	} else if (request->passdb_success) {
+		/* either this or a previous passdb lookup succeeded. */
+		*result = PASSDB_RESULT_OK;
 	} else if (request->passdbs_seen_internal_failure) {
 		/* last passdb lookup returned internal failure. it may have
 		   had the correct password, so return internal failure
 		   instead of plain failure. */
 		*result = PASSDB_RESULT_INTERNAL_FAILURE;
-	} else if (request->passdb_success) {
-		/* either this or a previous passdb lookup succeeded. */
-		*result = PASSDB_RESULT_OK;
 	}
 	return TRUE;
 }