dovecot-2.2-pigeonhole: lib-sieve: edit mail: Fixed header itera...

pigeonhole at rename-it.nl pigeonhole at rename-it.nl
Tue Jun 17 21:37:58 UTC 2014


details:   http://hg.rename-it.nl/dovecot-2.2-pigeonhole/rev/743213918b1b
changeset: 1878:743213918b1b
user:      Stephan Bosch <stephan at rename-it.nl>
date:      Tue Jun 17 23:37:46 2014 +0200
description:
lib-sieve: edit mail: Fixed header iteration.
Handling of edit_mail_header_find() result was incoherent.
Problem reported by Coverity.

diffstat:

 src/lib-sieve/util/edit-mail.c |  5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diffs (15 lines):

diff -r 9401789c7332 -r 743213918b1b src/lib-sieve/util/edit-mail.c
--- a/src/lib-sieve/util/edit-mail.c	Tue Jun 17 23:28:53 2014 +0200
+++ b/src/lib-sieve/util/edit-mail.c	Tue Jun 17 23:37:46 2014 +0200
@@ -914,10 +914,7 @@
 		return -1;
 	}
 
-	if ( field_name != NULL
-		&& (header_idx=edit_mail_header_find(edmail, field_name)) == NULL ) {
-		return 0;
-	}
+	header_idx = edit_mail_header_find(edmail, field_name);
 
  	edhiter = i_new(struct edit_mail_header_iter, 1);
 	edhiter->mail = edmail;


More information about the dovecot-cvs mailing list