dovecot-2.2-pigeonhole: Removed all invocations of atoi().

pigeonhole at rename-it.nl pigeonhole at rename-it.nl
Sat Aug 29 13:04:47 UTC 2015


details:   http://hg.rename-it.nl/dovecot-2.2-pigeonhole/rev/a2e0882300c9
changeset: 2093:a2e0882300c9
user:      Stephan Bosch <stephan at rename-it.nl>
date:      Sat Aug 29 13:12:58 2015 +0200
description:
Removed all invocations of atoi().

diffstat:

 src/lib-sieve/storage/ldap/sieve-ldap-db.c |  11 +++++++----
 1 files changed, 7 insertions(+), 4 deletions(-)

diffs (33 lines):

diff -r f84fbac570f5 -r a2e0882300c9 src/lib-sieve/storage/ldap/sieve-ldap-db.c
--- a/src/lib-sieve/storage/ldap/sieve-ldap-db.c	Sat Aug 29 13:12:58 2015 +0200
+++ b/src/lib-sieve/storage/ldap/sieve-ldap-db.c	Sat Aug 29 13:12:58 2015 +0200
@@ -764,8 +764,7 @@
 			"deref", set->deref) < 0)
 		return -1;
 #ifdef LDAP_OPT_DEBUG_LEVEL
-	value = atoi(set->debug_level);
-	if (value != 0) {
+	if (str_to_int(set->debug_level, &value) >= 0 && value != 0) {
 		if (db_ldap_set_opt(NULL, LDAP_OPT_DEBUG_LEVEL, &value,
 				"debug_level", set->debug_level) < 0)
 			return -1;
@@ -798,13 +797,17 @@
 {
 	const struct sieve_ldap_storage_settings *set = &conn->lstorage->set;
 	struct sieve_storage *storage = &conn->lstorage->storage;
-	bool debug = atoi(set->debug_level) > 0;
 	struct timeval start, end;
-	int ret;
+	int debug_level, ret;
+	bool debug;
 
 	if (conn->conn_state != LDAP_CONN_STATE_DISCONNECTED)
 		return 0;
 
+	debug = FALSE;
+	if (str_to_int(set->debug_level, &debug_level) >= 0)
+		debug = debug_level > 0;
+
 	if (debug) {
 		if (gettimeofday(&start, NULL) < 0)
 			memset(&start, 0, sizeof(start));


More information about the dovecot-cvs mailing list