dovecot-2.2: script: Another comment update about protocol - the...

dovecot at dovecot.org dovecot at dovecot.org
Wed May 6 11:15:59 UTC 2015


details:   http://hg.dovecot.org/dovecot-2.2/rev/956e152467de
changeset: 18528:956e152467de
user:      Timo Sirainen <tss at iki.fi>
date:      Wed May 06 14:14:09 2015 +0300
description:
script: Another comment update about protocol - the previous one was wrong.

diffstat:

 src/util/script.c |  7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diffs (24 lines):

diff -r cf9e0cbf55a9 -r 956e152467de src/util/script.c
--- a/src/util/script.c	Wed May 06 11:10:09 2015 +0300
+++ b/src/util/script.c	Wed May 06 14:14:09 2015 +0300
@@ -79,7 +79,7 @@
 
 	   VERSION .. <lf>
 	   [alarm=<secs> <lf>]
-	   [noreply <lf>]
+	   "noreply" | "-" (or anything really) <lf>
 
 	   arg 1 <lf>
 	   arg 2 <lf>
@@ -87,8 +87,9 @@
 	   <lf>
 	   DATA
 
-	   It could be thought of either as a feature or a bug that alarm and
-	   noreply settings are mixed together with regular args..
+	   This is quite a horrible protocol. If alarm is specified, it MUST be
+	   before "noreply". If "noreply" isn't given, something other string
+	   (typically "-") must be given which is eaten away.
 	*/		
 	alarm(SCRIPT_READ_TIMEOUT_SECS);
 	scanpos = 1;


More information about the dovecot-cvs mailing list