dovecot-2.2-pigeonhole: lib-sieve: storage: Forgot to check whet...

pigeonhole at rename-it.nl pigeonhole at rename-it.nl
Thu May 7 20:05:45 UTC 2015


details:   http://hg.rename-it.nl/dovecot-2.2-pigeonhole/rev/f050c1de127c
changeset: 2049:f050c1de127c
user:      Stephan Bosch <stephan at rename-it.nl>
date:      Thu May 07 22:05:23 2015 +0200
description:
lib-sieve: storage: Forgot to check whether sieve_default_name setting exists.
This caused a segfault in the test suite.

diffstat:

 src/lib-sieve/sieve-storage.c |  3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diffs (13 lines):

diff -r 1414446ef704 -r f050c1de127c src/lib-sieve/sieve-storage.c
--- a/src/lib-sieve/sieve-storage.c	Thu May 07 21:46:57 2015 +0200
+++ b/src/lib-sieve/sieve-storage.c	Thu May 07 22:05:23 2015 +0200
@@ -500,7 +500,8 @@
 
 	set_default_name =
 		 sieve_setting_get(svinst, "sieve_default_name");
-	if ( !sieve_script_name_is_valid(set_default_name) ) {
+	if ( set_default_name != NULL && *set_default_name != '\0' &&
+		!sieve_script_name_is_valid(set_default_name) ) {
 		sieve_storage_sys_error(storage,
 			"Invalid script name `%s' for `sieve_default_name' setting.",
 			str_sanitize(set_default_name, 80));


More information about the dovecot-cvs mailing list