dovecot-2.2: lib: file_wait_lock_error() assert-crashes now on E...

dovecot at dovecot.org dovecot at dovecot.org
Wed Sep 16 01:48:06 UTC 2015


details:   http://hg.dovecot.org/dovecot-2.2/rev/19576fdbf950
changeset: 19149:19576fdbf950
user:      Timo Sirainen <tss at iki.fi>
date:      Wed Sep 16 10:46:44 2015 +0900
description:
lib: file_wait_lock_error() assert-crashes now on EDEADLOCK
It's always a bug and a crash can help debug it.

diffstat:

 src/lib/file-lock.c |  4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diffs (15 lines):

diff -r d8c27e220815 -r 19576fdbf950 src/lib/file-lock.c
--- a/src/lib/file-lock.c	Wed Sep 16 05:01:40 2015 +0900
+++ b/src/lib/file-lock.c	Wed Sep 16 10:46:44 2015 +0900
@@ -292,8 +292,10 @@
 	int ret;
 
 	ret = file_lock_do(fd, path, lock_type, lock_method, timeout_secs, error_r);
-	if (ret <= 0)
+	if (ret <= 0) {
+		i_assert(errno != EDEADLOCK);
 		return ret;
+	}
 
 	lock = i_new(struct file_lock, 1);
 	lock->fd = fd;


More information about the dovecot-cvs mailing list