dovecot-2.2: dsync: Removed unnecessary code - cur_mail is never...

dovecot at dovecot.org dovecot at dovecot.org
Sun Sep 27 18:51:03 UTC 2015


details:   http://hg.dovecot.org/dovecot-2.2/rev/83ccad730ea3
changeset: 19228:83ccad730ea3
user:      Timo Sirainen <tss at iki.fi>
date:      Sun Sep 27 21:33:30 2015 +0300
description:
dsync: Removed unnecessary code - cur_mail is never NULL at this point.
Found by Coverity.

diffstat:

 src/doveadm/dsync/dsync-mailbox-import.c |  9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diffs (19 lines):

diff -r a887dc2b3fb9 -r 83ccad730ea3 src/doveadm/dsync/dsync-mailbox-import.c
--- a/src/doveadm/dsync/dsync-mailbox-import.c	Sun Sep 27 21:30:56 2015 +0300
+++ b/src/doveadm/dsync/dsync-mailbox-import.c	Sun Sep 27 21:33:30 2015 +0300
@@ -1628,13 +1628,8 @@
 	} else {
 		(void)dsync_mailbox_find_common_expunged_uid(importer, change, result_r);
 	}
-	if (importer->cur_mail != NULL) {
-		*result_r = t_strdup_printf("%s (next local mail UID=%u)",
-					    *result_r, importer->cur_mail->uid);
-	} else {
-		*result_r = t_strdup_printf("%s (no more local mails)",
-					    *result_r);
-	}
+	*result_r = t_strdup_printf("%s (next local mail UID=%u)",
+				    *result_r, importer->cur_mail->uid);
 }
 
 int dsync_mailbox_import_change(struct dsync_mailbox_importer *importer,


More information about the dovecot-cvs mailing list