dovecot-2.2: Added NULL-check asserts to make static analyzer ha...

dovecot at dovecot.org dovecot at dovecot.org
Sun Sep 27 18:51:03 UTC 2015


details:   http://hg.dovecot.org/dovecot-2.2/rev/8d2f1c363853
changeset: 19230:8d2f1c363853
user:      Timo Sirainen <tss at iki.fi>
date:      Sun Sep 27 21:42:17 2015 +0300
description:
Added NULL-check asserts to make static analyzer happier.
These shouldn't be happening.

diffstat:

 src/config/doveconf.c                                       |  1 +
 src/plugins/push-notification/push-notification-driver-ox.c |  1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diffs (22 lines):

diff -r 5af9b91c38c0 -r 8d2f1c363853 src/config/doveconf.c
--- a/src/config/doveconf.c	Sun Sep 27 21:34:48 2015 +0300
+++ b/src/config/doveconf.c	Sun Sep 27 21:42:17 2015 +0300
@@ -300,6 +300,7 @@
 		key = strings[i] + skip_len;
 		if (unique_key) key++;
 		value = strchr(key, '=');
+		i_assert(value != NULL);
 		o_stream_nsend(output, key, value-key);
 		o_stream_nsend_str(output, " = ");
 		if (hide_passwords && value[1] != '\0' &&
diff -r 5af9b91c38c0 -r 8d2f1c363853 src/plugins/push-notification/push-notification-driver-ox.c
--- a/src/plugins/push-notification/push-notification-driver-ox.c	Sun Sep 27 21:34:48 2015 +0300
+++ b/src/plugins/push-notification/push-notification-driver-ox.c	Sun Sep 27 21:42:17 2015 +0300
@@ -265,6 +265,7 @@
     push_notification_driver_ox_init_global(user);
 
     messagenew = push_notification_txn_msg_get_eventdata(msg, "MessageNew");
+    i_assert(messagenew != NULL);
 
     http_req = http_client_request_url(ox_global->http_client, "PUT",
                                        dconfig->http_url,


More information about the dovecot-cvs mailing list