[dovecot/core] 0e2e52: lib-storage: Fixed error handling for mailbox_list...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/dovecot/core
  Commit: 0e2e52670663aa870a606bbb44c6b257f7287b58
      https://github.com/dovecot/core/commit/0e2e52670663aa870a606bbb44c6b257f7287b58
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-storage/list/mailbox-list-iter.c

  Log Message:
  -----------
  lib-storage: Fixed error handling for mailbox_list_iter_init_namespaces()

If iteration for the first namespace failed, we tried to copy the error
string to error_list, which was the same first namespace's list. This caused
the error string to be freed while it was being copied, so the end result
was that the error became either an empty or garbage string.


  Commit: 8cd9a1249c3b7fe16150ddae46e1ae0fc639e220
      https://github.com/dovecot/core/commit/8cd9a1249c3b7fe16150ddae46e1ae0fc639e220
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  imapc: Code cleanup - Use a common function for checking/logging if we want to reconnect or disconnect


  Commit: 5ba8e641e1cfe122af4830c82da446bfb41e9946
      https://github.com/dovecot/core/commit/5ba8e641e1cfe122af4830c82da446bfb41e9946
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-imap-client/imapc-client.c

  Log Message:
  -----------
  imapc: Code cleanup - imapc_connection_reconnect() is now always called when reconnect is ok.


  Commit: 5e02162c536e5dd50198828b121f24590a0158bd
      https://github.com/dovecot/core/commit/5e02162c536e5dd50198828b121f24590a0158bd
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  imapc: Fixed checking of whether same IMAP command keeps crashing server.

reconnect_command_count was counting only the post-login commands, but we
were decreasing it also for pre-login commands. This caused it to shrink to
0 too early.


  Commit: b60daa2dcb94b129a25ab5b42a2c6b6748c781aa
      https://github.com/dovecot/core/commit/b60daa2dcb94b129a25ab5b42a2c6b6748c781aa
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-imap-client/imapc-client.c
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/imapc-connection.h

  Log Message:
  -----------
  imapc: Prepare for non-mailbox command retrying: Set reconnect_command_count earlier

This probably doesn't fix itself anything yet, but is needed for the
following changes.


  Commit: 3153bce79e1260a13796d7471597b6360b2da0d1
      https://github.com/dovecot/core/commit/3153bce79e1260a13796d7471597b6360b2da0d1
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  imapc: Support retrying for non-mailbox commands.


  Commit: 1e85b60d6b89f5c0f195a6ffe84eacbc5d5cd5fa
      https://github.com/dovecot/core/commit/1e85b60d6b89f5c0f195a6ffe84eacbc5d5cd5fa
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c

  Log Message:
  -----------
  imapc: Support retrying after connect/authentication timeouts.


  Commit: e4020d174b147924a279a3b608e0223a2c234c2b
      https://github.com/dovecot/core/commit/e4020d174b147924a279a3b608e0223a2c234c2b
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-imap-client/imapc-connection.c
    M src/lib-imap-client/imapc-connection.h

  Log Message:
  -----------
  imapc: Support retrying after connect() failure.


  Commit: e74f4afdd0cdeeb9a5cebd7973dfc9adbe6cb426
      https://github.com/dovecot/core/commit/e74f4afdd0cdeeb9a5cebd7973dfc9adbe6cb426
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: Fixed mailbox_exists() error handling.


  Commit: 2a7a7f69b2b2d22b2dbca60917accabddd252255
      https://github.com/dovecot/core/commit/2a7a7f69b2b2d22b2dbca60917accabddd252255
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-list.c

  Log Message:
  -----------
  imapc: Added missing error handling to subscriptions list refreshing.


  Commit: 461bcfc20fb32b086b83a38e4aa7f1e5351bbcc7
      https://github.com/dovecot/core/commit/461bcfc20fb32b086b83a38e4aa7f1e5351bbcc7
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-list.c
    M src/lib-storage/index/imapc/imapc-list.h

  Log Message:
  -----------
  imapc: If root separator lookup fails, fail all further lookups.

We already returned a potentially wrong separator (since there's no way to
return error), so we don't want to continue and possibly make things worse.


  Commit: 06116e6a19bc4916ddf349108e59e38eda83d533
      https://github.com/dovecot/core/commit/06116e6a19bc4916ddf349108e59e38eda83d533
  Author: Timo Sirainen <timo.sirainen at dovecot.fi>
  Date:   2016-04-12 (Tue, 12 Apr 2016)

  Changed paths:
    M src/lib-storage/index/imapc/imapc-list.c
    M src/lib-storage/index/imapc/imapc-save.c
    M src/lib-storage/index/imapc/imapc-storage.c

  Log Message:
  -----------
  imapc: Mark most of the commands retriable.


Compare: https://github.com/dovecot/core/compare/03af8e5325a7...06116e6a19bc